From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6834C433EF for ; Wed, 4 May 2022 16:24:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BStGBK+eXgMVwc+7NpsBB5OFPuPZQ6S05gVuv/vrB2Q=; b=NdM9tK7pYwdnBg RIE4zqJtyXHBuf60XJjbHr9aAx5GzuOUDcueawQVA6P3F/ynKQLzd/TlFy38JOcS4quSG+eqIa5Df ygOwUOHzS8MnX7uyhjMZJmy5y+P/1LOJqCf2FYodYvS0J+QCEq59i30RTmE2AjAtBljYLszF/z//N 8SH7O0ofHW+K7oDI+ruXy1VruxijR6fpuAGE2ET4CfxPWtZk8avxbztCV1wo8bKL8rWChPvaTGEY0 W7KyVjDxV6Y0WH5Gfr9y+/S8E/b6mGKwmezXxkpfS26Al4qrcik2OB/BPwoo7XZq/hwtI1d80UBTm fvl4WnkocjSR1v0DPwqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmHmW-00Be5E-96; Wed, 04 May 2022 16:23:16 +0000 Received: from smtp-fw-80007.amazon.com ([99.78.197.218]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmHmT-00Be35-Bu for linux-arm-kernel@lists.infradead.org; Wed, 04 May 2022 16:23:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1651681393; x=1683217393; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=2Q/yiQSP0UKyBh6YQJ5BaZo0I0IrAyfxQYHuply2jAk=; b=lchTyLHlyHLYgkhpm0dkoooBkafoXtOofjawiROuxIep/WDbeKD8d+aj HP7P8URKCtpDYJHH3+fkEGwHcRIHGbdw+13xYJb1x0tZDP+2+OQG6uA5b 6c+qfbFpwcfNwmVhwRRTzRcD51eUNlUHwnFz2wIMQYcwTVry/S1EDQX3h o=; X-IronPort-AV: E=Sophos;i="5.91,198,1647302400"; d="scan'208";a="85452775" Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO email-inbound-relay-iad-1d-1c3c2014.us-east-1.amazon.com) ([10.25.36.210]) by smtp-border-fw-80007.pdx80.corp.amazon.com with ESMTP; 04 May 2022 16:22:35 +0000 Received: from EX13MTAUWC001.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan2.iad.amazon.com [10.40.163.34]) by email-inbound-relay-iad-1d-1c3c2014.us-east-1.amazon.com (Postfix) with ESMTPS id 60F5DE42C8; Wed, 4 May 2022 16:22:30 +0000 (UTC) Received: from EX13D02UWC001.ant.amazon.com (10.43.162.243) by EX13MTAUWC001.ant.amazon.com (10.43.162.135) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Wed, 4 May 2022 16:22:23 +0000 Received: from EX13MTAUEA001.ant.amazon.com (10.43.61.82) by EX13D02UWC001.ant.amazon.com (10.43.162.243) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Wed, 4 May 2022 16:22:23 +0000 Received: from dev-dsk-alisaidi-1d-b9a0e636.us-east-1.amazon.com (172.19.181.128) by mail-relay.amazon.com (10.43.61.243) with Microsoft SMTP Server id 15.0.1497.32 via Frontend Transport; Wed, 4 May 2022 16:22:22 +0000 Received: by dev-dsk-alisaidi-1d-b9a0e636.us-east-1.amazon.com (Postfix, from userid 5131138) id B54541D1A; Wed, 4 May 2022 16:22:22 +0000 (UTC) From: Ali Saidi To: CC: , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v7 5/5] perf arm-spe: Use SPE data source for neoverse cores Date: Wed, 4 May 2022 16:22:20 +0000 Message-ID: <20220504162220.28528-1-alisaidi@amazon.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <458a2de1-dc93-7e2d-5dc5-fbcd670572b6@arm.com> References: <458a2de1-dc93-7e2d-5dc5-fbcd670572b6@arm.com> MIME-Version: 1.0 Precedence: Bulk X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220504_092313_650017_CB17EA81 X-CRM114-Status: GOOD ( 22.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi German, Thanks for taking another look! On Tue, 3 May 2022 09:58:15 +0000, German Gomez wrote: > Hi Ali, Leo > > Some minor comments below. > > On 26/04/2022 14:59, Ali Saidi wrote: > > When synthesizing data from SPE, augment the type with source information > > for Arm Neoverse cores. The field is IMPLDEF but the Neoverse cores all use > > the same encoding. I can't find encoding information for any other SPE > > implementations to unify their choices with Arm's thus that is left for > > future work. > > > > This change populates the mem_lvl_num for Neoverse cores as well as the > > deprecated mem_lvl namespace. > > > > Signed-off-by: Ali Saidi > > --- > > .../util/arm-spe-decoder/arm-spe-decoder.c | 1 + > > .../util/arm-spe-decoder/arm-spe-decoder.h | 12 ++ > > tools/perf/util/arm-spe.c | 130 +++++++++++++++--- > > 3 files changed, 127 insertions(+), 16 deletions(-) > > > [snip] > > + /* > > + * We have no data on the hit level or data source for stores in the > > + * Neoverse SPE records. > > + */ > > + if (record->op & ARM_SPE_ST) { > > + data_src->mem_lvl = PERF_MEM_LVL_NA; > > + data_src->mem_lvl_num = PERF_MEM_LVLNUM_ANY_CACHE; > > Is it correct to use ANY_CACHE as the NA value? The LVLNUM_* enum begins at 1, so it looks like this should be set to 0 instead (like in HOPS_*). I think you're making a good point here. To be consistent we should set mem_lvl_num to PERF_MEM_LVLNUM_NA just like mem_lvl. Thanks, Ali _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel