From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28640C433EF for ; Fri, 6 May 2022 07:11:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YCLmFaHfG+Y+9APR9ADjRUIxUul+2PaWSGiOnxpiDR0=; b=VJ3EsQKCligkn9 1Iz6udDdfD5rTI/EL4c3u0w3i7HFmDs1u3EP7D/zCWBEQA7vaXV0Nh4Sdl8yJZbDLfatneqUY0/hS g7ecPb1GsZfKYbfsozpipQJqbNldY0ZuBLU+HD5fH/dIavYKBMemejAyIyiynaQk/yv2Zhy5DUvH6 /8vxYSciWN+RoJALVsCyvSD7tRO1zMhe3mp3DjZwvyzAAeJVGyBz8Ih+lrP6Lf/94dreRWtmL82ow bKO6YJJ1Xkm6NFM9EN4L7prlLf2YDDSSlZ1tTN17Kry2NQodLIwCUMI+fW7PZW4bjVmgnZ1ctTMgU 1/Pk3jl5aIvNBmA3l/Rw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nms6p-001lMc-Tc; Fri, 06 May 2022 07:10:40 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nms6m-001lKq-U3 for linux-arm-kernel@lists.infradead.org; Fri, 06 May 2022 07:10:38 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nms6h-0003k7-Em; Fri, 06 May 2022 09:10:31 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nms6e-0001g4-87; Fri, 06 May 2022 09:10:28 +0200 Date: Fri, 6 May 2022 09:10:28 +0200 From: Sascha Hauer To: Heiko =?iso-8859-15?Q?St=FCbner?= Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Peter Geis , Rob Herring Subject: Re: [PATCH v11 16/24] arm64: dts: rockchip: rk356x: Add VOP2 nodes Message-ID: <20220506071028.GS4012@pengutronix.de> References: <20220422072841.2206452-1-s.hauer@pengutronix.de> <1911394.usQuhbGJ8B@diego> <20220505064131.GF4012@pengutronix.de> <2508329.Lt9SDvczpP@diego> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2508329.Lt9SDvczpP@diego> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:06:01 up 36 days, 19:35, 74 users, load average: 0.40, 0.33, 0.26 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220506_001037_015404_ED74B70D X-CRM114-Status: GOOD ( 31.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 05, 2022 at 09:23:03AM +0200, Heiko St=FCbner wrote: > Am Donnerstag, 5. Mai 2022, 08:41:31 CEST schrieb Sascha Hauer: > > On Thu, May 05, 2022 at 02:28:24AM +0200, Heiko St=FCbner wrote: > > > Am Freitag, 22. April 2022, 09:28:33 CEST schrieb Sascha Hauer: > > > > The VOP2 is the display output controller on the RK3568. Add the no= de > > > > for it to the dtsi file along with the required display-subsystem n= ode > > > > and the iommu node. > > > > = > > > > Signed-off-by: Sascha Hauer > > > > Acked-by: Rob Herring > > > > --- > > > > + vop: vop@fe040000 { > > > > + reg =3D <0x0 0xfe040000 0x0 0x3000>, <0x0 0xfe044000 0x0 0x1000>; > > > > + reg-names =3D "regs", "gamma_lut"; > > > = > > > reg-names does not seem to be part of the dt-binding. > > > Though now in the vop2-driver I see that the code uses that naming. > > > = > > > I guess we might want to just go the vop1-way by using numbered > > > platform-resources via a follow-up patch and drop the regnames here? > > = > > Or we could document the reg-names properties in a follow-up patch. > > Wouldn't that be better? > = > Also a possibility. Although that of course leads us into the naming > bike-shed ;-) ... i.e. for reg-names I'd do "vop" + "gamme-lut" (dash ins= tead > of underscore) - instead of the ones used right now. I also like dashes better than underscores and "vop" describes it better than the generic "reg" name, so at least the two of us don't need to dive deeper into the naming bike-shed ;) > = > While using numbered resources would keep the commonality between > both vops I like the named resources better, but I'll leave it up to you. You decide, I'll create fixup patches in either direction. Sascha -- = Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel