From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 983F3C433F5 for ; Fri, 6 May 2022 23:19:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mOeWqY1wZL62M5Y3q2asQ6tT70aLnt6rlwUUkUT+JqU=; b=z4PAztdpS4f3V+ u30d7DZxqO3Ok5C0wXGbUJ9JlYstsHQNBFV6kOgxBq9Iaf1+39Jv0eOf466HnEeA3m3ijbv7ObIHk cS4EDyiK1PSxqWPETf6W2ZWWb5W/r9qdfDGbjJauaQIaJ5nhWEAVdzeW+hFBdGANODSzuuVbj6U4H kxb7IYlMHvdV4JHhUwLztiVuW94imV1EHoKFKQRykxf56CSS66vBn3xUB7w4XKgO8fsyXcf1V/ZmX aDu3XCqGfxnVKG+ssgjxXc2WW0+Z8tF+cfycB6yKRXl0K8Lc5EHuCP9z8RGIetQcQsds3t3tuoElP OWndrm+T8wcHdQivUDIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nn7Cs-005MAN-WB; Fri, 06 May 2022 23:17:55 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nn7Co-005M8g-Ed for linux-arm-kernel@lists.infradead.org; Fri, 06 May 2022 23:17:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651879069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wslZBJewjz4hJp3e76dVIXzGvwXKoz3kxZZ5099+eDo=; b=IKtSIY3WrZcPwbOBjH3GcKRof7QZ4h/dhLnaKxe9RcLCR6uEdP/zd5HXamIyRZmnlVqvSW mnZNQkchDAW8alPizSpyd2CNNjD2edP8LxcvNrgF0isfF4aIjjw/B4061Ell/dUV0IQGq+ QvKtwLPkoJ4jbe8o+Xgzp3wTm/Pk3cc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-106-RR9lHokKPZuzyx5pu4Jd9Q-1; Fri, 06 May 2022 19:17:46 -0400 X-MC-Unique: RR9lHokKPZuzyx5pu4Jd9Q-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 342FF101AA45; Fri, 6 May 2022 23:17:45 +0000 (UTC) Received: from localhost (ovpn-12-33.pek2.redhat.com [10.72.12.33]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1A3BE2026614; Fri, 6 May 2022 23:17:41 +0000 (UTC) Date: Sat, 7 May 2022 07:17:37 +0800 From: Baoquan He To: Zhen Lei Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , linux-kernel@vger.kernel.org, Dave Young , Vivek Goyal , Eric Biederman , kexec@lists.infradead.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Rob Herring , Frank Rowand , devicetree@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org, Randy Dunlap , Feng Zhou , Kefeng Wang , Chen Zhou , John Donnelly , Dave Kleikamp Subject: Re: [PATCH v24 5/6] of: Support more than one crash kernel regions for kexec -s Message-ID: <20220506231737.GD122876@MiWiFi-R3L-srv> References: <20220506114402.365-1-thunder.leizhen@huawei.com> <20220506114402.365-6-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220506114402.365-6-thunder.leizhen@huawei.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220506_161750_609594_3F4B0A03 X-CRM114-Status: GOOD ( 22.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/06/22 at 07:44pm, Zhen Lei wrote: > When "crashkernel=X,high" is used, there may be two crash regions: > high=crashk_res and low=crashk_low_res. But now the syscall > kexec_file_load() only add crashk_res into "linux,usable-memory-range", > this may cause the second kernel to have no available dma memory. > > Fix it like kexec tool do for option -c, add both 'high' and 'low' regions ~~~~~~~~~~~~ kexec-tools does Other than this, LGTM, Acked-by: Baoquan He > into the dtb. > > Signed-off-by: Zhen Lei > Acked-by: Rob Herring > --- > drivers/of/kexec.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/of/kexec.c b/drivers/of/kexec.c > index b9bd1cff179388c..8d374cc552be5f2 100644 > --- a/drivers/of/kexec.c > +++ b/drivers/of/kexec.c > @@ -386,6 +386,15 @@ void *of_kexec_alloc_and_setup_fdt(const struct kimage *image, > crashk_res.end - crashk_res.start + 1); > if (ret) > goto out; > + > + if (crashk_low_res.end) { > + ret = fdt_appendprop_addrrange(fdt, 0, chosen_node, > + "linux,usable-memory-range", > + crashk_low_res.start, > + crashk_low_res.end - crashk_low_res.start + 1); > + if (ret) > + goto out; > + } > } > > /* add bootargs */ > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel