From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EEF37C433EF for ; Sun, 8 May 2022 16:33:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=II5VfKcjildepRH8T+eXORCSl77XbzWeoz7pDCvYuOg=; b=Un6+QlfcWcEAaM hx7yU1fTRS937zveUZGHNKZSxjzVEBOhnhD2dbcNx+Yd9VIVqO1XsbBkuhaK90vqOVph+GiyHctlF O6zm47NwbUGWpSAjJUAZbo8jWQRy8mXKyNoXPv2Uyex5Lx/jyaT14q3Ch936WU8w3wtY/k0EW3AvD +zKBb4z7lZeTx7V9GhLo1WT5updrjS75ZJfpQj3Ba/2XLzM5kw3gu20XfNOd3gUpBVOE+pqHK2lw9 e+1C5L9pgzxcukcn/IblyA4E3Ix9u06sH3eP+uf5FT6HK9YS82NN1oe/79hfGirSzZfCqSmJjox5P xnrz9Uyt5l7O7i1dDhFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnjov-00AdTh-RQ; Sun, 08 May 2022 16:31:45 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnjos-00AdSK-My for linux-arm-kernel@lists.infradead.org; Sun, 08 May 2022 16:31:44 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3198FB80D40; Sun, 8 May 2022 16:31:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9894C385A4; Sun, 8 May 2022 16:31:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652027500; bh=7MgR0NYJRGbJa+LPw9qiBhyvWkrrsYTNDfuJ4QVN6mI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dJWvhCWKHXRCUW2TZBIJ2APUbDOgPg6DO3OTuHsYWXfV4suITQLMkNm3NCCNzOJRu 67Hr6iO6C8cczPGKR8x3x3mxhuTWaN7Rak8Wb+CEUh76yA1fmgK2ZyQmdf+RkARsuz 2ahNPweNa/yqy+E7Bzi/ISqTYYSZpBVFepzYMVADUQGor4h04lF2y3TU1nEdhEvBiO nROTY7ctNJhC6KtnNafcmEHpbte7xUDv2hywjfeHH9UeQY54Gr2zMctYez0vZC0IMn kCRUn45uXbkm1r/GzOZ4qU3eS3LrsMcLYPfXaxYeNFr4QcGW085j7YmWU3o3mEgxul /v8LdflK5a0PA== Received: by pali.im (Postfix) id 5C5327F7; Sun, 8 May 2022 18:31:37 +0200 (CEST) Date: Sun, 8 May 2022 18:31:37 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: "Russell King (Oracle)" Cc: Giammarco lynx , linux-arm-kernel@lists.infradead.org Subject: Re: Question abount VSOL/CarlitoxxPro SFP Patch on Marvell Armada (MCBIN DS) Message-ID: <20220508163137.oj5dkzbxir7vu63i@pali> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220508_093142_934248_C818EC06 X-CRM114-Status: GOOD ( 20.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello! On Monday 07 March 2022 23:01:18 Russell King (Oracle) wrote: > > > [ 86.013661] sfp sfp-eth3: Detected broken RTL8672/RTL9601C emulated EEPROM > > > [ 86.020569] sfp sfp-eth3: Switching to reading EEPROM to one byte at a time > > > [ 86.067758] sfp sfp-eth3: module OEM V2801F > > > rev 1.0 sn 202101195032 dc 210119 > > > [ 86.077555] mvpp2 f4000000.ethernet eth3: requesting link mode > > > inband/1000base-x with support 0000000,00000200,00000440 > > > [ 86.088390] sfp sfp-eth3: tx disable 1 -> 0 > > We've now detected what the module is, and we configure for it, which > the EEPROM indicates it supports 1200Mbaud, which is 1G speed. ... > > > In that way it goes up. So how can we avoid this behaviour? > > Very difficult to avoid it. My guess is that when you power up the > system with the module inserted, it sees the interface operating at > 2.5G speed and locks itself to 2.5G speed. > > Eventually, our kernel boots, and sfp reads the EEPROM. The EEPROM > indicates that it supports 1G speed, so we switch the host interface > to 1000base-X, and that causes link to be lost (although I don't see > any sign of that happening in your debug.) > > That means that the module has decided to use 2.5G speed, but its > reporting it supports 1G speed in the EEPROM... so its doing something > different. No surprises that the link fails to come up. > > We could add an entry to the sfp_quirks[] table in sfp-bus.c for this > module using the sfp_quirk_2500basex function to also indicate it > supports 2.5G speed: > > }, { > // VSOL/CarlitoxxPro SFP can also work at 2.5G speed > .part = "V2801F", > .modes = sfp_quirk_2500basex, RTL8672/RTL9601C chips support only 1000base-x mode and therefore SFP cannot operate on CPU side at 2500base-x nor in other way at 2.5G. Trying to "force" mode to 2500base-x would not work. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel