From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EB75C433F5 for ; Mon, 9 May 2022 10:35:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GeV0VoQ1HgRshGNWKskCMm8+6Hg+f7Io9Y6bBNZEeEg=; b=mWFHzl6U4ofxOO HTqoaApC7SfcDx/AIdux5r4YI5naxx07w4Pjdbx8dRA9pddE4AxhmWZW5nTAOH0wMQW40V3Ziyfuj 56cdNylvln4udRZNbIXbLFHmQvJMCZCzbupm1BEE2HlDcqxCKV3VoZS0MMzPzxvXY5N7qobcLiK5z JCPxr44bfzSrMnmOjEgZXR/iA+iHcGQEKPP9gA6y7j8q/gVKYX6vxSSbAP4GeYg55yNM4Bf/Of0vs QsZ7dCg3AhqJ9zvB1Awzhqs2Wf4XMqGTOXo9qXYFjMkBWa8mu6muQjQ4r+L5g0bnd2XBiYXNiaHVN GngwpF1UPmyfFH7eNrLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1no0j7-00DnFM-SM; Mon, 09 May 2022 10:34:54 +0000 Received: from mail-ve1eur01on0620.outbound.protection.outlook.com ([2a01:111:f400:fe1f::620] helo=EUR01-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1no0j3-00DnEO-Qk for linux-arm-kernel@lists.infradead.org; Mon, 09 May 2022 10:34:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i1Gr8LOIGgyNzl/Y5bnTdZUP5AcDExUrAb18g8z8BJnlYr9PofNrEw0/KZuZ4lM/0pdquCRBr81iZE1phuJqtv5c7bf42EHjrL+dsc+fVyigdKex1FQAvIcvigjlB2uCqvuFpp5yI36xAb0b7iFsssQYQmog8KfxVyqKPYIodCKPC8sxF9MYabAlxpV097VSlIO81ZBainGjkCOPQo7zp7DczDI41OeaLiehGfc5qt/fX1ilQu/edhUw7uZHN39C4u8hR9uH/CLfE32Dutfa0BUgckzKHhPgSmNSBbnRkG5YkZIKwN2FDqQ0o+ngIR+3YRefKe8KE7NwWpumS64U8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L03YMi+ElqX/zXF/E/ZDJQIRGpKarPnTrl61ygBtXmY=; b=O0wzuPTP9Eb/KvoK85tKtNmcajpxyWJjuDulXEWS/mmP86e/TNnlTjRUhS8MatxHYNczlzdtk0G6ADJmvsuTOQ7XJ1ljYZlIzjNrjyq3ntBPMKbqt1NwZfrOfb5YHD2yeCN/tWbxVYTvWnyznIrpHm9vDKG/I2AAGLqrZS+x70VgGWmQMF03cjV+iEmQvFDjZxPTuUlpDxJ3H9+Ss+4rmQWr484cGVafbpdHi6bOWKXKqyv3zpCg7y5j5lDAWf+MtuTJb+00qBZT6LO8oC7kpKVEeFdzf2Bi3SGTfjhiRGR+oiSbU2mEk2B/lwIYvXpyOcyLcP8t2mm+l28OpPXJ9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L03YMi+ElqX/zXF/E/ZDJQIRGpKarPnTrl61ygBtXmY=; b=JwoMJqdzqxOAQrhPe9dfyswdYgOFBd0+bffgE4D42wCT5Ip3OSIVBcgJEui+5DeDeHeloz9fyoIcusbD0A95SwRcTVQZi1tt13HknV4d17zLBZAy0phOVvzxoBy8zITlJ6oHq9frypGaxf/WAcVeJCBk1WBVaA+5ehNdhvfchZ4= Received: from AM0PR04MB5121.eurprd04.prod.outlook.com (2603:10a6:208:c1::16) by DB7PR04MB4972.eurprd04.prod.outlook.com (2603:10a6:10:1c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Mon, 9 May 2022 10:34:45 +0000 Received: from AM0PR04MB5121.eurprd04.prod.outlook.com ([fe80::d42:c23c:780e:78eb]) by AM0PR04MB5121.eurprd04.prod.outlook.com ([fe80::d42:c23c:780e:78eb%4]) with mapi id 15.20.5227.022; Mon, 9 May 2022 10:34:45 +0000 From: Vladimir Oltean To: Colin Foster CC: "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "netdev@vger.kernel.org" , Terry Bowman , Wolfram Sang , Andy Shevchenko , Steen Hegelund , Lars Povlsen , Linus Walleij , Russell King , Heiner Kallweit , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Florian Fainelli , Vivien Didelot , Andrew Lunn , "UNGLinuxDriver@microchip.com" , Alexandre Belloni , Claudiu Manoil , Lee Jones Subject: Re: [RFC v8 net-next 15/16] net: dsa: felix: add phylink_get_caps capability Thread-Topic: [RFC v8 net-next 15/16] net: dsa: felix: add phylink_get_caps capability Thread-Index: AQHYYwz+Nv3GsOP+t02gQrIoyWAlJK0WWrEA Date: Mon, 9 May 2022 10:34:45 +0000 Message-ID: <20220509103444.bg6g6wt6mxohi2vm@skbuf> References: <20220508185313.2222956-1-colin.foster@in-advantage.com> <20220508185313.2222956-16-colin.foster@in-advantage.com> In-Reply-To: <20220508185313.2222956-16-colin.foster@in-advantage.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d94a41d0-ad90-4dfc-947c-08da31a78924 x-ms-traffictypediagnostic: DB7PR04MB4972:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5Tsk0p47dDXs6HH8H8/E1fztyWE03DB12cyslbiVVWelXsx6V81LXlfLGy/yLB/+gYQy2vdDNcPeLX7bRot8mpvFvNF65T4slppF04TGX6ixtpcr6lVHIwwYic14YGsxQDf4cXIEPkPUPLOPOa/mXgWJ4OhViAuT0rfiqsB+nt3zXBCo1iKAlyvyeCkgry8T2/GfjwGJU+tl+ZvIvcYtQxkR4Cg1ZOIaXMge8KNU9UGeBF/NVGHkngLJDp4s2MfhRFPJRf13RVZIf18jfjPR70w47KwJljrkhLsnKU9B6tc9YjAXcN8RvTtw2qBjdWRjtQ8TywYLP/fsaD2/uyB7f71TOPaMw4Jcc8RaGC8fHIXXgWArm9Xmoh/HnmgyonhWqFm5inUDdlB84FZ3/HBsctaLJyEigh0wc6uuDYRq0OmUPQdsY312E9r/WPaGKzyed9mJO6yXXjTbtCtgV/v4PAbtzx0/8KyeF84nZ1amcMxM3PvpU+5oPfz6f2pVTvp6Ohpjl9UQgGOIo0DGrnmNrSEXJHfrMDoOIKwnzYnHPaK90JvLdlTQjgjFZeYiXYEG6SUVE+lSTjEcborQ3pVcmrvDV+SDPOxtm0pCz6aMYmZLmZeXRmxs6zxbu9o82uqp1pR5LSiTRpuLDh+QWjxYi5iPeMp0mEoPJp5Tni3PJO3BTXF9NgZrU/JMmop8Os/NkwP3BUUR4LXMZBcEXM8jqw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR04MB5121.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(7916004)(4636009)(366004)(8936002)(316002)(66556008)(2906002)(66476007)(44832011)(9686003)(66446008)(8676002)(64756008)(4326008)(66946007)(76116006)(7416002)(38100700002)(38070700005)(5660300002)(122000001)(83380400001)(6506007)(26005)(54906003)(186003)(6512007)(1076003)(508600001)(71200400001)(33716001)(86362001)(6486002)(91956017)(6916009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?H6dd8j0gCNMdcuOpJ+MP5gC7tyelNJ8n5ID9sy5pKcpPfrZQGixuUvdliWIN?= =?us-ascii?Q?A7rr1GTFo8zaIDMu2uQTcV2WNUYu2Zb/NnmJSKsTrX9pie9SPBuxkpmOO81e?= =?us-ascii?Q?qMeyZRD9jbo7th7uICUNbTG/C0qJmGIpOeOimNzi3KfZSaR1/As/YUm6ForD?= =?us-ascii?Q?cudQJFP2j/5dYigXCezlq29RUHMaWMvXskZYnMu13UNqu9JtwM2cgDPs+t+0?= =?us-ascii?Q?sdzy7QLyDob7g1TZKk7tIvaxKwMEC2eVyY33C3dFb+GXRLlcqMlhzSvOx8U6?= =?us-ascii?Q?GrrWQWJYvlTVbrPBlXv9tVX/T3kZRVAejEjW4XStXOcKvZ+dRIT+kdSF1jG6?= =?us-ascii?Q?GALoKmaGGMV7dUIJbAAioH/viKmAkz1NeKY0t+OMcF4mlQwGlYvqmAoiQTqV?= =?us-ascii?Q?E7X2oFYhVy6ItOiCIsYmLok8XRoSJrfUuXU4AN3tgBQX/84N42Mdv6tEAN2F?= =?us-ascii?Q?J50mnytVr9eo58rZh1zuTJLOwyX1wQKm5e7GNU1zbVOWHTagNursN6AGf5eY?= =?us-ascii?Q?tt9zLq+/vhTJ7DZBfgG9QxF8Ose58waYUGp0Bc9iOE4hiY6RNR3YSSL3H7yS?= =?us-ascii?Q?EdYWCPMr73K+lNdGIcIaleez8iFjO6+xjNpkDbsbOr+MJkVb3RuEbQMa8z60?= =?us-ascii?Q?RhGBRgjSFvd6757oRWwK3CeTkjRUWMGTTCH/2uZY50EWBMpVLmaIdpRDtf8e?= =?us-ascii?Q?gYYujr/b6bUNi9w/2/C32vs0yHtSsyEQ3KS9VzN2s80CnUEnYqXGxYt+5hWY?= =?us-ascii?Q?xNTLfEmGPRFp7nTEKxaH/nGxNl9ZqrzvaHw1en6hJ9yNDR5DQBdJPDjWdAEJ?= =?us-ascii?Q?BiTEG7nGQPdAeO3K042TrXpCIrbP426jVaqOGsWuZn3jRxvjZtLGL8Lt2ubE?= =?us-ascii?Q?Tx/HZplRVgpaTs54ozqllL6geH/HgRyPK6pQbEIaNR/yAAnVDu70a3o5TDwm?= =?us-ascii?Q?gJYiLw9DEwjZdeP9p6gLoRk8TI3n54w3hNsKiE+JNnS6BRkADjr319nlLD8l?= =?us-ascii?Q?IYf9+M5lL2TqLjOWO40tt3i9vLNsqxTfhPlHL+ymMHeCr675gR1JVzrMsCoX?= =?us-ascii?Q?dKvqZ5jtV7mLwMqKpAnduzeSOvYSoDU2qq4tW4ZF8byq2PiP6a4Okyaq+RK1?= =?us-ascii?Q?yjt0fL9BtFoXsRzDNXTwAeAKBIGTOpyVmTKVbieBhZYfrui1yUNgMpCdK3kX?= =?us-ascii?Q?pzMzloY0lvBlYp//GqeiiUMZsdDIhEJpGglZqTyXxZb0s64VnS4CGYEhQK+W?= =?us-ascii?Q?ODPaMn+h5zhwKI4jjq7Y2fKGYj7MiGerI0n3MIm/QAujAw1DkaIs91TVoL5X?= =?us-ascii?Q?sWnb1S+z7rrt1R6edv1S1iM2Rw6sPlQaW/r9pVtSNoQI1zMC9mJX6T6j22ZR?= =?us-ascii?Q?VZxzDhDKkKZmDvp4nIY46/fCi4JQrD9Ey6CZ24r64Uv4xBLk8zKpo5faHlYJ?= =?us-ascii?Q?iwChriEU0RMKyB2kBAWFEFmnQDN6oXbjbMvqzh3o36X4raryFzB09Cug4Uf+?= =?us-ascii?Q?vr8qaRgeI4msrcvh06A3fKFq26T6iUPBTQuLlwkPL4f7XxiybIXu+ahGKoBr?= =?us-ascii?Q?8ZHJeI0unySK9JNR8MY7JhFoFYrLJTvE2iah/K83aj979BUFaFXqSgROSCNq?= =?us-ascii?Q?flDLczVSCM8hpYxndTM0TFIhvmIOvbp2TRRSkO6fI5VWXb4o4Vf/yuOYjyT6?= =?us-ascii?Q?GqWziPCBRuzdsg/kpZv1qre/gh9lrlw2Q23wt9nypRcJ829Fij1NG6FMzMtB?= =?us-ascii?Q?atlvVD81Jl7UrtQdGVl2NNSKEkj4pOc=3D?= Content-ID: <00CCED0A6A4D1E4A9C6DD12A8757A383@eurprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5121.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d94a41d0-ad90-4dfc-947c-08da31a78924 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2022 10:34:45.6053 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CtK3YeuipeolNfIBU1cVvhWaoqDaviB2VtD77zkcEaaF+lzEN4XUfYkPTRRJD9ko82+01MtPT3ft5Xw9zgfeOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4972 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220509_033449_909413_D5906E73 X-CRM114-Status: GOOD ( 26.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, May 08, 2022 at 11:53:12AM -0700, Colin Foster wrote: > Add the ability for felix users to announce their capabilities to DSA > switches by way of phylink_get_caps. This will allow those users the > ability to use phylink_generic_validate, which otherwise wouldn't be > possible. > > Signed-off-by: Colin Foster > --- > drivers/net/dsa/ocelot/felix.c | 22 +++++++++++++++------- > drivers/net/dsa/ocelot/felix.h | 2 ++ > 2 files changed, 17 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c > index d09408baaab7..32ed093f47c6 100644 > --- a/drivers/net/dsa/ocelot/felix.c > +++ b/drivers/net/dsa/ocelot/felix.c > @@ -982,15 +982,23 @@ static void felix_phylink_get_caps(struct dsa_switch *ds, int port, > struct phylink_config *config) > { > struct ocelot *ocelot = ds->priv; > + struct felix *felix; > > - /* This driver does not make use of the speed, duplex, pause or the > - * advertisement in its mac_config, so it is safe to mark this driver > - * as non-legacy. > - */ > - config->legacy_pre_march2020 = false; > + felix = ocelot_to_felix(ocelot); > + > + if (felix->info->phylink_get_caps) { > + felix->info->phylink_get_caps(ocelot, port, config); > + } else { > > - __set_bit(ocelot->ports[port]->phy_mode, > - config->supported_interfaces); > + /* This driver does not make use of the speed, duplex, pause or > + * the advertisement in its mac_config, so it is safe to mark > + * this driver as non-legacy. > + */ > + config->legacy_pre_march2020 = false; I don't think you mean to set legacy_pre_march2020 to true only felix->info->phylink_get_caps is absent, do you? Also, I'm thinking maybe we could provide an implementation of this function for all switches, not just for vsc7512. > + > + __set_bit(ocelot->ports[port]->phy_mode, > + config->supported_interfaces); > + } > } > > static void felix_phylink_validate(struct dsa_switch *ds, int port, > diff --git a/drivers/net/dsa/ocelot/felix.h b/drivers/net/dsa/ocelot/felix.h > index 3ecac79bbf09..33281370f415 100644 > --- a/drivers/net/dsa/ocelot/felix.h > +++ b/drivers/net/dsa/ocelot/felix.h > @@ -57,6 +57,8 @@ struct felix_info { > u32 speed); > struct regmap *(*init_regmap)(struct ocelot *ocelot, > struct resource *res); > + void (*phylink_get_caps)(struct ocelot *ocelot, int port, > + struct phylink_config *pl_config); > }; > > extern const struct dsa_switch_ops felix_switch_ops; > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel