From: Will Deacon <will@kernel.org>
To: Gaosheng Cui <cuigaosheng1@huawei.com>
Cc: catalin.marinas@arm.com, broonie@kernel.org, pcc@google.com,
mark.rutland@arm.com, keescook@chromium.org, daniel.kiss@arm.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, wangweiyang2@huawei.com,
gongruiqi1@huawei.com
Subject: Re: [PATCH -next] arm64: add missing header dependencies
Date: Tue, 10 May 2022 11:40:15 +0100 [thread overview]
Message-ID: <20220510104014.GA27557@willie-the-truck> (raw)
In-Reply-To: <20220509061751.3434059-1-cuigaosheng1@huawei.com>
On Mon, May 09, 2022 at 02:17:51PM +0800, Gaosheng Cui wrote:
> We get one error when building module with processor.h:
>
> ./arch/arm64/include/asm/processor.h:263:36: error: implicit declaration of function ‘task_stack_page’;
> ((struct pt_regs *)(THREAD_SIZE + task_stack_page(p)) - 1)
> ./arch/arm64/include/asm/processor.h:266:42: note: in expansion of macro ‘task_pt_regs’
> #define KSTK_ESP(tsk) user_stack_pointer(task_pt_regs(tsk))
>
> task_stack_page is declared in linux/sched/task_stack.h, so this patch
> add the missing header dependencies.
>
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
> arch/arm64/include/asm/processor.h | 1 +
> 1 file changed, 1 insertion(+)
Do you know which commit is causing this error? I haven't seen any other
reports, but it's hard to know which tree should take your patch as it
stands.
Thanks,
Will
> diff --git a/arch/arm64/include/asm/processor.h b/arch/arm64/include/asm/processor.h
> index 73e38d9a540c..1c239841c4d6 100644
> --- a/arch/arm64/include/asm/processor.h
> +++ b/arch/arm64/include/asm/processor.h
> @@ -28,6 +28,7 @@
> #include <linux/build_bug.h>
> #include <linux/cache.h>
> #include <linux/init.h>
> +#include <linux/sched/task_stack.h>
> #include <linux/stddef.h>
> #include <linux/string.h>
> #include <linux/thread_info.h>
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-10 10:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 6:17 [PATCH -next] arm64: add missing header dependencies Gaosheng Cui
2022-05-10 10:40 ` Will Deacon [this message]
[not found] ` <3b692d9f-0f76-33b8-0c22-909a24377e33@huawei.com>
2022-05-11 8:30 ` Mark Rutland
2022-05-13 2:57 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220510104014.GA27557@willie-the-truck \
--to=will@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=cuigaosheng1@huawei.com \
--cc=daniel.kiss@arm.com \
--cc=gongruiqi1@huawei.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pcc@google.com \
--cc=wangweiyang2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox