From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFDCCC433F5 for ; Tue, 10 May 2022 11:09:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Gy+aknZVCbPEtdMq1YHBwuNXpVM8E0xduV+UTHeXnTQ=; b=uQhktfRByu/AHQ kCXpRuRQStfBHs9aLicBBapd24RpRkas2IdVXd/fh80GZWlW5S/9FoObIfZeldHuJjhd/GGc40pUH UBjDhTwESWYQVgqunvSry9NcquvoXURyKIA5eVtwMIjxjMJPpnl4Tn7B3jD2R/WhO0F9eNKf/yzha dsVtPa0PdmQUv3YM/Rc7YanrTOsr7eAI8EFAWzfltOOfjypnQ/DIN7O4zO6P6NlPA2cjbz7+HzlkZ J3W6RTHTPwHePlaWvKl/+sESc5hdSVvhBhQDBx6AYr39InCLq4pcAifwpo9gHzr7AO3N1c+WO5O22 Jy/0KGDWoIBxWhlq7uhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1noNjZ-001QNm-R4; Tue, 10 May 2022 11:08:54 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1noNic-001Prn-F3 for linux-arm-kernel@lists.infradead.org; Tue, 10 May 2022 11:07:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6F2C111FB; Tue, 10 May 2022 04:07:51 -0700 (PDT) Received: from bogus (unknown [10.57.0.250]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 70A193F66F; Tue, 10 May 2022 04:07:48 -0700 (PDT) Date: Tue, 10 May 2022 12:07:42 +0100 From: Sudeep Holla To: Suzuki K Poulose , Besar Wicaksono Cc: Will Deacon , catalin.marinas@arm.com, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, thanu.rangarajan@arm.com, Michael.Williams@arm.com, treding@nvidia.com, jonathanh@nvidia.com, vsethi@nvidia.com, Mathieu Poirier Subject: Re: [PATCH 0/2] perf: ARM CoreSight PMU support Message-ID: <20220510110742.ievkihggndpms3fn@bogus> References: <20220509002810.12412-1-bwicaksono@nvidia.com> <20220509092843.GB26264@willie-the-truck> <2e5e09f9-b71b-d936-e291-db8f94554b18@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2e5e09f9-b71b-d936-e291-db8f94554b18@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220510_040754_652632_9C975AA7 X-CRM114-Status: GOOD ( 27.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 09, 2022 at 11:02:23AM +0100, Suzuki K Poulose wrote: > Cc: Mike Williams, Mathieu Poirier > > On 09/05/2022 10:28, Will Deacon wrote: > > On Sun, May 08, 2022 at 07:28:08PM -0500, Besar Wicaksono wrote: > > > Add driver support for ARM CoreSight PMU device and event attributes for NVIDIA > > > implementation. The code is based on ARM Coresight PMU architecture and ACPI ARM > > > Performance Monitoring Unit table (APMT) specification below: > > > * ARM Coresight PMU: > > > https://developer.arm.com/documentation/ihi0091/latest > > > * APMT: https://developer.arm.com/documentation/den0117/latest > > > > > > Notes: > > > * There is a concern on the naming of the PMU device. > > > Currently the driver is probing "arm-coresight-pmu" device, however the APMT > > > spec supports different kinds of CoreSight PMU based implementation. So it is > > > open for discussion if the name can stay or a "generic" name is required. > > > Please see the following thread: > > > http://lists.infradead.org/pipermail/linux-arm-kernel/2022-May/740485.html > > > > > > Besar Wicaksono (2): > > > perf: coresight_pmu: Add support for ARM CoreSight PMU driver > > > perf: coresight_pmu: Add support for NVIDIA SCF and MCF attribute > > > > > > arch/arm64/configs/defconfig | 1 + > > > drivers/perf/Kconfig | 2 + > > > drivers/perf/Makefile | 1 + > > > drivers/perf/coresight_pmu/Kconfig | 10 + > > > drivers/perf/coresight_pmu/Makefile | 7 + > > > .../perf/coresight_pmu/arm_coresight_pmu.c | 1317 +++++++++++++++++ > > > .../perf/coresight_pmu/arm_coresight_pmu.h | 147 ++ > > > .../coresight_pmu/arm_coresight_pmu_nvidia.c | 300 ++++ > > > .../coresight_pmu/arm_coresight_pmu_nvidia.h | 17 + > > > 9 files changed, 1802 insertions(+) > > > > How does this interact with all the stuff we have under > > drivers/hwtracing/coresight/? > > Absolutely zero, except for the name. The standard > is named "CoreSight PMU" which is a bit unfortunate, > given the only link, AFAIU, with the "CoreSight" architecture > is the Lock Access Register(LAR). For reference, the > drivers/hwtracing/coresight/ is purely "CoreSight" self-hosted > tracing and the PMU is called "cs_etm" (expands to coresight etm). > Otherwise the standard doesn't have anything to do with what > exists already in the kernel. > > That said, I am concerned that the "coresight_pmu" is easily confused > with what exists today. Given that this is more of a "PMU" standard > for the IPs in the Arm world, it would be better to name it as such > avoiding any confusion with the existing PMUs. > Thanks Suzuki. I did suggest something similar[1] but asked to retain it so that it can be discussed in the bigger and right forum. > One potential recommendation for the name is, "Arm PMU" (The ACPI table is > named Arm PMU Table). But then that could be clashing with the armv8_pmu > :-(. > > Some of the other options are : > > "Arm Generic PMU" > "Arm Uncore PMU" I wasn't sure on this if there is any restriction on usage of this on Arm and hence didn't make the suggestion. But if allowed, this would be my choice too. -- Regards, Sudeep [1] https://lore.kernel.org/lkml/20220504182633.a3mwuiohfqtjvpep@bogus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel