From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A540C433F5 for ; Tue, 10 May 2022 15:41:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=czaIpSxhMRwTRB3+81RLZ6SvlaPpw+Pnr4wklcGrX4M=; b=4cS30U63O9UEOH G5xZdDSf8P6ae53tyID4vOyfHc6lRNHKPEol5OgN3asgRUzgORgKmND2uNCs746FpOG9uHefbJ6PC LiDMc5Aiwz68dwIGUVfOTBga1bZ6izBu/4aWl8Q3YTnDHXSRE6g+ShGRXirZq+eVrN5NAN1zB5F13 tgfX/sCMyhYzfFq9w3lyrgpdbNlSTK3Q8RnwOpIJlt2G7PjWaHSTOaxG3WRNMnuqSWwS1KGwwLWzB CiW6/mO2t+FGRHKFd7aHNS5nMxK7KXt1u38Y4JujOwnk+GgJg8bqiUsRnD7VNvWitv1PlMTmTP/LP XmVUrFmbQtZfAkOskbew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1noRxs-002n1h-W6; Tue, 10 May 2022 15:39:57 +0000 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1noRxp-002mzm-Bo for linux-arm-kernel@lists.infradead.org; Tue, 10 May 2022 15:39:54 +0000 Received: by mail-pg1-x536.google.com with SMTP id r192so10772453pgr.6 for ; Tue, 10 May 2022 08:39:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TexQcoy1INa3H3RyGRSFGrBbivB4pckav7YMaFBpAco=; b=vMeCrSuREZgQrJsrFXgOGWfXTsV90gDHy19ge+Sqoy+jrAjpsgqw+iaBUh2TrI+jhl oZT3r3TNvMDyD2EEtVt/4a0PRVUJ3eg7t6tDntXeSBScD/co/5kJCOjkGKNZH2HIZQSL 1hHo+ygxfWQn1qEgeTmCMpoSQ9VhP+VLMfH0HCyGccVUXnOB3nd6uoQI9Ej00o3twSOU H3VNBLQLnqZfQcnQn+e0T2F31aiyDtMzjKeFULkXw+fUi3TzXJ07ji1JSPAhnpUKF8fM T4370yurk4dCY9acKjPJMrONq/m/8ZyI/GLt8gVrw+qMPZGMzQ/WvP1M3WpzWs9wCUkj Wwxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TexQcoy1INa3H3RyGRSFGrBbivB4pckav7YMaFBpAco=; b=JZP4AnhNimqOwdJxkZ5OPVMXj0i4Z5o9QdiT8YMg+zALbPvuD7Lj6Rd/eZqzKPFUO+ 87QlLQBWvR3THd9R7SGbYLZs9GPyXt3jAGd1EJI0z4j1iQA7l4QVL9pQ0tCWTO2xKt2H QMZEMtnp2hK1nEOZYLoztGz+yU73xAwNFBpqBq4mJhVKhFlkhDySBYtImNh/yUcHsE4N vLUUvBYc07Y3WNHiPRabxKedFJOPhYTT9oq7MJOlW/LbCmLYOte55vOv1DxP92YIAHjF tdAR3fqlUYKrQZG8eP7Izlp9VPqTT3PfptFUEyehrZa/iFa+/5+U9hN/jx7MpoOoLBq1 dGUQ== X-Gm-Message-State: AOAM531g2NyAqciSF/ewtxKTY4ObIuwwXQLaQNqD0yblipLHSISLV7c/ 7pTuj82K+ZuslWzxm/4N9nX+nA== X-Google-Smtp-Source: ABdhPJzHSQ4IVVgAtQ06DqsKCgJgaiKVvxpPaCQY5JMkI1b40CMwR75N1x+WWdLkabIiGjyMH9VLIw== X-Received: by 2002:a63:2bc4:0:b0:3ab:1d76:64db with SMTP id r187-20020a632bc4000000b003ab1d7664dbmr16798613pgr.508.1652197188465; Tue, 10 May 2022 08:39:48 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id w23-20020aa78597000000b0050dc762817asm10769661pfn.84.2022.05.10.08.39.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 May 2022 08:39:46 -0700 (PDT) Date: Tue, 10 May 2022 09:39:44 -0600 From: Mathieu Poirier To: Mike Leach Cc: linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, suzuki.poulose@arm.com, leo.yan@linaro.org Subject: Re: [PATCH v3 0/5] coresight: syscfg: Extend configfs for config load Message-ID: <20220510153944.GA3112221@p14s> References: <20220414064457.12052-1-mike.leach@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220414064457.12052-1-mike.leach@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220510_083953_514160_D98C9CD7 X-CRM114-Status: GOOD ( 18.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 14, 2022 at 07:44:52AM +0100, Mike Leach wrote: > This set extends the configfs support to allow loading and unloading of > configurations as binary files via configfs. > > Additional attributes - load and unload are provided to in the > configurations group to implement the load functionality. > > Routines to generate binary configuration files are supplied in > ./tools/coresight. > > Example generator and reader applications are provided. > > Tools may be cross compiled or built for use on host system. > > Documentation is updated to describe feature usage. > > Changes since v2: > 1) Rebased & tested oo coresight/next - 5.18-rc2 > 2) Moved coresight config generator and reader programs from samples to > tools/coresight. Docs updated to match. (suggested by Mathieu) > 3) userspace builds now use userspace headers from tools/... > 4) Other minor fixes from Mathieu's review. > > Changes since v1: > 1) Rebased to coresight/next - 5.16-rc1 with previous coresight config > set applied. > 2) Makefile.host fixed to default to all target. > > Mike Leach (5): > coresight: configfs: Add in functionality for load via configfs > coresight: configfs: Add in binary attributes to load files > coresight: configfs: Modify config files to allow userspace use > coresight: tools: Add config file write and reader tools > Documentation: coresight: docs for config load via configfs I have started reviewing this set. Comments will be spread out over several days. I will advise when I am done. Thanks, Mathieu > > .../trace/coresight/coresight-config.rst | 166 +++++- > MAINTAINERS | 2 + > drivers/hwtracing/coresight/Makefile | 2 +- > .../coresight/coresight-config-file.c | 475 ++++++++++++++++++ > .../coresight/coresight-config-file.h | 126 +++++ > .../hwtracing/coresight/coresight-config.h | 27 + > .../coresight/coresight-syscfg-configfs.c | 91 ++++ > .../hwtracing/coresight/coresight-syscfg.c | 37 ++ > .../hwtracing/coresight/coresight-syscfg.h | 2 + > tools/coresight/Makefile | 51 ++ > tools/coresight/coresight-cfg-bufw.c | 303 +++++++++++ > tools/coresight/coresight-cfg-bufw.h | 26 + > tools/coresight/coresight-cfg-example1.c | 65 +++ > tools/coresight/coresight-cfg-examples.h | 27 + > tools/coresight/coresight-cfg-file-read.c | 197 ++++++++ > tools/coresight/coresight-cfg-filegen.c | 58 +++ > tools/include/uapi/coresight-config-uapi.h | 76 +++ > 17 files changed, 1724 insertions(+), 7 deletions(-) > create mode 100644 drivers/hwtracing/coresight/coresight-config-file.c > create mode 100644 drivers/hwtracing/coresight/coresight-config-file.h > create mode 100644 tools/coresight/Makefile > create mode 100644 tools/coresight/coresight-cfg-bufw.c > create mode 100644 tools/coresight/coresight-cfg-bufw.h > create mode 100644 tools/coresight/coresight-cfg-example1.c > create mode 100644 tools/coresight/coresight-cfg-examples.h > create mode 100644 tools/coresight/coresight-cfg-file-read.c > create mode 100644 tools/coresight/coresight-cfg-filegen.c > create mode 100644 tools/include/uapi/coresight-config-uapi.h > > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel