From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37D2CC433FE for ; Tue, 10 May 2022 16:00:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HGwSzbwpi8jARj6/cMmvQID0Q7fEkEdDI36dCClItpU=; b=aVecxqVFI1yhxi aJwwE/o1shBikpf3SfXfaMZLnJEr/XCtc/42WPz5ZanQiff2tHxLPCgaZFfao3FG2zpW66Vfi7FWn YC+4ColHwtMZ+Uppsphcp49pp4hn/vGeeddV7O7+AS1r++HI33zkkAefW0vtG8bH58Uj0VRubj1Uj ZM/Hsdwzy1IE8XUsU/d8/mfJUFqma8hmqjcJ7DVI+LD+XiKLQnM+RCSyENYAE8lhK+mUUhfKwID3E fztrmuNPPbXQSbGhWAhKiZ1m47G8Oah/vTHj41mA0Tbg898P0vYWeXryHQsuqbTtj4kgLySjGLxyu clo65uBn18mbevkivRFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1noSGN-002uLB-6n; Tue, 10 May 2022 15:59:03 +0000 Received: from mail-db5eur01on060f.outbound.protection.outlook.com ([2a01:111:f400:fe02::60f] helo=EUR01-DB5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1noSGK-002uId-22 for linux-arm-kernel@lists.infradead.org; Tue, 10 May 2022 15:59:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R7XrdWVGrstil0OfGXDP6RtEvoXVdhoQNQfoSSh7Ixaqte4UBqFfZGZKj1SpUVhCYABm9RE/e8pyoKbGrdv/oJ06zxogmcnopnInYQzW5BD/wJRY8z8pNPy8FHHqBjuQ+u1J5kbd4Boqnm0FpUFQKnJVky3QfDftNpvYRLjPw5OFwbXJZhmce14OZ+6+UzX3euMrJXI62SBVTq9+FMMd2W08D83YsbrlGHk+aVRYyRiXisjAW0IlZEb633VkaGq0ABNi1Xi+os/ZWPeVY2a3JtvOtxx6q8aFHeEqCLFKkq7DBRAyoDhkJ3vbJp5od0/Aqd1PFXFySuPqxGqv69hzUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d3uflw344q4QRIc/qUW+uFmUkKeHMuQuGKSkSBKL2v4=; b=jDkOZgPCn4RRMbEbaV4eTHXSNR/yi82W6ZjWxGKxU0JBWU/pIJPDtclng8wrZhynmuTprLDEwZigfg4w/8YHce79JXW+G9jSRioRnJaeV/ktOLMvYbEctxDjIxdlzrBMJ+PqVjYKPW7Tbecmqo8DfX3MH6HbBxrEhnoRZ+YaQjPr3bncltAYghrS2/bdrBfFd2r9Tw3pW3Qg5+9TmL+6sX05bhitRpNWbLKyJszLm0Z+nhtQxgP1IvSzWGgiJE0wyIwULOJYLhsuZLHaYvx6jpvIj3oLJ6tbOSDXb7vZ9szS/NysDu/f20/S14W83ld/9g9kYz4/25FwpKkSM8LSzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d3uflw344q4QRIc/qUW+uFmUkKeHMuQuGKSkSBKL2v4=; b=L03XqsbJy6bjAbueUfiwCJ3oCvkcXk9smFmEVH/PjLTTb33O3L60xAzf0u31LPcCBuC9/66W0VMfl7lIfWeqoM6UfYHVwe5DXhdHpW4UnlSfb1h42dgxme+kiDXjQIhGy6Vg2Xb9Ubr1ejbivZxycykN80AhQvcpuk+FWXQu12g= Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by AM0PR04MB4914.eurprd04.prod.outlook.com (2603:10a6:208:ce::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Tue, 10 May 2022 15:58:54 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::fd1f:cc16:dafe:4bf5]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::fd1f:cc16:dafe:4bf5%5]) with mapi id 15.20.5227.023; Tue, 10 May 2022 15:58:54 +0000 From: Vladimir Oltean To: Colin Foster CC: "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "netdev@vger.kernel.org" , Terry Bowman , Wolfram Sang , Andy Shevchenko , Steen Hegelund , Lars Povlsen , Linus Walleij , Russell King , Heiner Kallweit , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Florian Fainelli , Vivien Didelot , Andrew Lunn , "UNGLinuxDriver@microchip.com" , Alexandre Belloni , Claudiu Manoil , Lee Jones Subject: Re: [RFC v8 net-next 08/16] mfd: ocelot: add support for the vsc7512 chip via spi Thread-Topic: [RFC v8 net-next 08/16] mfd: ocelot: add support for the vsc7512 chip via spi Thread-Index: AQHYYwz1YnOGgXOqGkauFg8TINDh2q0YR5eA Date: Tue, 10 May 2022 15:58:54 +0000 Message-ID: <20220510155853.polwnf5t5angcx2a@skbuf> References: <20220508185313.2222956-1-colin.foster@in-advantage.com> <20220508185313.2222956-9-colin.foster@in-advantage.com> In-Reply-To: <20220508185313.2222956-9-colin.foster@in-advantage.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d60042d8-57f5-493f-6b77-08da329dfbca x-ms-traffictypediagnostic: AM0PR04MB4914:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jGgf6xQtvUQPrXe0DZTGrQOmmwfpfIjdS2KUzkG7yATKZzaimIwLTsB4cPqVNsh7CdmRj+DqAmM1cwfNhJef4Me8Nt52/cWY18oovMdCb2Cgnq7D1Wkw7ebbuN4XHJrGEQt/JRwulKyRpCRP1JSb2aEQqDdv5QEEqN1LovGXw2MKnwGfWA4HYKPHFM75zynFHScxVQUWDyWTxYgVAv4FxjBft812huQ+z3EioQRHllCCf0rsKOU0k+yBVsVK/Ft0e2F+iLZ/2oIJfAxitfCKYXVJ/AgX6ScfbRq0yFDitvfTALnc5MOOjnUnZ/SGihtTv7WN2kABr6mtIQM9w3yWNnXK1oOfprI4CDtoZuV0bO/7h/ZGfeAGLZ9814Vmmh8bS/ZumfQuh7RwExfA2pktp0uOL0tkZ5oJhDzVfkxPYzio2H1KNQ/x8miSu2svGeOiEL3Qo0SrfxtDCZYj9O8L9bU1jmNo3XlKCK5b2n/CMUfe/xppMPhE63zjFKlVHTfRMezBsIfv15CRzUiwPC4g5v4FW0/vUr60/1u77MXcG/1f5qEdluVxBym1+8vRM+5cVSwRlLLkZ59CgXY2cjGfCpcml+m0L1YpWZ5JFWZXF29v0pXhlLSUfniPkVK/wT8O7gL6YexlhAXcYPvgkiOHdjGY+kXZeLLJuyeJVRc6Jd/VOVy0mxq95OxGQk6SRw05Sq3opbS+0DNkZEnD8XWvFw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(7916004)(366004)(6512007)(9686003)(33716001)(38100700002)(38070700005)(2906002)(1076003)(91956017)(6506007)(71200400001)(86362001)(7416002)(44832011)(5660300002)(6916009)(26005)(66556008)(186003)(76116006)(8676002)(66476007)(66446008)(4326008)(66946007)(316002)(6486002)(64756008)(508600001)(122000001)(54906003)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2UPwsKWBXeMcA/aM8esaznTv47Y10gKqXeT7EyY0XT7SYbepJd9/ik/xsEcu?= =?us-ascii?Q?5OOqoyc3EZ6JvvcvEA3vg+BIBnb4m8xZ/Bag6TbstZpa8Fftml/xRJ6eHTGP?= =?us-ascii?Q?0ox8xk2I1kI45wKB44jQCDN+A7BnYJojNodZ7K5lfkgwvlelCQKiWD/iqv38?= =?us-ascii?Q?MOU8WaCT/8Bjck0U3G8J20bMEiX2boYVc+bjlYSPUMkEY2vQ/UExQoT3Wu6I?= =?us-ascii?Q?YIi1mY3ARM68GDjXp33x++kPBGMSzMFhBAXUPJqxj18Wb54a51qg2RaZB0sK?= =?us-ascii?Q?mTHYHxyRuK8li8CGHFcNkBaKXe6wASgamayXcu+hPRqtquciqGPJQxnLWobM?= =?us-ascii?Q?nweE6soM6dG2KxKvE3RkRe4HMMvIcR98863dqq0MmgOo6CyIXvN4ZNrzv5ik?= =?us-ascii?Q?iqC0tmMWfNm633HwqcTSGnCuXDyuJLNSuAjQIShCpehObY/pBxpCrXVQzhpQ?= =?us-ascii?Q?rgC3Ox68CZQUTdcXMtyO/7azLH6qT73fxiuc37AF/M7eCMb5WQdmopx/yUNm?= =?us-ascii?Q?uMod/LcuwO0eSeUIOmp6N4HUBgdD8yxs/uStbUYPN5I5XezzqKwkjo4aZ4rk?= =?us-ascii?Q?Qoq76/Q1lt1Jlfz4+rFbLB4uFrDEzbI23JLJrGI4TKjpUJEoRUyGGI/bwPiv?= =?us-ascii?Q?z0fMk01Djy9cMaNpSLyiLi8z+jBM7DHDlUZoevye/5yvn91+zDnV3/oI7D/c?= =?us-ascii?Q?JEFLAinw4djHx5/+CPpa4L+yl1QhG2mlpBn5ge2UWTjjR7jko7PWzKjJX5Hg?= =?us-ascii?Q?Sp+MS78CLCPQYBy64ZPXPy/8rvdGVhxg5/zmrJNriW07s4v7f8pSh1AjbHrt?= =?us-ascii?Q?kdKgruJgw+BVA7vB7vBGvFtKsYT2ZuF5vgiZELImVjhKt0qGVS8gDdzRPxuM?= =?us-ascii?Q?sm/koKbABcNIyEk1nTe32HHJ9rsozeEReSgAsb50zqnW7TYRfPnyjb5dOCts?= =?us-ascii?Q?eSFMuWgyi3LLaRqDhnBnMPLTfY/PyX211xEEXAe9Sqv2tR+mdsvsOw6QagYy?= =?us-ascii?Q?A+a3S1krXKRnGxkFW5fyd0SUZ3QVaOwbZwrgrshttMcYKB0zi065FEcPJbgz?= =?us-ascii?Q?q0XbCQFjfO4bn440rGf8EcgTJw7/dGXJXUvXPb1vle8rj9HWWu9A2fSYOSBg?= =?us-ascii?Q?plOGxHZNilgeQY81Li1h1iaK1dakm4CaPY2HEVGQ6eYJtBaQHUI7FSr6bce4?= =?us-ascii?Q?jdI8jpthNirNCdx6H1r4mqIPUCM1WWTbkGLREjtmoLZ7ni/vTVFynPmYjAHt?= =?us-ascii?Q?DB59M/3D+X4Rep+s+TTM73UVizyDOMBl6oJnSuTZ7L/DoatlT7kDVcN+EPQF?= =?us-ascii?Q?XF266oSUUvHjJuIMQ//VXH8zLUrFfdxVvK9hwP3nbUOlDgNvd5de3E104K/r?= =?us-ascii?Q?D0gDOFWOQxCzvckl55Mid1xFjdjHGGun2bHdpAsZLkmFaFkAJsdvnZRRvRG5?= =?us-ascii?Q?yXoElxJntuMLRwi/UFZmr12AJ7f5w06ec2Y56qrEQuO4JwL9V+ieO4kodRwI?= =?us-ascii?Q?So0mrX91WCpj4xZHw28QrvFR7Cl6HAsfb5W+X0ehcX6c1W+nPc2vDT9IFjmK?= =?us-ascii?Q?eb8RljifluAF4JUOSWWfvKZ3qrAkB89soJteV5F7pAJsKEGNMNsEH+qJNu+O?= =?us-ascii?Q?/H4dHtp1L9zxO/2I6yi8NFUHAGtkv8vuOPEzlcoytP5d5N6V0xo+kuz4g95A?= =?us-ascii?Q?vKdRJjqXpLKlX1pbqOBLVpbAZLdEfq6ZMK8Qnad9JYkZuBMN4czpS6ox7Y/2?= =?us-ascii?Q?tIEEx7yQSQwtunJC2sAUXEJs/giQoYQ=3D?= Content-ID: <3A9521602073F5459E049F7608246629@eurprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d60042d8-57f5-493f-6b77-08da329dfbca X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2022 15:58:54.1479 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nVbCSILJl5WkAbJr5w00iH2GRrsiRQs7lhbFGejPRSxRYhhq/vQ71yghzGKXMCLEamZz4rOh4wNDcUR2l6q/Xw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4914 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220510_085900_333436_FEBDE3A6 X-CRM114-Status: GOOD ( 13.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, May 08, 2022 at 11:53:05AM -0700, Colin Foster wrote: > +static const struct mfd_cell vsc7512_devs[] = { > + { > + .name = "ocelot-pinctrl", > + .of_compatible = "mscc,ocelot-pinctrl", > + .num_resources = ARRAY_SIZE(vsc7512_pinctrl_resources), > + .resources = vsc7512_pinctrl_resources, > + }, { > + .name = "ocelot-sgpio", > + .of_compatible = "mscc,ocelot-sgpio", > + .num_resources = ARRAY_SIZE(vsc7512_sgpio_resources), > + .resources = vsc7512_sgpio_resources, > + }, { > + .name = "ocelot-miim0", > + .of_compatible = "mscc,ocelot-miim", > + .num_resources = ARRAY_SIZE(vsc7512_miim0_resources), > + .resources = vsc7512_miim0_resources, I wonder whether you can differentiate these 2 MFD cells by "use_of_reg" + "of_reg". > + }, { > + .name = "ocelot-miim1", > + .of_compatible = "mscc,ocelot-miim", > + .num_resources = ARRAY_SIZE(vsc7512_miim1_resources), > + .resources = vsc7512_miim1_resources, > + }, > +}; > + > +const struct of_device_id ocelot_spi_of_match[] = { > + { .compatible = "mscc,vsc7512_mfd_spi" }, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, ocelot_spi_of_match); Don't forget to add a struct spi_device_id table for the driver. > + > +static struct spi_driver ocelot_spi_driver = { > + .driver = { > + .name = "ocelot_mfd_spi", > + .of_match_table = of_match_ptr(ocelot_spi_of_match), > + }, > + .probe = ocelot_spi_probe, > +}; > +module_spi_driver(ocelot_spi_driver); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel