From: Qian Cai <quic_qiancai@quicinc.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: <will@kernel.org>, <mark.rutland@arm.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 0/4] perf/arm-cmn: Add CMN-650 and CMN-700
Date: Tue, 10 May 2022 15:38:15 -0400 [thread overview]
Message-ID: <20220510193815.GA302@qian> (raw)
In-Reply-To: <781f1ac8-a30c-81d9-8831-22bfbf593f58@arm.com>
On Tue, May 10, 2022 at 06:50:56PM +0100, Robin Murphy wrote:
> Hmm, can you narrow it down a bit more to a particular patch and/or a
> specific reproducer? I don't see how it could really be crashing
> dereferencing event->pmu, especially since none of the code this early in
> event_init has even changed recently :/
Right, there is an old bug that sometimes the debuginfo on kernel
modules is not accurate on arm64, so gdb and faddr2line gave the wrong
line. Anyway, using the printk() method, we were faulted on this line.
+ /* This is sufficiently annoying to recalculate, so cache it */
+ hw->filter_sel = arm_cmn_filter_sel(cmn->model, type, eventid);
Also, it can be reproduced within 5-min by running,
$ trinity -C 128 -cperf_event_open
> Something's definitely screwy here though... these ID numbers should have a
> device type above them. Was this dumped with patch #1 applied, and if not do
> they show as "????" when it is?
Yes, with the series applied, we have,
X 0 1 2 3 4 5 6 7
Y P D+--------+--------+--------+--------+--------+--------+--------+--------+
5 | XP #40 | XP #41 | XP #42 | XP #43 | XP #44 | XP #45 | XP #46 | XP #47 |
| DTC 0 | DTC 0 | DTC 0 | DTC 0 | DTC 0 | DTC 0 | DTC 0 | DTC 0 |
|........|........|........|........|........|........|........|........|
0 | CXRH | HN-I | HN-I | HN-I | HN-D | HN-I | HN-I | CXRH |
0| #2 | #3 | #4 | #5 | #0 | #6 | #7 | #3 |
1| | | | | | | | |
1 | RN-D | RN-D | RN-D | RN-I | RN-I | RN-D | RN-D | RN-D |
0| #2 | #3 | #4 | #10 | #11 | #5 | #6 | #7 |
1| | | | | | | | |
-----+--------+--------+--------+--------+--------+--------+--------+--------+
4 | XP #32 | XP #33 | XP #34 | XP #35 | XP #36 | XP #37 | XP #38 | XP #39 |
| DTC 0 | DTC 0 | DTC 0 | DTC 0 | DTC 0 | DTC 0 | DTC 0 | DTC 0 |
|........|........|........|........|........|........|........|........|
0 | SN-F | RN-F_B | RN-I | RN-F_B | RN-F_B | RN-I | RN-F_B | SN-F |
0| | | #8 | | | #9 | | |
1| | | | | | | | |
1 | ???? | RN-F_B | ???? | RN-F_B | RN-F_B | ???? | RN-F_B | ???? |
0| #24 | | #26 | | | #28 | | #30 |
1| #25 | | #27 | | | #29 | | #31 |
-----+--------+--------+--------+--------+--------+--------+--------+--------+
3 | XP #24 | XP #25 | XP #26 | XP #27 | XP #28 | XP #29 | XP #30 | XP #31 |
| DTC 0 | DTC 0 | DTC 0 | DTC 0 | DTC 0 | DTC 0 | DTC 0 | DTC 0 |
|........|........|........|........|........|........|........|........|
0 | SN-F | RN-F_B | RN-I | RN-F_B | RN-F_B | RN-I | RN-F_B | SN-F |
0| | | #6 | | | #7 | | |
1| | | | | | | | |
1 | ???? | RN-F_B | ???? | RN-F_B | RN-F_B | ???? | RN-F_B | ???? |
0| #16 | | #18 | | | #20 | | #22 |
1| #17 | | #19 | | | #21 | | #23 |
-----+--------+--------+--------+--------+--------+--------+--------+--------+
2 | XP #16 | XP #17 | XP #18 | XP #19 | XP #20 | XP #21 | XP #22 | XP #23 |
| DTC 0 | DTC 0 | DTC 0 | DTC 0 | DTC 0 | DTC 0 | DTC 0 | DTC 0 |
|........|........|........|........|........|........|........|........|
0 | SN-F | RN-F_B | RN-I | RN-F_B | RN-F_B | RN-I | RN-F_B | SN-F |
0| | | #4 | | | #5 | | |
1| | | | | | | | |
1 | ???? | RN-F_B | ???? | RN-F_B | RN-F_B | ???? | RN-F_B | ???? |
0| #8 | | #10 | | | #12 | | #14 |
1| #9 | | #11 | | | #13 | | #15 |
-----+--------+--------+--------+--------+--------+--------+--------+--------+
1 | XP #8 | XP #9 | XP #10 | XP #11 | XP #12 | XP #13 | XP #14 | XP #15 |
| DTC 0 | DTC 0 | DTC 0 | DTC 0 | DTC 0 | DTC 0 | DTC 0 | DTC 0 |
|........|........|........|........|........|........|........|........|
0 | SN-F | RN-F_B | RN-I | RN-F_B | RN-F_B | RN-I | RN-F_B | SN-F |
0| | | #2 | | | #3 | | |
1| | | | | | | | |
1 | ???? | RN-F_B | ???? | RN-F_B | RN-F_B | ???? | RN-F_B | ???? |
0| #0 | | #2 | | | #4 | | #6 |
1| #1 | | #3 | | | #5 | | #7 |
-----+--------+--------+--------+--------+--------+--------+--------+--------+
0 | XP #0 | XP #1 | XP #2 | XP #3 | XP #4 | XP #5 | XP #6 | XP #7 |
| DTC 0 | DTC 0 | DTC 0 | DTC 0 | DTC 0 | DTC 0 | DTC 0 | DTC 0 |
|........|........|........|........|........|........|........|........|
0 | CXRH | RN-F_B | RN-I | RN-F_B | RN-F_B | RN-I | RN-F_B | CXRH |
0| #0 | | #0 | | | #1 | | #1 |
1| | | | | | | | |
1 | RN-D | RN-F_B | HN-I | RN-F_B | RN-F_B | HN-I | RN-F_B | RN-D |
0| #0 | | #1 | | | #2 | | #1 |
1| | | | | | | | |
-----+--------+--------+--------+--------+--------+--------+--------+--------+
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-10 19:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 22:57 [PATCH 0/4] perf/arm-cmn: Add CMN-650 and CMN-700 Robin Murphy
2022-04-18 22:57 ` [PATCH 1/4] dt-bindings: perf: arm-cmn: " Robin Murphy
2022-04-26 20:12 ` Rob Herring
2022-04-18 22:57 ` [PATCH 2/4] perf/arm-cmn: Add CMN-650 support Robin Murphy
2022-04-19 23:05 ` Ilkka Koskinen
2022-04-19 23:47 ` Ilkka Koskinen
2022-04-20 9:26 ` Will Deacon
2022-04-20 10:12 ` Robin Murphy
2022-04-21 7:09 ` Ilkka Koskinen
2022-04-21 7:25 ` Ilkka Koskinen
2022-04-21 9:46 ` Robin Murphy
2022-04-21 21:26 ` Ilkka Koskinen
2022-04-18 22:57 ` [PATCH 3/4] perf/arm-cmn: Refactor occupancy filter selector Robin Murphy
2022-04-18 22:57 ` [PATCH 4/4] perf/arm-cmn: Add CMN-700 support Robin Murphy
2022-04-21 7:54 ` [PATCH 0/4] perf/arm-cmn: Add CMN-650 and CMN-700 Ilkka Koskinen
2022-05-06 14:43 ` Will Deacon
2022-05-10 17:15 ` Qian Cai
2022-05-10 17:50 ` Robin Murphy
2022-05-10 19:38 ` Qian Cai [this message]
2022-05-10 21:05 ` Robin Murphy
2022-05-10 20:09 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220510193815.GA302@qian \
--to=quic_qiancai@quicinc.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).