From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5367AC433EF for ; Wed, 11 May 2022 08:11:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Aqm4YYQ1Ug+Be/seJs3TDbXqq122YSaA+pbKebsAqPY=; b=RVpkk0h//JPWns edDippCLHe/Skb0Jk/aPu7deL4Yz6h5VsamqbfAmHryHDRvE5oMfsOI+8xaDM9KIFfc1H44iRJStY jn18CgM4OjGicNkwrOFoZS0QgK5RZMTCdEMc5U2PRX9IRSlfT2Ay5yXEPoiq12W5dcWfs3TERUf1s iEJYuy+oUTQbY9/NC/YgxjwxIqlJLmo86hMrDpgn6GJt2fNWIhKBgXy26gy+JhQFQT8zYlT5Q1Lca 4tLisAwZtYsMgksINPQ85p34Cs3xmF58UtJdyyGq0gGWmawSCcmb/cQi4ZVMAqOAXfc5pFDBsMYbN Xz4N9DLUOil1bHlQcsJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nohQU-005qMQ-8Y; Wed, 11 May 2022 08:10:30 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nohQQ-005qJN-C2 for linux-arm-kernel@lists.infradead.org; Wed, 11 May 2022 08:10:27 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nohQK-0000iA-UW; Wed, 11 May 2022 10:10:20 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nohQI-0004fS-D0; Wed, 11 May 2022 10:10:18 +0200 Date: Wed, 11 May 2022 10:10:18 +0200 From: Sascha Hauer To: Rob Herring Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Heiko =?iso-8859-15?Q?St=FCbner?= , Peter Geis Subject: Re: [PATCH 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2 Message-ID: <20220511081018.GL4012@pengutronix.de> References: <20220510070914.2346011-1-s.hauer@pengutronix.de> <20220510070914.2346011-2-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:05:32 up 41 days, 20:35, 73 users, load average: 0.28, 0.34, 0.27 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220511_011026_459416_F1EA6F92 X-CRM114-Status: GOOD ( 26.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 10, 2022 at 12:15:29PM -0500, Rob Herring wrote: > On Tue, May 10, 2022 at 09:09:12AM +0200, Sascha Hauer wrote: > > The VOP2 driver relies on reg-names properties, but these are not > > documented. Add the missing documentation, make reg-names mandatory > > and increase minItems to 2 as always both register spaces are needed. > > > > Signed-off-by: Sascha Hauer > > --- > > .../bindings/display/rockchip/rockchip-vop2.yaml | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > > index 655d9b327f7d3..7238cdec9eb8a 100644 > > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > > @@ -22,7 +22,7 @@ properties: > > - rockchip,rk3568-vop > > > > reg: > > - minItems: 1 > > + minItems: 2 > > You ran the dt checks, right? Well, almost... I did run dtbs_check, but I should have ran dt_binding_check. > This should give you a warning. The > correct thing is drop minItems if there's always 2 entries. Indeed this gives me a warning. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel