From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81E8AC433EF for ; Sat, 14 May 2022 21:45:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RUou1xvLsZsl5recFi++GMLga/hTNxAEKISIZ7JW16w=; b=e3Nd5YR9XeUzqk CdjdE9UURzlcYwYhiTH1JBfNTZ7NhGcBx2aeEwH7vZb+qN7LJE+pSYidNu7Q1kkgSjTtG6N65XFVh qroAAfL5bwXGM16xEGDURvRxNxljUSodnekmmT+VaTI3ILQoN5f0qFBMoT1Pq1uKICLeU3RaJh7H9 2r2KSAi3t/vZ4yx/cEQIYtLwyNEIMqYAprHZcx5qYxjHDa+yv6OPUDGTb2dNd5DjfLJc+XxKoodtE f/h2HsR/f2UjoMLbi5qi7hKiKx/ghz3m4AZ6mgZBhJIJyYXWsBGjRYC6kl64q1O61vo5cyCKEfNjO 6qGjGfZUJM3WLIh/uQlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1npzZB-002Lix-IQ; Sat, 14 May 2022 21:44:49 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1npzZ7-002LgG-Kv for linux-arm-kernel@lists.infradead.org; Sat, 14 May 2022 21:44:47 +0000 Received: by mail-pj1-x102b.google.com with SMTP id iq10so11075521pjb.0 for ; Sat, 14 May 2022 14:44:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1kwcy74YlztxWF5D6kkYQbaOPu8Yx3i8Twa6E2rtWI4=; b=heJeUZ0XTY4GUls4GZuegGii5t/VwuhS1ZpQ37mLZwfCDKDm207g1xsj8JBCk2bIrS aNjlGwo9LlONQauWo+z/yeNmUVPWAY1F26BDhdC/o/qVf3CI2gOFdgEkH/GZhaehv6/3 Dmfe/noGcr5iWvP/+oMw+4wEkUZvgRyFHIKFg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1kwcy74YlztxWF5D6kkYQbaOPu8Yx3i8Twa6E2rtWI4=; b=Wss8FbmaMAh8N9klaCe/6MnJ21Hj3YS2uq32MGbVbkX0WSK52+md7aDZV5atq/p9Fe 9rb0SrWrbNYSsYiUKI88wdNR3Wqe0YZ6nkvosNCe5z6G/gM/r5Yg7I8FIVC7O/sWSr/f ayWU5DwDeBcP8RqpvKfxmORxgicIKvs6/+dS0Q0DzekpVcML81Ghn+CwLoz8MaTUkS/P 14ABsRFNY+I/E605HWYSvV5F5X9WHcgiwUAdBPa15lhE6FQP5Zjq7K4Q1XgDk5u3yABF Z0ZCFb9LeY4tfyj7Fw5lUxFd+BhAiM7h1sJDxwRTZMFRfNT1QfyKJEdg+Ao4poDyisE8 zHoA== X-Gm-Message-State: AOAM531kC4W3Ddk7nKHjFUEkNSY/viVuM8vMMq+L8HFgKzpj0d79oDla X+KK6BNdP826TtWJyyp2jiS9+w== X-Google-Smtp-Source: ABdhPJyYU70G1FRfxpgzmsNw6UDgPZOqMteS5Gy+WK+6rpMWNA2Cp5ca2EEFT2ryVSs0JXIcUkTZhQ== X-Received: by 2002:a17:902:e746:b0:15e:b4f3:72e7 with SMTP id p6-20020a170902e74600b0015eb4f372e7mr10953716plf.8.1652564684488; Sat, 14 May 2022 14:44:44 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id x12-20020a170902a38c00b0015e8d4eb1d2sm4121582pla.28.2022.05.14.14.44.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 May 2022 14:44:44 -0700 (PDT) Date: Sat, 14 May 2022 14:44:43 -0700 From: Kees Cook To: Sami Tolvanen Cc: linux-kernel@vger.kernel.org, Josh Poimboeuf , Peter Zijlstra , x86@kernel.org, Catalin Marinas , Will Deacon , Mark Rutland , Nathan Chancellor , Nick Desaulniers , Joao Moreira , Sedat Dilek , Steven Rostedt , linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Subject: Re: [RFC PATCH v2 05/21] cfi: Drop __CFI_ADDRESSABLE Message-ID: <202205141444.0C1A3ABD1@keescook> References: <20220513202159.1550547-1-samitolvanen@google.com> <20220513202159.1550547-6-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220513202159.1550547-6-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220514_144445_719909_BCB5C55E X-CRM114-Status: GOOD ( 12.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 13, 2022 at 01:21:43PM -0700, Sami Tolvanen wrote: > The __CFI_ADDRESSABLE macro is used for init_module and cleanup_module > to ensure we have the address of the CFI jump table, and with > CONFIG_X86_KERNEL_IBT to ensure LTO won't optimize away the symbols. > As __CFI_ADDRESSABLE is no longer necessary with -fsanitize=kcfi, add > a more flexible version of the __ADDRESSABLE macro and always ensure > these symbols won't be dropped. > > Signed-off-by: Sami Tolvanen These macros were so fun to build, though! ;) Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel