From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86D2DC433EF for ; Sat, 14 May 2022 21:51:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AkD1Qs4SeCkWazBLTZQ5QkWVx51dsUu+ePF8QHIHUvU=; b=GZFVySsPuPvtnU ClZUr+TdeprhM4SAI4Fepi4Erln6kb2uIM5midExrTDl8T6fUCq82/rPs5n1faJRULR++QDk3aNLd iv8oR3V73IsIsqwHSOYH2z+rovthXz1HnGoXC5+o3j13/4J/cFCZx98pAR1Odh/kIDcfoS7SaJ64k uK7MyCaTDR16aNCrjY+lAh3YS2WtqeErVHqDCqPPNBxBW0MAlaXfx9ZANVO43jY2TzYxL2KEPfl83 uLuXHaAAPXO7Ah3AiDjsH4CbDziUugXIlHI3M8eLAdtRW04Kb/vhAyKPzMJUQucHrPdhoFAaN9mFP r+2UsO6ZYpNJC+xMZS5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1npzeN-002N7e-2d; Sat, 14 May 2022 21:50:11 +0000 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1npzeI-002N65-VN for linux-arm-kernel@lists.infradead.org; Sat, 14 May 2022 21:50:08 +0000 Received: by mail-pl1-x631.google.com with SMTP id m12so11115358plb.4 for ; Sat, 14 May 2022 14:50:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wUsCnBDPbKVJv+EaQK22IFJZJAmFRuI1WgmUtyrig2Y=; b=nA8vOrKYtkCzRykOxnyfADoil/vhGzEfF70wnCDaNvJJi5xuvhhAkbtAFjQwLeFpJS 1jap5Med/qc57M9VzJiXmB/EA4QArrQBeeuX93F+CfTCQiapplPgFCGvqmsenet4C1Fo u8B84Aa7txzzssJbvS8cZtMj8GyAW5qEFMceU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wUsCnBDPbKVJv+EaQK22IFJZJAmFRuI1WgmUtyrig2Y=; b=EuO6gkyyvGzmSoET+iWnOk4i2hkmnHCvWax8DwgBdmrJPHvKc1wqO1JtF2s8MIEGdz xJjaFEwyZVcp/WiI6ExyQVjqH3ZmV1syS2EXoMRPqKCaytjxxFCYeMNUdpnPYjl2Fev+ tnlC9ufWfVqA+qRwRgfWRGfE9eMzlDXEk2KZah5VT6tS0u8GPF7zWggEAG2wM/e3Yh3b 880QPy3CV/3hxW6Z+fuYObOhB2rIAknchJqtPKhCb94WMr1BxJ+8NKGsbt+U5v4UKnQb 3uG/bk8QYpumQY9dEn0TKeJFrcZsXHgbvBqTtB4d6WfKAaTEyOA6xLtpiJFmuDTtbbx2 HPzA== X-Gm-Message-State: AOAM531qbg5btPC8yHYv93KMjbfpnqUDBWj/z1KIpcsxZGzMMWe48jeZ ZglNpXCEy98BFKfWyyJk0G9T7A== X-Google-Smtp-Source: ABdhPJw2E4A+XrCLXCnm95DuJx6yjrgtSzMtn/EEPgJ80ptCzVUybF5Z7bgAS+rJxfbXjJ5+NcMoMw== X-Received: by 2002:a17:90b:3d90:b0:1df:70c:c65f with SMTP id pq16-20020a17090b3d9000b001df070cc65fmr5818574pjb.238.1652565005959; Sat, 14 May 2022 14:50:05 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id j2-20020a056a00234200b0050dc76281a3sm4037702pfj.125.2022.05.14.14.50.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 May 2022 14:50:05 -0700 (PDT) Date: Sat, 14 May 2022 14:50:05 -0700 From: Kees Cook To: Sami Tolvanen Cc: linux-kernel@vger.kernel.org, Josh Poimboeuf , Peter Zijlstra , x86@kernel.org, Catalin Marinas , Will Deacon , Mark Rutland , Nathan Chancellor , Nick Desaulniers , Joao Moreira , Sedat Dilek , Steven Rostedt , linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Subject: Re: [RFC PATCH v2 08/21] psci: Fix the function type for psci_initcall_t Message-ID: <202205141449.87738FDF@keescook> References: <20220513202159.1550547-1-samitolvanen@google.com> <20220513202159.1550547-9-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220513202159.1550547-9-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220514_145007_053613_748B886E X-CRM114-Status: GOOD ( 10.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 13, 2022 at 01:21:46PM -0700, Sami Tolvanen wrote: > Functions called through a psci_initcall_t pointer all have > non-const arguments. Fix the type definition to avoid tripping > indirect call checks with CFI_CLANG. > > Reported-by: Mark Rutland > Signed-off-by: Sami Tolvanen This could land separately from this series, too, yes? Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel