From: Jonathan Cameron <jic23@kernel.org>
To: Michal Simek <michal.simek@xilinx.com>
Cc: <cgel.zte@gmail.com>, <lars@metafoo.de>,
<anand.ashok.dumbre@xilinx.com>, <manish.narani@xilinx.com>,
<linux-iio@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, Lv Ruyi <lv.ruyi@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] iio: adc: fix return error variable
Date: Sat, 14 May 2022 14:49:44 +0100 [thread overview]
Message-ID: <20220514144944.21709427@jic23-huawei> (raw)
In-Reply-To: <c19cce8d-ca99-4993-435d-1a4e53543713@xilinx.com>
On Mon, 9 May 2022 09:34:57 +0200
Michal Simek <michal.simek@xilinx.com> wrote:
> On 5/9/22 09:24, cgel.zte@gmail.com wrote:
> > From: Lv Ruyi <lv.ruyi@zte.com.cn>
Applied, with modified patch title. There are a lot of ADC drivers
so you should include the name of the driver in the patch description.
iio: adc: xilinx-ams: fix return error variable
> >
> > Return irq instead of ret which always equals to zero here.
> >
> > Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver")
> > Reported-by: Zeal Robot <zealci@zte.com.cn>
> > Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> > ---
> > drivers/iio/adc/xilinx-ams.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c
> > index a55396c1f8b2..a7687706012d 100644
> > --- a/drivers/iio/adc/xilinx-ams.c
> > +++ b/drivers/iio/adc/xilinx-ams.c
> > @@ -1409,7 +1409,7 @@ static int ams_probe(struct platform_device *pdev)
> >
> > irq = platform_get_irq(pdev, 0);
> > if (irq < 0)
> > - return ret;
> > + return irq;
> >
> > ret = devm_request_irq(&pdev->dev, irq, &ams_irq, 0, "ams-irq",
> > indio_dev);
>
> Reviewed-by: Michal Simek <michal.simek@amd.com>
>
> Thanks,
> Michal
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-05-14 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 7:24 [PATCH] iio: adc: fix return error variable cgel.zte
2022-05-09 7:34 ` Michal Simek
2022-05-14 13:49 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220514144944.21709427@jic23-huawei \
--to=jic23@kernel.org \
--cc=anand.ashok.dumbre@xilinx.com \
--cc=cgel.zte@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.ruyi@zte.com.cn \
--cc=manish.narani@xilinx.com \
--cc=michal.simek@xilinx.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox