From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DFE1C433EF for ; Sat, 14 May 2022 21:52:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AyxYqIyIMAYKH5Y8Wc/itrBhosTcRgy5zqSo0wRp8Cg=; b=QzTMPGfgAfy22M 3uRnQl+71x5TPKax8Rly/sq0fg8Z53kO6z02zfNieMuCdEfx52Gw2kV9gSdpbDmBu7AU320zzVD10 axcUaf2QaC2zRhNxHoiK/tagfJDFBYWZkrNuXKswnsS0obCXGtHorCDikbf0chR769loW9JGaGzrz 0b2qy6CdavfO7mu5v/5m+yDRrYOJ/UxWRrqkzLrNW6uzoBgnsnSEt8xlkoLUmAFyj0YHyjPEk/trh w4k0RuR3ntd1QzYaiP/S1fsVgDRrRnW/0noZWYX6BgJJg6P1ibnRxD3N3XBuSmG/yOmrmeRfVHhSP A5yX8zX3PR85r5nl3x1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1npzg1-002NhR-DG; Sat, 14 May 2022 21:51:53 +0000 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1npzfx-002Nfh-Nr for linux-arm-kernel@lists.infradead.org; Sat, 14 May 2022 21:51:51 +0000 Received: by mail-pf1-x435.google.com with SMTP id d25so10720648pfo.10 for ; Sat, 14 May 2022 14:51:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=KJbcM6BaGnVsc+lH7+1M1k2jbZydRk22NNewGkDa1NU=; b=e4BoHA9WL9qeZc71RDo+gwHI/WVGlF9ihGMZvl3GjCTnYqbpdgT6ARC97V0Sx005vk CVBefGzFOPkHSpdQU0IONguMIhpytTi32o8F4sAZ9Hu6oN0VZfc4WwF5S47maDqlHjGa 9VthZjOMjNu86ZiHEs9AjxoajYC5HNqWD/Eqc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KJbcM6BaGnVsc+lH7+1M1k2jbZydRk22NNewGkDa1NU=; b=D5JuUqDJgd3K5wEYi0GzqoJ99lCpZIz9AxHmmKAN5iLAlPBkc1EmodNwIqD3d23zIA IZXLRf+TrLhrDJYFKEKKkmK8UyR+5KbbZPL0Jjh54iSicFIPI2zh6lzq1ebbh3aeECN5 F+RTAASAy12sZ8GrahhT1pw5caRGu8Pwaiofu94GA/ZWjTRx6cNwKfWf1/fOFSvndqkj QyG4k2f7r9Bvku3WMALEEGlHi5Pydpfi4I6LuANCzm20LhycIBEtZ6GWyn0qcGrW+oBu 0qxIbhThRukFN/o7qk9gfZEWuJh2a5L4GgVJIC46knwajoph3jUu2M88Am8ZH81fwSzI xq6A== X-Gm-Message-State: AOAM531KjO592VUgmb/dFU4mviJp7vxwI1zVUya2VRxZbevVoKMaV3X0 hT2PqFEia+ve5lsdMZqwY6y/Lw== X-Google-Smtp-Source: ABdhPJzVcwxnf5BHi4PD4v22PQexaSGjmN/U7xVBOR3pb4vN2IMRcgUsw+BYxfv+bMDVujgoNZB/uw== X-Received: by 2002:a63:f0a:0:b0:3c6:e825:2431 with SMTP id e10-20020a630f0a000000b003c6e8252431mr9189653pgl.166.1652565108504; Sat, 14 May 2022 14:51:48 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id s13-20020a17090302cd00b0015e8d4eb244sm4117847plk.142.2022.05.14.14.51.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 May 2022 14:51:48 -0700 (PDT) Date: Sat, 14 May 2022 14:51:47 -0700 From: Kees Cook To: Sami Tolvanen Cc: linux-kernel@vger.kernel.org, Josh Poimboeuf , Peter Zijlstra , x86@kernel.org, Catalin Marinas , Will Deacon , Mark Rutland , Nathan Chancellor , Nick Desaulniers , Joao Moreira , Sedat Dilek , Steven Rostedt , linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Subject: Re: [RFC PATCH v2 10/21] arm64: Add CFI error handling Message-ID: <202205141451.AABEE8B@keescook> References: <20220513202159.1550547-1-samitolvanen@google.com> <20220513202159.1550547-11-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220513202159.1550547-11-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220514_145149_816384_D9AC4C61 X-CRM114-Status: GOOD ( 12.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 13, 2022 at 01:21:48PM -0700, Sami Tolvanen wrote: > With -fsanitize=kcfi, CFI always traps. Add arm64 support for handling > CFI failures. The registers containing the target address and the > expected type are encoded in the first ten bits of the ESR as follows: > > - 0-4: n, where the register Xn contains the target address > - 5-9: m, where the register Wm contains the type hash > > Suggested-by: Mark Rutland > Signed-off-by: Sami Tolvanen It might be nice just to include an example exception Oops in this commit log. Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel