From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E81A1C433EF for ; Sat, 14 May 2022 21:55:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LvLBO//7muOC8RYrF8cI1/gsrGf54eA4TFfn4bnreXk=; b=Mm+wle+Y73OMr+ HT6y0GeHlBE3DqhEb1qc5cYTBMBTkDWpV88Kx+JebUPWOFyvkn/i6/3vqu0go+XhiANrxpLS+mcde hpau4qMtnQC/lZOpyYmzaPkQESxo0EHAwOJ9jBhb84PADDbZcaUm3ZANqgq9osJNP6n5fyPYgshXT hqS+25JLETS4oy3im2MFZ5UzK6hqx8Q9FH+Myt9HCtJ7THpWo7UTw1s3iDFUlJnTZWIEMJRRb2Ud8 fWjp1ootu8a8UPw6DCO79Ri5zIp+DhLu4JCymHp54R+xaFnLyOdVzZ6A+RuA245YtaJ4a3RahDns8 QD7uB3nfpkznl5nZM30g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1npziu-002OYx-Dv; Sat, 14 May 2022 21:54:52 +0000 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1npziq-002OWy-FJ for linux-arm-kernel@lists.infradead.org; Sat, 14 May 2022 21:54:49 +0000 Received: by mail-pf1-x429.google.com with SMTP id i24so10735151pfa.7 for ; Sat, 14 May 2022 14:54:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=t2yObVrbf/L9Jq6+JbbAXZHKIfGO1DeBECBvtcKWJrQ=; b=a2vCFtT3tXCJFlaBwLlox/cAPNUXQljxjpojw0pEncSqcq0/+C10zLDNqQyY4H4MZd kD7/dRMNsR6kSF64Nx5WKF94/fOyf5uHx7flzonMY2TVUorztqn2oJepkCTboXILUDhF ufEifGfG/qIMCjWxrANBavsxx++WXTI1Q3Clc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=t2yObVrbf/L9Jq6+JbbAXZHKIfGO1DeBECBvtcKWJrQ=; b=69G291q4kJcz/+Tcu5WoQ/1fM/nr5L/Dcf8vzTuzK+iM5NeWyENMCYF8cMREXCvTLA wQdqBPcPQ25KyQa2KrrfrtA7zO4AZ81Dpwfp9rB0VTlXca2JCZPtmoeYnHE+ikxv7rp8 kkyOoIwifcoZ9LWkVFIfzi2OP95b6p0vFnvIpNYCS7TaNSj/7GmJOF89i4p3XNEGhng3 N9BY4ye2ma7bGRSvjqkkQgnos4UCJAAWuEEhgnt6GSjeC8fuovJvmMXkvmNp34Af8I4X BQXrT3lzDwhqJEMOiST20TDFTpzUkB0GKRRfxwENSX3X3/iOa7J2r2FNNL1n+6OieDaf 0yjw== X-Gm-Message-State: AOAM533FIILZWL+Ea7pm+8tihbt2fNKl2LQ2vpgfjB0AJJvNlvwWEwus z1yuSKw2IA2x9UYAHjoA49Wofg== X-Google-Smtp-Source: ABdhPJzEbT+xSq2G7nTj/6I7DpbTkFKAAE5DIrDPZRYeOTIN7iK2Q3o6lSrZl7RpCs6ZWKyW4Fzjtg== X-Received: by 2002:a63:381e:0:b0:3c6:d5e4:fed9 with SMTP id f30-20020a63381e000000b003c6d5e4fed9mr9243439pga.553.1652565287615; Sat, 14 May 2022 14:54:47 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id u23-20020a1709026e1700b0015e8d4eb1ffsm4184143plk.73.2022.05.14.14.54.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 May 2022 14:54:47 -0700 (PDT) Date: Sat, 14 May 2022 14:54:46 -0700 From: Kees Cook To: Sami Tolvanen Cc: linux-kernel@vger.kernel.org, Josh Poimboeuf , Peter Zijlstra , x86@kernel.org, Catalin Marinas , Will Deacon , Mark Rutland , Nathan Chancellor , Nick Desaulniers , Joao Moreira , Sedat Dilek , Steven Rostedt , linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Subject: Re: [RFC PATCH v2 13/21] treewide: Drop WARN_ON_FUNCTION_MISMATCH Message-ID: <202205141454.12B573ABC@keescook> References: <20220513202159.1550547-1-samitolvanen@google.com> <20220513202159.1550547-14-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220513202159.1550547-14-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220514_145448_567642_6901178D X-CRM114-Status: GOOD ( 10.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 13, 2022 at 01:21:51PM -0700, Sami Tolvanen wrote: > CONFIG_CFI_CLANG no longer breaks cross-module function address > equality, which makes WARN_ON_FUNCTION_MISMATCH unnecessary. Remove > the definition and switch back to WARN_ON_ONCE. > > Signed-off-by: Sami Tolvanen This one always felt like a trade-off, so I'm happy to see it go. :) Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel