From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 344F5C433EF for ; Sat, 14 May 2022 21:57:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h40YB1CMjgbEtHdKylxJKrsbYQW5Euapx0+JxbhPh4o=; b=pErrud1jKhVj97 t6e7b7NNzEHDnZ8Kfz+jUhKenBitNB2OHoRGlqIYOnQ9yLPjghJVDuFQRdGJs4rihKLK/paF+nIPA tUk1VHnDcfgDbaePiE+MoZWkkZXegTwpypnnoWaC8VO+e9xHbcSxG/hTJ75idMOEo596AnudIFdMg f8cmG2SfR63wBfWW8aEptmvzWFEkHySWxu+DDugYnoG7kLr6epW+ClGsw1sNnrZctjvIiNxnMG6xZ wU2NRQhqS3B+QlwRWN3W+Ai/mnHYgVxNi8RSlZDr4Ati0R5CN9LweTZHGQyY58bEnsJ1jdPQ4svl7 33KGIkITBPtsm+S1XEHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1npzk8-002P4U-Q3; Sat, 14 May 2022 21:56:08 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1npzk4-002P2w-VD for linux-arm-kernel@lists.infradead.org; Sat, 14 May 2022 21:56:06 +0000 Received: by mail-pj1-x1030.google.com with SMTP id b12so1730009pju.3 for ; Sat, 14 May 2022 14:56:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FRz+GXXZaKOMrKydUY42JkbUz0KXbswZCunobIsh+ok=; b=EMGxS7CubkSoRXJvbmCOUMnABXzcITd5+nEUdRyvBWZr0Ejfu0faLMdmwYhOM8pXx4 qOvD2ibBSHZJuEbw1khfAuvievTdhMLKWyGiMShRtK8Ll3XYbrif7r38L2UQePBNmqGc wDzdnSTxfK8uDgCLXMc/+iLNVxeUASGOOeNys= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FRz+GXXZaKOMrKydUY42JkbUz0KXbswZCunobIsh+ok=; b=sbKRyL4naUsIAvqSHwDjVJN44C34XnOQ/X98vgD4Z7sZEHm3LS5E45E/XLEFb35Whh ZROstBdGS4rLdETLyZqKvhPXo5mooiFEhJG/d6isdeOAsG41JuuTWpvV/c0DjYzg8+jF 1t2CJEs55vvYX90i2vSp+vEEt86PeZTn6XxFE0ScGQunrD6VkHtLVQHyMOBaclwx3q1n NfnMZqszRFpYPNi9+1pVV9jf+Bi3c4lUCEFUybHTFMBIAx450T8QM8mGsZUVhttgqK06 JgXfmAUCMskx5R6XwixMfJYVZI1DbNTjQHKTwe7llWeu9eyyXHFby85I571VM+d/y5fd 5abA== X-Gm-Message-State: AOAM533WbZjDCm7qZOXbxRasiYIoCYKYCChiFWHPP04AuuCEQwXgeli6 Kft+FGNdIihJVF53clU7Khx4DQ== X-Google-Smtp-Source: ABdhPJwN6qwi59HdCtNsN1hdnIt3qawy44T1UkLBIVUFePlqWn8+tMNJ68vLHuPdKrk2BA5cYKH36g== X-Received: by 2002:a17:90b:3510:b0:1dc:88d2:6a1b with SMTP id ls16-20020a17090b351000b001dc88d26a1bmr23153588pjb.158.1652565363278; Sat, 14 May 2022 14:56:03 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id v9-20020a170902b7c900b0016162e01553sm495864plz.168.2022.05.14.14.56.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 May 2022 14:56:03 -0700 (PDT) Date: Sat, 14 May 2022 14:56:02 -0700 From: Kees Cook To: Sami Tolvanen Cc: linux-kernel@vger.kernel.org, Josh Poimboeuf , Peter Zijlstra , x86@kernel.org, Catalin Marinas , Will Deacon , Mark Rutland , Nathan Chancellor , Nick Desaulniers , Joao Moreira , Sedat Dilek , Steven Rostedt , linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Subject: Re: [RFC PATCH v2 14/21] treewide: Drop __cficanonical Message-ID: <202205141455.0A6F409@keescook> References: <20220513202159.1550547-1-samitolvanen@google.com> <20220513202159.1550547-15-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220513202159.1550547-15-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220514_145605_032116_F2673FA4 X-CRM114-Status: GOOD ( 14.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 13, 2022 at 01:21:52PM -0700, Sami Tolvanen wrote: > CONFIG_CFI_CLANG doesn't use a jump table anymore and therefore, > won't change function references to point elsewhere. Remove the > __cficanonical attribute and all uses of it. > > Signed-off-by: Sami Tolvanen > --- > include/linux/compiler_types.h | 4 ---- > include/linux/init.h | 4 ++-- > include/linux/pci.h | 4 ++-- > 3 files changed, 4 insertions(+), 8 deletions(-) I think this is missing removing it from include/linux/compiler-clang.h ? With that done (or explained why not): Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel