Re: [PATCH net-next v2 1/5] net: ipqess: introduce the Qualcomm IPQESS driver

Russell King (Oracle)
2022-05-14T17:21:51Z

On Sat, May 14, 2022 at 05:06:52PM +0200, Maxime Chevallier wrote:
> +static int ipqess_do_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd)
> +{
> + struct ipqess *ess = netdev_priv(netdev);
> +
> + switch (cmd) {
> + case SIOCGMIIPHY:
> + case SIOCGMIIREG:
> + case SIOCSMIIREG:
> + return phylink_mii_ioctl(ess->phylink, ifr, cmd);
> + default:
> + break;
> + }
> +
> + return -EOPNOTSUPP;
> +}

Is there a reason this isn't just:

return phylink_mii_ioctl(ess->phylink, ifr, cmd);

?

> +static int ipqess_axi_probe(struct platform_device *pdev)
> +{
> + struct device_node *np = pdev->dev.of_node;
> + struct net_device *netdev;
> + phy_interface_t phy_mode;
> + struct resource *res;
> + struct ipqess *ess;
> + int i, err = 0;
> +
> + netdev = devm_alloc_etherdev_mqs(&pdev->dev, sizeof(struct ipqess),
> + IPQESS_NETDEV_QUEUES,
> + IPQESS_NETDEV_QUEUES);
> + if (!netdev)
> + return -ENOMEM;
> +
> + ess = netdev_priv(netdev);
> + ess->netdev = netdev;
> + ess->pdev = pdev;
> + spin_lock_init(&ess->stats_lock);
> + SET_NETDEV_DEV(netdev, &pdev->dev);
> + platform_set_drvdata(pdev, netdev);
> +
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + ess->hw_addr = devm_ioremap_resource(&pdev->dev, res);
> + if (IS_ERR(ess->hw_addr))
> + return PTR_ERR(ess->hw_addr);
> +
> + err = of_get_phy_mode(np, &phy_mode);
> + if (err) {
> + dev_err(&pdev->dev, "incorrect phy-mode\n");
> + return err;
> + }
> +
> + ess->ess_clk = devm_clk_get(&pdev->dev, "ess");
> + if (!IS_ERR(ess->ess_clk))
> + clk_prepare_enable(ess->ess_clk);
> +
> + ess->ess_rst = devm_reset_control_get(&pdev->dev, "ess");
> + if (IS_ERR(ess->ess_rst))
> + goto err_clk;
> +
> + ipqess_reset(ess);
> +
> + ess->phylink_config.dev = &netdev->dev;
> + ess->phylink_config.type = PHYLINK_NETDEV;
> +
> + __set_bit(PHY_INTERFACE_MODE_INTERNAL,
> + ess->phylink_config.supported_interfaces);

No mac capabilities?

> +
> + ess->phylink = phylink_create(&ess->phylink_config,
> + of_fwnode_handle(np), phy_mode,
> + &ipqess_phylink_mac_ops);

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!