From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7AE8C433EF for ; Mon, 16 May 2022 07:54:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nvpzqc8p+37CyDySVz0Z2RmIHTqKuLsRejs0fpzQu7Q=; b=ncb6BSvmUICe3J 3BJcT5ytb+/9FFXmOgkd0ifEoW3Ga4dkXc1eYltYwpN6eZLPXmH1Ow9Dfu6c5KtUYuA65iwx7KRHn 2WXQyJqcU7rFUQvq2Jd6OQdtTePp/oqpEhamyXKDCPtUQfe+MYKnIamZNShTRgR8UHEgPc8ih3fI/ /WjNDhfsB3ZfdZyjNcc0E9KnLRCc2T0sUz9JkVeeZLtMlCwMYDK+IfRxQnQSFZQd8nABbtKSpKQ8f bKooZywGVCg6zNVT/ix/Q/GyUG9xbxTPZswTWYgcP4xl0PJyxad1Evftd7FKuxgOu4TGoDHrSJtwz JMFPUsWEU+suAo4PgSXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqVXw-006YUX-Af; Mon, 16 May 2022 07:53:40 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqVXt-006YR5-9x for linux-arm-kernel@lists.infradead.org; Mon, 16 May 2022 07:53:38 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id B95C63200977; Mon, 16 May 2022 03:53:30 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 16 May 2022 03:53:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1652687610; x= 1652774010; bh=3pNP4lkw2arx3DEO7xosFHza4XodA+DQ9cP0mdORw0E=; b=C BY8RdDlTi9S5yAqghIBhAvsJ9Z9JFnZ15BnqDgi3fXaCsVVE8zAQcrPqYSEqVPUr McRqjpR3HMHvzfmYwlaV9knOFEi6n3unw/xN7cvKOiUoOTfpoSV8162qLqMiPm6b vJ9QzlSpUWdWVoMZmA8oyRJ7xDlyw3RnZ27ZasILubYkkmImgdk7FPymC1kWHQdS 0x3+CcekhI3VnxEg0rwC+ug9oqPfjLmaleCiVEVGu+h3I4SyoHgsFZ2UyQhB1jM+ Lwh5bpToWDOfni9t8XYnRGWJjIWP8Pkace6LWg54c+L+VeE3tkXnukdjAdFyi3CQ GnadUJeA6VRBemwOvknOg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1652687610; x=1652774010; bh=3pNP4lkw2arx3 DEO7xosFHza4XodA+DQ9cP0mdORw0E=; b=AoVri4LT+R1c9JiAgs8nFEvz2EMnz pW3sOudgVIzUPEDYAIVj3ak1WInoKUHfjp9QcvNsGV4ozJSPpkEMRFm/PeC9pR8C cqICI/Y9H+LCo/Ev0wY1XQfEhYApEkScBGYoW3nI75gSCS2lxu3r8jYuCZDx7EFy iP4GSNxaiPFj81RAfCgwx2szlCRjMQ+hU7q0QtbWOCIcRLTd93Mf9RiylFvQAC2o uUK9rolMTv1rBJT7JyYKpmWyYFpzxTmHWC3E8w6Z8Xi7omhWssNmq7NyEnuujKgZ DuZ28CKPS81mghPMpc0nBXHFiAdR5/7l1Dw2jmbDn6IC9AIK/y0Imsqgg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrheeggdduvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggugfgjsehtqhertddttddvnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnheptefgleeggfegkeekgffgleduieduffejffegveevkeejudektdduueet feetfefgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 16 May 2022 03:53:28 -0400 (EDT) Date: Mon, 16 May 2022 09:53:26 +0200 From: Maxime Ripard To: qianfan Cc: linux-sunxi@lists.linux.dev, Rob Herring , Chen-Yu Tsai , Jernej Skrabec , "Rafael J . Wysocki" , Viresh Kumar , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v3 2/2] ARM: dts: sun8i-r40: Add "cpu-supply" node for sun8i-r40 based board Message-ID: <20220516075326.hccburhu743t7p6r@houat> References: <20220512071858.10805-1-qianfanguijin@163.com> <20220512071858.10805-2-qianfanguijin@163.com> <20220513073849.cu4jzykefat2sepg@houat> <1352b9d7-5219-af09-948b-6462def39ea5@163.com> <20220513081556.knd3tf6pangfblh3@houat> <666ead08-af1e-81f5-6fe1-e5e3370e6d6f@163.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <666ead08-af1e-81f5-6fe1-e5e3370e6d6f@163.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220516_005337_546908_2BAB6068 X-CRM114-Status: GOOD ( 25.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 13, 2022 at 04:23:20PM +0800, qianfan wrote: > > > > There's a similar issue for all the boards that don't have a regulator > > > > in the first place. > > > > > > > > The way we worked around this for the other SoCs is to have a DTSI with > > > > the OPPs with a frequency higher than what U-Boot boots with (1008MHz?), > > > > and only include that DTSI on boards that have a CPU regulator hooked in. > > > Is this really necessary? It seems like every board based on sun8i-r40 > > > have a cpu regulator. > > This probably won't be the case whenever someone starts a new design, > > and then they'll face random crashes for no apparent reason, and waste a > > lot of time in the process. > > > > Whereas the alternative is that you would be missing some OPPs, > > something that is fairly easy to figure out. > > How about remove the OPPs which greate that 1.08G in sun8i-r40.dtsi, > If some boards want to run at a higher frequency, can add them byself > in the board's file. You did all the work to support and test them already. It's a bit of a waste to do that and not include it. Just do a DTSI like we did for the A64 for example. Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel