From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD94CC433EF for ; Tue, 17 May 2022 07:15:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cUdKL7eXeU/Ss0N7ruFe7koJu3yxISSBBaxI0IG1v0E=; b=z6CfWlx7mIHM6O dKZwb01gBxkrxBGl69jet1aKT1/phSSQirOftt0BkSnfqbQEbV8y1nUDxjWFPa2YSpFtCHIVVn/4L iKJipedWHU6A4/p8ZhBvBhxQ157/gVgviulGABAgIfthAIcGYthn3RiIOKwBqRQgAX/Qqqy9qCdqq SxO70iDQiwT/fbU2nVGzXcJWwpegOYrZhCdCv57+3FQR06wdu7Gmji3PnT/9EaXb0y4JISLPErNYv 6t+5bWW+1nqA9zcXcy+u04L7H9iNHO7t/MmJ21pauzxocZt8zLQiYyXvE4l7vDOQrShYuPVj6it2P 5rvwD55FKu0LDBtYY+tA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqrPu-00C3gp-3I; Tue, 17 May 2022 07:14:50 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqrPn-00C3f7-IT for linux-arm-kernel@lists.infradead.org; Tue, 17 May 2022 07:14:45 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3669FB81736; Tue, 17 May 2022 07:14:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DAC76C385B8; Tue, 17 May 2022 07:14:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652771680; bh=KHDlTZzn0+DsUMIZOmXkXySbntEfsxVaMQGokybuLVA=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=jsl0zGaqmFmNIruk70W1rsKoK+cK4R+HKlwCdhj9lyx3TBLSjIjgTcK/XA1mj2fWg XrVbPhm8jVdoPgb9nHE/2Faz/zScwZc9AECuJkiA+NKyL2XGKxw+QkrYd2Uxmj/Twg le36wfpRTVX7QJkBfItoGb8nOU4uVfDVY1YoPvXwkbG7IDDOSHlL/4MKe+i7/jrGRW 9O/FyInAO5LC8ddeOVRTWMTGRSXwQyHKT6vGbLzcUtCB3hW8rxAZjYih7talVfxBBG XWJvIbATtwxHeIyLoWp6Ivi46svALr4FnWkfnIrrt3gfqozCRWDMn8MkRERHqmCurZ 0y199aqM3QSSQ== MIME-Version: 1.0 In-Reply-To: References: <20220413071318.244912-1-codrin.ciubotariu@microchip.com> <20220422011216.A4A23C385A5@smtp.kernel.org> Subject: Re: [PATCH] clk: at91: generated: consider range when calculating best rate From: Stephen Boyd To: Codrin.Ciubotariu@microchip.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 17 May 2022 00:14:38 -0700 User-Agent: alot/0.10 Message-Id: <20220517071440.DAC76C385B8@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220517_001443_811734_F22EC3C8 X-CRM114-Status: GOOD ( 15.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mturquette@baylibre.com, alexandre.belloni@bootlin.com, Claudiu.Beznea@microchip.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Codrin.Ciubotariu@microchip.com (2022-04-26 00:24:15) > On 22.04.2022 04:12, Stephen Boyd wrote: > > Quoting Codrin Ciubotariu (2022-04-13 00:13:18) > >> clk_generated_best_diff() helps in finding the parent and the divisor to > >> compute a rate closest to the required one. However, it doesn't take into > >> account the request's range for the new rate. Make sure the new rate > >> is within the required range. > >> > >> Fixes: 8a8f4bf0c480 ("clk: at91: clk-generated: create function to find best_diff") > >> Signed-off-by: Codrin Ciubotariu > >> --- > > > > Is this fixing anything real or it's just a thing that you noticed and > > sent a patch to fix? > > It fixes the clk_set_min/max_rate() calls to a generated clock. Do you > want me to add this fact in the commit description? > I wanted to know if there are clk_set_min/max_rate() calls on this clk. Are there? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel