linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	Nicolas Saenz Julienne <nsaenz@kernel.org>,
	Lee Jones <lee.jones@linaro.org>,
	Peter Robinson <pbrobinson@gmail.com>,
	Melissa Wen <melissa.srw@gmail.com>,
	Phil Elwell <phil@raspberrypi.com>,
	bcm-kernel-feedback-list@broadcom.com,
	Maxime Ripard <maxime@cerno.tech>,
	devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 03/11] dt-bindings: soc: bcm: bcm2835-pm: Add support for bcm2711
Date: Tue, 17 May 2022 19:55:35 -0500	[thread overview]
Message-ID: <20220518005535.GA1974187-robh@kernel.org> (raw)
In-Reply-To: <20220515202032.3046-4-stefan.wahren@i2se.com>

On Sun, May 15, 2022 at 10:20:24PM +0200, Stefan Wahren wrote:
> Add a new compatible string for BCM2711 and the option to provide a
> third reg property for the board's new RPiVid ASB.
> 
> In BCM2711 the new RPiVid ASB took over V3D, which is our only consumer
> of this driver so far. The old ASB is still be present with ISP and H264
> bits but no V3D.
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
>  .../bindings/soc/bcm/brcm,bcm2835-pm.yaml     | 19 +++++++++++++------
>  1 file changed, 13 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml
> index 883ab7cb96e9..e13ce98d1753 100644
> --- a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml
> +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml
> @@ -19,17 +19,24 @@ allOf:
>  properties:
>    compatible:
>      items:
> -      - const: brcm,bcm2835-pm
> +      - enum:
> +          - brcm,bcm2835-pm
> +          - brcm,bcm2711-pm
>        - const: brcm,bcm2835-pm-wdt
>  
>    reg:
> -    minItems: 2
> -    maxItems: 2
> +    minItems: 1
> +    maxItems: 3
>  
>    reg-names:
> -    items:
> -      - const: pm
> -      - const: asb
> +    oneOf:
> +      - items:
> +          - const: pm
> +          - const: asb
> +      - items:
> +          - const: pm
> +          - const: asb
> +          - const: rpivid_asb

This can be simplified to:

minItems: 2
items:
  - const: pm
  - const: asb
  - const: rpivid_asb

>  
>    "#power-domain-cells":
>      const: 1
> -- 
> 2.25.1
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-05-18  0:56 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-15 20:20 [PATCH 00/11] soc: bcm2835-power: Prepare BCM2711 V3D support Stefan Wahren
2022-05-15 20:20 ` [PATCH 01/11] dt-bindings: soc: bcm: bcm2835-pm: Convert bindings to DT schema Stefan Wahren
2022-05-15 20:20 ` [PATCH 02/11] dt-bindings: soc: bcm: bcm2835-pm: Introduce reg-names Stefan Wahren
2022-05-15 20:20 ` [PATCH 03/11] dt-bindings: soc: bcm: bcm2835-pm: Add support for bcm2711 Stefan Wahren
2022-05-18  0:55   ` Rob Herring [this message]
2022-05-15 20:20 ` [PATCH 04/11] ARM: dts: bcm2835/bcm2711: Introduce reg-names in watchdog node Stefan Wahren
2022-05-31 12:55   ` Peter Robinson
2022-05-15 20:20 ` [PATCH 05/11] ARM: dts: bcm2711: Use proper compatible in PM/Watchdog node Stefan Wahren
2022-05-31 12:56   ` Peter Robinson
2022-05-15 20:20 ` [PATCH 06/11] mfd: bcm2835-pm: Use 'reg-names' to get resources Stefan Wahren
2022-05-31 14:54   ` Peter Robinson
2022-05-31 17:12     ` Stefan Wahren
2022-05-15 20:20 ` [PATCH 07/11] mfd: bcm2835-pm: Add support for BCM2711 Stefan Wahren
2022-05-31 15:08   ` Peter Robinson
2022-05-31 17:27     ` Stefan Wahren
2022-05-31 20:11       ` Peter Robinson
2022-05-31 22:03         ` Stefan Wahren
2022-06-01 11:09           ` Peter Robinson
2022-05-15 20:20 ` [PATCH 08/11] soc: bcm: bcm2835-power: Refactor ASB control Stefan Wahren
2022-05-31 15:18   ` Peter Robinson
2022-05-15 20:20 ` [PATCH 09/11] soc: bcm: bcm2835-power: Resolve ASB register macros Stefan Wahren
2022-05-31 15:47   ` Peter Robinson
2022-05-31 17:34     ` Stefan Wahren
2022-05-15 20:20 ` [PATCH 10/11] soc: bcm: bcm2835-power: Add support for BCM2711's RPiVid ASB Stefan Wahren
2022-05-31 15:58   ` Peter Robinson
2022-05-15 20:20 ` [PATCH 11/11] soc: bcm: bcm2835-power: Bypass power_on/off() calls Stefan Wahren
2022-05-31 16:03   ` Peter Robinson
2022-05-18 20:22 ` [PATCH 00/11] soc: bcm2835-power: Prepare BCM2711 V3D support Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220518005535.GA1974187-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=maxime@cerno.tech \
    --cc=melissa.srw@gmail.com \
    --cc=nsaenz@kernel.org \
    --cc=pbrobinson@gmail.com \
    --cc=phil@raspberrypi.com \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).