From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25555C433F5 for ; Wed, 18 May 2022 06:08:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=A5QEpRJylkLAAq4UTSgakjonZLl0dvV7y9RS0K8/RU8=; b=C88K/7Io/j1ffF pcJh+7n+DHNqcF8C5xqnxE8+Yvs36eozzUNuYzQ/+ANWlV7V/wQ6J9jV57gp0EJDZeyLSV7ge8J4V DOMLAE9aet6jjCedPXK/dfCEJY24F1URFJE5AvIuSNJwk3Mej8Gqvx6gqZhoIKs218AimDHI5yoki qSWThBueLwH4lcd5utfp8OqQL6F2K+mg1tLPXUAM7QEq/n5dv/5ov5MYlFdcVjQvJLf94rjazig0g z4YuoYlWBLOKPzGHbmWPXVS/evPjEdWsYrq7mulx/RSH/MnV/Sp1y7M3LNbFkckXm1Hjdp6e2Wd6L OuzNieG6280xkHmehBrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrCqL-00HJQa-Kn; Wed, 18 May 2022 06:07:33 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrCqG-00HJPF-Fe; Wed, 18 May 2022 06:07:30 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 24I6785D076515; Wed, 18 May 2022 01:07:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1652854028; bh=1WvPsAXVU3I6iEL/xPevGeWMt1iF1upV77sTqtkqg3M=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=PBlRtz944rabxC7wXOMP+75qAwspwKCxkKtEw4wH1/5Lr89in7qR4Vqme76ONJSal CsxKP6r3DxXeYwP48fn93OLJxjE3EtpTENRGAw6E0HDWY+/RMnbZ/7zulkZfDpM3jY LwUaQS+sd7x6wHzctCtanYqmQqBtxMouSuAUyPXo= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 24I6772H124779 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 18 May 2022 01:07:07 -0500 Received: from DLEE105.ent.ti.com (157.170.170.35) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Wed, 18 May 2022 01:07:07 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Wed, 18 May 2022 01:07:06 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 24I675ou003134; Wed, 18 May 2022 01:07:06 -0500 Date: Wed, 18 May 2022 11:37:05 +0530 From: Pratyush Yadav To: Miquel Raynal CC: Nishanth Menon , Tero Kristo , Rob Herring , Tudor Ambarus , Michael Walle , Richard Weinberger , Vignesh Raghavendra , Mark Brown , =?utf-8?Q?C=C3=A9dric?= Le Goater , , , , , Subject: Re: [RFC PATCH 3/6] mtd: spi-nor: core: run calibration when initialization is done Message-ID: <20220518060640.os5fp5rez4ie7qc4@ti.com> References: <20210311191216.7363-1-p.yadav@ti.com> <20210311191216.7363-4-p.yadav@ti.com> <20220517160226.4107f282@xps-13> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220517160226.4107f282@xps-13> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220517_230728_730944_0CCEE016 X-CRM114-Status: GOOD ( 29.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org +Cedric On 17/05/22 04:02PM, Miquel Raynal wrote: > Hi Pratyush, > = > p.yadav@ti.com wrote on Fri, 12 Mar 2021 00:42:13 +0530: > = > > Once the flash is initialized tell the controller it can run > > calibration procedures if needed. This can be useful when calibration is > > needed to run at higher clock speeds. > > = > > Signed-off-by: Pratyush Yadav > > --- > > drivers/mtd/spi-nor/core.c | 12 ++++++++++-- > > 1 file changed, 10 insertions(+), 2 deletions(-) > > = > > diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c > > index 88888df009f0..e0cbcaf1be89 100644 > > --- a/drivers/mtd/spi-nor/core.c > > +++ b/drivers/mtd/spi-nor/core.c > > @@ -3650,6 +3650,7 @@ static int spi_nor_probe(struct spi_mem *spimem) > > * checking what's really supported using spi_mem_supports_op(). > > */ > > const struct spi_nor_hwcaps hwcaps =3D { .mask =3D SNOR_HWCAPS_ALL }; > > + struct spi_mem_op op; > > char *flash_name; > > int ret; > > = > > @@ -3709,8 +3710,15 @@ static int spi_nor_probe(struct spi_mem *spimem) > > if (ret) > > return ret; > > = > > - return mtd_device_register(&nor->mtd, data ? data->parts : NULL, > > - data ? data->nr_parts : 0); > > + ret =3D mtd_device_register(&nor->mtd, data ? data->parts : NULL, > > + data ? data->nr_parts : 0); > > + if (ret) > > + return ret; > > + > > + op =3D spi_nor_spimem_get_read_op(nor); > = > Isn't this too specific? I really don't know much about spi-nors, but I > find odd to have this op being created here, why not moving this into > the _do_calibration() helper? Maybe the naming confused you but this is a function in the SPI NOR = core, not in SPI MEM. SPI NOR supports both SPI MEM based controllers = and "legacy" controllers, so the convention is to add the "spimem" = prefix before SPI MEM specific functions. So I don't get the comment = about it being too specific. It is too specific to what? And how can spi_mem_do_calibration() know what op the flash uses to read = data? SPI NOR or SPI NAND would know it, but not SPI MEM. That is why we = pass in that information to spi_mem_do_calibration(). > = > > + spi_mem_do_calibration(nor->spimem, &op); > = > A warning/info upon calibration error (not on the absence of the hook) > would be nice? Yes, agreed. > = > > + > > + return 0; > > } > > = > > static int spi_nor_remove(struct spi_mem *spimem) > = > Otherwise I like the overall idea. Thanks for reviewing. > = > Thanks, > Miqu=E8l -- = Regards, Pratyush Yadav Texas Instruments Inc. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel