From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE35DC433EF for ; Wed, 18 May 2022 14:02:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ahu3VvmpqhPz2z/M/BLF1+ZUWx71DnATZG0r8nucKdM=; b=RfRLkbHBtmmM22 eVWE4ekDcGBJ1paOov0GkMV4iwT8uk1acy4tT4ltYIJzW8Qg89gsUgh3LrZfwJIqkeEq4OC68H4VD QJnwOV8+42g5U11tdwIPQv+pIiT+i5qJx8U8wHAA5PkKmaxCSYLLP8mTz+/Uft131gvxOxkYyX+4J xxpXrnkx1kYY3UD2Bln6w9yGcKTlCtKZw6IgsF7FQwLlme0L0GAykljmfWPNabR7VY9w6Ftol9Mb1 9+11eLoFPyDyr0Rqduf8iz/UCDs8+cJrnPK2t8939rjA9taiQxZc20njesIz7Gpb/t2K3R67jb734 QCVJcY9lazXmChrzdmCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrKEg-002QLN-LE; Wed, 18 May 2022 14:01:10 +0000 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrKEd-002QJw-Ax for linux-arm-kernel@lists.infradead.org; Wed, 18 May 2022 14:01:08 +0000 Received: by mail-pf1-x435.google.com with SMTP id y41so2203369pfw.12 for ; Wed, 18 May 2022 07:01:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ar6rolDwLMeiHKbJnDClgLyagtpYgq995PIhqINQJmI=; b=OsMbFN6UrvDrNN0x3SKeFWq+SxjRL/JJpZp5yIY6ZSFLP/OrjvnIkq76NgNLjqw0H1 pVMF3pduSoX5BUlY/plgpl9vArHTEoNhG3AcgJsqmaE/Ef1/JRwUlIfxyeToS8EwgHNZ jvA+PAEmfSQmXlUs6nqrKgO9iabtZofxGUd3sN7BqRr8cvkCAyPE1rWhLzEh2nUSjgi+ QCvShooGOHp5rSaAd4RKvDQhFQiP091GC1mPvwq8Z5jvXtmKj5L8CHqGpKkw5+IGuoug Ur+KQec0ZrywjGfIpKPP/+6tCdc038aYFc4xi7TKo1kT/muZPLafdJFTZzoBahgOMPUY SSNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ar6rolDwLMeiHKbJnDClgLyagtpYgq995PIhqINQJmI=; b=GVIghbdpNv8FS98+OtZCtU3m78anXkIOy15qZCVRWPsjxzidDxHwxGB6d/zwYXGOxI OLW0zczx/6AAXR+XKLCtLhNNX5cpKCTRfHc3/NqUhXUOzGD58GdVzKVlniWBkqstazPj cJnmic2F/rubqFhJ0hV4SAE54x0WZysqLliuOMem+KiGGgyUzscRKWzyn4PsAgCLNkKT AdFbbYv5ysECCc/GZ0vyGvoDMRj0RB6EM7KRqlRIcQA+My10QhKhQvaz9g8K6I4f0cEX q6QLiW2mnh60ASBwTNuOVdY/gJcub1Nro3oSkjmHgC5erXOwC5bDMXQ+VWLC8WvXYy63 BwAQ== X-Gm-Message-State: AOAM5333vfZwtbo8pRq8VTzs5Z0YpOWsCuZUDdnUhL2kC0+vfEvJS0pK dF9x9KZbmL5rEXnQ29YXSS71yw== X-Google-Smtp-Source: ABdhPJx3TNLz5f+9W529D5xXMinFWX+KMP0uI3fcwFLjPjaV6R9V5Bp4DSPFyvBx/r/K6tv6GzEI0g== X-Received: by 2002:a63:4e62:0:b0:398:cb40:19b0 with SMTP id o34-20020a634e62000000b00398cb4019b0mr24001969pgl.445.1652882464989; Wed, 18 May 2022 07:01:04 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([137.184.121.66]) by smtp.gmail.com with ESMTPSA id s13-20020a17090302cd00b0015e8d4eb244sm1685310plk.142.2022.05.18.07.01.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 07:01:04 -0700 (PDT) Date: Wed, 18 May 2022 22:00:56 +0800 From: Leo Yan To: James Clark Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, broonie@kernel.org, acme@kernel.org, german.gomez@arm.com, mathieu.poirier@linaro.org, john.garry@huawei.com, Will Deacon , Mike Leach , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/4] perf tools: Use dynamic register set for Dwarf unwind Message-ID: <20220518140056.GC430350@leoy-ThinkPad-X240s> References: <20220517102005.3022017-1-james.clark@arm.com> <20220517102005.3022017-3-james.clark@arm.com> <20220517110322.GC153558@leoy-ThinkPad-X240s> <8f48b4d3-b463-a858-c0fc-0d503eee42dd@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8f48b4d3-b463-a858-c0fc-0d503eee42dd@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220518_070107_441892_68015601 X-CRM114-Status: GOOD ( 25.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 18, 2022 at 02:25:38PM +0100, James Clark wrote: > > > On 17/05/2022 12:03, Leo Yan wrote: > > On Tue, May 17, 2022 at 11:20:03AM +0100, James Clark wrote: > >> Architectures can detect availability of extra registers at > >> runtime so use this more complete set for unwinding. This > >> will include the VG register on arm64 in a later commit. > >> > >> If the function isn't implemented then PERF_REGS_MASK is > >> returned and there is no change. > >> > >> Signed-off-by: James Clark > > > > This patch looks good to me: > > Reviewed-by: Leo Yan > > > > Just curious, do you think should update the test (e.g. > > arch/arm64/tests/dwarf-unwind.c) to use arch__user_reg_mask()? > > I don't think so because the normal set of registers is manually > loaded in tools/perf/arch/arm64/tests/regs_load.S so it wouldn't > include this pseudo register. Also there is no SVE in the call > chain of the test so it would never have an effect. > > I could add a new test for SVE, but it depends on getting the > libunwind changes through first so will have to come later. It makes sense to add new SVE test later, thanks for clarification. So this patch series looks good for me. Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel