From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82F9CC433EF for ; Wed, 18 May 2022 19:00:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1ZsZDSh3FRwQwv+AgI6II+NmLaNKzflVeD+RcysRJYg=; b=1xJT6h5LmUWvaz Vr0Y8GL+HSZhvQqdRGcQpGccb94yCXFGkirHVzbkjbgX2YD0T82vXL8BWf3GI8tgfyyJInpRgW6V2 jPk6iojSUV6xyUE4iCqk1z0RQ6c/9hCgKL2ugc2+FspHJ7NDg5PfGYHP9Jz82aCpuumEpvWQpgoMD Cq07NGXPeDn9p/t2lxWgAx6mtPAketl7upN4/+qlaIuL6f1bWc35I2V14k/sOHKFg74MEz5hzkBLT IBSD0PwltrAxwTXd4FTZs0tVtBpxiLe0Tx9dKGTDD3aC+OcCI2qDcaS0TR946l1vh0nqqdrffhCP6 QBymBdL8QyUBXX37PPUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrOt6-003W8h-54; Wed, 18 May 2022 18:59:12 +0000 Received: from mail-oi1-f180.google.com ([209.85.167.180]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrOt3-003W7S-CC for linux-arm-kernel@lists.infradead.org; Wed, 18 May 2022 18:59:11 +0000 Received: by mail-oi1-f180.google.com with SMTP id e189so3790257oia.8 for ; Wed, 18 May 2022 11:59:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hl6vHR8m/JLovYO2gNE3ChbiYGqpt17k+OnwcqxZkjo=; b=7ZbljwqhYbNuW8YoLsTBrBqdr8L7YS2ZNkJ6MwVPgT0nVNDwqX2IVKEF4MqGRMx15l 3rznJut7OCnWGbTMfgFgnyKnngNOcjcVTWVUnmHraI4LJLkdqZKKlt9/v+oiW5MN/Tat 93LMLRrVCyhkvVXost53EccRCgaOLcA+Ro7kixuO3goFsL+hSulGEpQ73ntjbh3rT3C0 e+XQTU/7rwWpWPZys6QgRPTS4opMqzTBDpdN+F9nyI/ShXdo31HqneUwTRL8sB+QokL6 wm1IZ+LZk/Qbt66JQ0WF8V01izIgwYkJVPIn1Q4kg4KWHUcrdMio+CYzzjWawo5Q44Dp 0IWw== X-Gm-Message-State: AOAM533iYdS4dcCke68v+Xsi788S+BAmZysUqMiTi2psqr/DKDSkDQ8c G+2mYa8aDqnJPEDrW8egEQ== X-Google-Smtp-Source: ABdhPJyZK52/lZYsS9R3kKj1OyynJ0P1NooNpNVdFnOOXczUhwNDyIXF2qHiL1sltyV70oHQTWK1Fg== X-Received: by 2002:a05:6808:aa4:b0:325:91ff:43cc with SMTP id r4-20020a0568080aa400b0032591ff43ccmr623013oij.166.1652900345928; Wed, 18 May 2022 11:59:05 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id bd15-20020a056870d78f00b000e686d1389esm1202223oab.56.2022.05.18.11.59.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 11:59:05 -0700 (PDT) Received: (nullmailer pid 3695375 invoked by uid 1000); Wed, 18 May 2022 18:59:04 -0000 Date: Wed, 18 May 2022 13:59:04 -0500 From: Rob Herring To: Arnd Bergmann Cc: Oleksandr Tyshchenko , xen-devel , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , DTML , Linux Kernel Mailing List , Linux ARM , Oleksandr Tyshchenko , Jason Wang , Krzysztof Kozlowski , Julien Grall , Juergen Gross , Stefano Stabellini , "Michael S. Tsirkin" , Christoph Hellwig , Jean-Philippe Brucker Subject: Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops Message-ID: <20220518185904.GA3685644-robh@kernel.org> References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-6-git-send-email-olekstysh@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220518_115909_441234_510340D1 X-CRM114-Status: GOOD ( 20.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 18, 2022 at 03:32:27PM +0100, Arnd Bergmann wrote: > On Sat, May 7, 2022 at 7:19 PM Oleksandr Tyshchenko wrote: > > > > diff --git a/Documentation/devicetree/bindings/virtio/mmio.yaml b/Documentation/devicetree/bindings/virtio/mmio.yaml > > index 10c22b5..29a0932 100644 > > --- a/Documentation/devicetree/bindings/virtio/mmio.yaml > > +++ b/Documentation/devicetree/bindings/virtio/mmio.yaml > > @@ -13,6 +13,9 @@ description: > > See https://www.oasis-open.org/committees/tc_home.php?wg_abbrev=virtio for > > more details. > > > > +allOf: > > + - $ref: /schemas/arm/xen,dev-domid.yaml# > > + > > properties: > > compatible: > > const: virtio,mmio > > @@ -33,6 +36,10 @@ properties: > > description: Required for devices making accesses thru an IOMMU. > > maxItems: 1 > > > > + xen,dev-domid: > > + description: Required when Xen grant mappings need to be enabled for device. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + > > required: > > - compatible > > - reg > > Sorry for joining the discussion late. Have you considered using the > generic iommu > binding here instead of a custom property? This would mean having a device > node for the grant-table mechanism that can be referred to using the 'iommus' > phandle property, with the domid as an additional argument. > > It does not quite fit the model that Linux currently uses for iommus, > as that has an allocator for dma_addr_t space, but it would think it's > conceptually close enough that it makes sense for the binding. Something common is almost always better. That may also have the issue that fw_devlink will make the 'iommu' driver a dependency to probe. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel