From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91BADC433EF for ; Wed, 18 May 2022 20:28:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=DJVEAAT2tsv6rzJtUjcEs7lDA9+WNoc62qYH6nWuH8U=; b=gox9r9AgeUr9So 24xocmhYMXmLjaR/E52EzD13Lmq7vM9DmzPApHlFJfvEqPwiMtDflLa0OnZl0X5HP180/UmJlztLS 4sJ6rGBTyAAO6+UL4pvIuwCgSBfvhcP1oULzvPZnrP3FZcJNgQOfvT2/tw5NsD3h3tTbVRJjZaeOW ezBdLp8Hqm2SAZ4BowWbZYXVtx7kBPsv55ZgHzcQHoXgEpTm2LnXPqHSgjjkjAripViH5PEtC/Mgy GwEzyNxurxOroYdXkDCJCIwEAklR02btFpn4VYq6vifWC0AlPPT06ezt+axghWJBCfWyxkTM6Nx10 pQIKVCoFrXWMgkxcjvzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrQGi-003qtV-Bw; Wed, 18 May 2022 20:27:40 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrQGe-003qrq-Cn for linux-arm-kernel@lists.infradead.org; Wed, 18 May 2022 20:27:37 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3329BB8218C; Wed, 18 May 2022 20:27:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80D8CC385A9; Wed, 18 May 2022 20:27:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652905651; bh=/lAaSrQLepD71mhjbFwFsLTT2sap9WMVoGPLCN9zYms=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=qdNV/vKK5xJ5i5iKaUWWVE6rqMxBD46F7zk3cJ1n+Wm45LdGa+42qg7Pv6FoM43yB m4qCoI3x+yIEu7PhSWhXr4fdT/bx1SpQI3QJtSBrlQW2y77iSiFWfJw+eTElMB69mt Rt2AlrxLOp6yMBhmSmGeFr1AXpcJdL9dUtuj3MRbsRiP3W3Q42EGgpm6AwfaOcQG1z leKQRUSdQibPtDZfPdvBgV+4pquEmTQMZ0PzH+02vv1nr26BAzK+xaMEv/HvtKW386 4tOmjW4zMQw0F2y4OByBHl4/883xSqecvWJ20vZU1MmpxzLLbUlSydughJV5YOgpur MpoyDZbBJKPEw== Date: Wed, 18 May 2022 15:27:29 -0500 From: Bjorn Helgaas To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Marc Zyngier , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Gregory CLEMENT Subject: Re: [PATCH 04/18] PCI: Add PCI_EXP_SLTCAP_*_SHIFT macros Message-ID: <20220518202729.GA4606@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220518220556.753c0367@thinkpad> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220518_132736_609397_1BD41966 X-CRM114-Status: GOOD ( 20.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 18, 2022 at 10:05:56PM +0200, Marek Beh=FAn wrote: > On Wed, 18 May 2022 21:26:00 +0200 > Pali Roh=E1r wrote: > = > > On Wednesday 18 May 2022 14:23:22 Bjorn Helgaas wrote: > > > On Sun, Feb 20, 2022 at 08:33:32PM +0100, Marek Beh=FAn wrote: = > > > > From: Pali Roh=E1r > > > > = > > > > These macros allows to easily compose and extract Slot Power Limit = and > > > > Physical Slot Number values from Slot Capability Register. > > > > = > > > > Signed-off-by: Pali Roh=E1r > > > > Signed-off-by: Marek Beh=FAn = > > > = > > > Acked-by: Bjorn Helgaas > > > = > > > We talked about using FIELD_PREP() / FIELD_GET(), which I think would > > > remove the need for the *_SHIFT macros. But we can always do that > > > later. = > > = > > I have already done this for pci-mvebu.c driver and patch was merged: > > https://lore.kernel.org/linux-pci/20220412094946.27069-5-pali@kernel.or= g/ > > = > > IIRC we have decided to not use those *_SHIFT macros as it would flood > > public uapi file and from this file we cannot remove macros due to > > userspace backward compatibility. > = > So should I change patch 5 of the aardvark batch 5 to also use > FIELD_GET(), so that this patch is not needed? That would be awesome if you could. I forgot about the backward compatibility issue with include/uapi/linux/pci_regs.h Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel