linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: "benlypan@gmail.com" <benlypan@gmail.com>
To: jernej.skrabec <jernej.skrabec@gmail.com>,
	mripard <mripard@kernel.org>,  wens <wens@csie.org>
Cc: airlied <airlied@linux.ie>, daniel <daniel@ffwll.ch>,
	 samuel <samuel@sholland.org>,
	 dri-devel <dri-devel@lists.freedesktop.org>,
	 linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	 linux-sunxi <linux-sunxi@lists.linux.dev>,
	 linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/sun4i: mixer: fix scanline for V3s and D1
Date: Sun, 22 May 2022 18:53:14 +0800	[thread overview]
Message-ID: <202205221853133067396@gmail.com> (raw)
In-Reply-To: 3173956.44csPzL39Z@jernej-laptop

Hi Jernej!

> Which SDK? All SDKs that I have or found on internet don't mention YUV nor RGB
> scanline limit. That doesn't mean there is none, I'm just unable to verify
> your claim. Did you test this by yourself? Also, please make YUV scanline
> change separate patch with fixes tag.

Here is the code about scanline config for V3s:
https://github.com/Tina-Linux/tina-v3s-linux-4.9/blob/master/drivers/video/fbdev/sunxi/disp2/disp/de/lowlevel_sun8iw8/de_feat.c#L55
https://github.com/Tina-Linux/tina-v3s-linux-4.9/blob/master/drivers/video/fbdev/sunxi/disp2/disp/de/lowlevel_sun8iw8/de_rtmx.c#L1212

And here is for D1:
https://gitlab.com/weidongshan/tina-d1-h/-/blob/main/lichee/linux-5.4/drivers/video/fbdev/sunxi/disp2/disp/de/lowlevel_v2x/de_feat.c#L182
https://gitlab.com/weidongshan/tina-d1-h/-/blob/main/lichee/linux-5.4/drivers/video/fbdev/sunxi/disp2/disp/de/lowlevel_v2x/de_rtmx.c#L1588

I was tested it on V3s. Without this patch, the plane will not display
correctly if src_w large than 1024, for both YUV and RGB. I don't have a
device with D1, so D1 is not tested. But according to the SDK code of D1,
the scanline value of mixer1 is 1024.

I'm new to submitting patches, So may I ask a question? If there is no
problem with this patch, what I need to do is to send new patches as you
suggested?

Best regards,
Genfu Pan

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-05-22 10:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-21 13:34 [PATCH] drm/sun4i: mixer: fix scanline for V3s and D1 Genfu Pan
2022-05-22  8:36 ` Jernej Škrabec
2022-05-22 10:53   ` benlypan [this message]
2022-05-23 13:14   ` Icenowy Zheng
2022-05-24 17:07     ` Samuel Holland
2022-05-24 19:01       ` Jernej Škrabec
     [not found]   ` <202205221848264427024@gmail.com>
2022-05-24 19:08     ` Jernej Škrabec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202205221853133067396@gmail.com \
    --to=benlypan@gmail.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=mripard@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).