From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7A26C433EF for ; Sun, 22 May 2022 10:54:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:Mime-Version:References: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: List-Owner; bh=ZaYaPt+nYfrdVAxCiw7hb9FDhJF6oBshfgvjA7zuKDY=; b=X5AS6XBO0bywXe E+5hfkGadVhPv20wdNpjee5OtGHSQU6J71j2TM+Qa62b+/v2bEH0oLV8DIcr6G8n3G26I6JoVGUsJ zvx27rxyVdFLqy5EtT5qP8BYgDlgaHWJA52kaTgyGJdsehutwwW0xWojXxCwKxS55nH2zprZtKq5p 8im/IqN8871UDwF1uhs7BYtO4ja6/iP6So+QIaJF/Fpf45iruMKSi3d0/YaAE7duHvPOgSjCAb298 eb0q5dGDsFQbIz4dASGsRvFLmVj7WoyriySrvYnLQ09ldpm637ppB0yjtmeewe8NkvgUriTW2ckbE TKNNFcJqGJRVzB5PfXwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsjCz-0018HU-B8; Sun, 22 May 2022 10:53:13 +0000 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsjCw-0018Gw-Bf for linux-arm-kernel@lists.infradead.org; Sun, 22 May 2022 10:53:11 +0000 Received: by mail-pg1-x533.google.com with SMTP id 137so11369300pgb.5 for ; Sun, 22 May 2022 03:53:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:references:mime-version:message-id :content-transfer-encoding; bh=bSbLSYLiEVp5Ck75TvixzyuLOTYB4+YAC/RLwIpjiSE=; b=oOmOzcOCSEk/WVR9gogBlVXlbC+V8Yhj+SWAhCXFbfy9LncFZjitmN4O+IcmRrjmsV 2vOeMMJa3X7fb6G+0nUKOZQx43MAsPKyLqZfLl0aw3JjRcGdI2IPXGH5aEuLFIjwYlkE CJfPRxaTz4H+ld7jH40fhBkfE9k3uC1DE9KEZx61sAbPvj8XMerqLMcIPxpKu0+lEv9h jgXyaHSUMfa+CCaO1anbRFgBLMjxYhCXvgMslS897C7DqW3AkOZLImftxZfcMtpd7+Qi zNqqT86NHh1TS5Oqiaoht2Hrn6U4aJ1EqHjKaT2Vxja+HnEv2iTT9nme8+ah8jyQGOvq uqAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:references:mime-version :message-id:content-transfer-encoding; bh=bSbLSYLiEVp5Ck75TvixzyuLOTYB4+YAC/RLwIpjiSE=; b=ZYFYAqJgq7w+aXF8W0lcYQ5uIGEJUxxkKo7z+IQceHjs60jlI2FArGXC4rrSSVPzyK 6GEYOqHoRRFPcsYi4trmWQbXhSOXxXpCvnQVQtM6Z3Lryn65cHzVaZFLa6h8NdkmZLAT jxwOf/pYDTje8eYjOH6yaeJanXbeTEoN9nCm1Uv/nVXzv+9wjepsgrZZxv6F+2RxWE4Q 4EeM/up38Tf8Niil86f9+YMay/bf9cQ66X2E5GyfQvlpzkORpOQDWFhSp+55V8sVwkvg ODe3eMVVefDcFo+u80P5oyboV/4Tm15XBd3x2WcA0lAtK97UI/pgqQAHeYSdvQZxbMWC zPgw== X-Gm-Message-State: AOAM531PU43T71LMAi8wHqZJ2WqP8e9Ph8ry/BA5pa0YfZpvxakfHbUs JrA5QHo0O2kmQWJ9tRLBO1I= X-Google-Smtp-Source: ABdhPJzuGobPl0n/IDwG0R6zGw+enGaFKapO6cpkrcksA2pK/rcVkCHeFnnQEze9bx97oxKIyAQWRQ== X-Received: by 2002:a63:3d87:0:b0:3f6:1c54:b315 with SMTP id k129-20020a633d87000000b003f61c54b315mr16471834pga.432.1653216789034; Sun, 22 May 2022 03:53:09 -0700 (PDT) Received: from DESKTOP-PUVK7A5 ([144.24.65.202]) by smtp.gmail.com with ESMTPSA id v23-20020a1709028d9700b0016160b3331bsm973618plo.305.2022.05.22.03.53.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 22 May 2022 03:53:08 -0700 (PDT) Date: Sun, 22 May 2022 18:53:14 +0800 From: "benlypan@gmail.com" To: jernej.skrabec , mripard , wens Cc: airlied , daniel , samuel , dri-devel , linux-arm-kernel , linux-sunxi , linux-kernel Subject: Re: [PATCH] drm/sun4i: mixer: fix scanline for V3s and D1 References: <20220521133443.1114749-1-benlypan@gmail.com>, <3173956.44csPzL39Z@jernej-laptop> X-Priority: 3 X-GUID: 44554B07-4D1B-4258-8E6F-B7B805B582F0 X-Has-Attach: no X-Mailer: Foxmail 7.2.20.259[cn] Mime-Version: 1.0 Message-ID: <202205221853133067396@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220522_035310_440476_6914C61D X-CRM114-Status: UNSURE ( 9.98 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jernej! > Which SDK? All SDKs that I have or found on internet don't mention YUV nor RGB > scanline limit. That doesn't mean there is none, I'm just unable to verify > your claim. Did you test this by yourself? Also, please make YUV scanline > change separate patch with fixes tag. Here is the code about scanline config for V3s: https://github.com/Tina-Linux/tina-v3s-linux-4.9/blob/master/drivers/video/fbdev/sunxi/disp2/disp/de/lowlevel_sun8iw8/de_feat.c#L55 https://github.com/Tina-Linux/tina-v3s-linux-4.9/blob/master/drivers/video/fbdev/sunxi/disp2/disp/de/lowlevel_sun8iw8/de_rtmx.c#L1212 And here is for D1: https://gitlab.com/weidongshan/tina-d1-h/-/blob/main/lichee/linux-5.4/drivers/video/fbdev/sunxi/disp2/disp/de/lowlevel_v2x/de_feat.c#L182 https://gitlab.com/weidongshan/tina-d1-h/-/blob/main/lichee/linux-5.4/drivers/video/fbdev/sunxi/disp2/disp/de/lowlevel_v2x/de_rtmx.c#L1588 I was tested it on V3s. Without this patch, the plane will not display correctly if src_w large than 1024, for both YUV and RGB. I don't have a device with D1, so D1 is not tested. But according to the SDK code of D1, the scanline value of mixer1 is 1024. I'm new to submitting patches, So may I ask a question? If there is no problem with this patch, what I need to do is to send new patches as you suggested? Best regards, Genfu Pan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel