Re: [PATCH 0/3] ARM: s3c: Kconfig: Style cleanups

Juerg Haefliger
2022-06-07T07:01:33Z

[-- Attachment #1.1: Type: text/plain, Size: 1325 bytes --]

On Mon, 6 Jun 2022 11:14:28 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

> On 06/06/2022 11:13, Krzysztof Kozlowski wrote:
> > On Mon, 23 May 2022 08:42:49 +0200, Juerg Haefliger wrote:
> >> The majority of the Kconfig files use a single tab for basic indentation
> >> and a single tab followed by two whitespaces for help text indentation.
> >> Fix the lines that don't follow this convention.
> >>
> >> While at it, add missing trailing comments to endif statements and replace
> >> tabs before comments with whitespaces (which seems to be more common).
> >>
> >> [...]
> >
> > Applied, thanks!
> >
> > [1/3] ARM: s3c: Kconfig: Fix indentation
> > https://git.kernel.org/krzk/linux/c/076702da7e8a2472f8ac86f1179ddcc5e90febae
> > [3/3] ARM: s3c: Kconfig.s3c64xx: Fix indentation
> > (no commit info)
>
> ...And dropped. This does not pass checkpatch. Please be sure you run
> scripts/checkpatch on your contributions.

I did and the check passed but email aliases don't work well in this scenario.
Will fix and resubmit.

...Juerg

> WARNING: From:/Signed-off-by: email address mismatch: 'From: Juerg
> Haefliger <juerg.haefliger@canonical.com>' != 'Signed-off-by: Juerg
> Haefliger <juergh@canonical.com>'
>
>
> Best regards,
> Krzysztof

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]