From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 484C2C433EF for ; Mon, 23 May 2022 11:51:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=DGYTVJ9y58SOueBr1vpQ1qca1mjjyvDMMYCVXFKoNEo=; b=InxoigHUPNvXwd jzSyBEvRC+MDQHhrqT/NXtziXIU+T5VyT5zEf6cFOZCbFccSlAg5vyruLyggrARcW+qVSI+zDbDJk OK5XTUk70SlBqBpxdnOQQD6EfTvXI6AcowKPMo50OhOpV5rKPEZuiSPKheIvDuBxkIJcZkbSG5jbT JnrSKypkiOwrjTgPxmvGs7XRhwbT2VH4mLCp6G1yMTNIt1/V/mah95fPQACgQIEQ83PPN+chYIXUI igzDQAbm3a2nnSiYmezVQaNp2YsLf9ifFZ2wgtNER/pzSaRcCuDgSLOSrZVOH5F7pz79sxlqA+Rym 57i6KyT4WwDMgumzVd1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nt6ZQ-003qxa-PW; Mon, 23 May 2022 11:49:56 +0000 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nt5y7-003Zaw-Pn for linux-arm-kernel@lists.infradead.org; Mon, 23 May 2022 11:11:25 +0000 Received: by mail-pf1-x431.google.com with SMTP id b135so1634394pfb.12 for ; Mon, 23 May 2022 04:11:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UHS/1H01y880FAOLumjFQUSmGq2wt4Kc1CYUuYq+T+8=; b=M/kmIjoIH0HE5rSxdyUKmWN4nvj6jHeeKirmX0XfOYKQUtn0crCZuLzdb/jUkOEUaz jHmCO547LSP9WmMHp4mz5E9lQSWZr4sX1Fx2H1Vo9CjLcbazk9eH+lecXlB06x6TgEkT AsNAoYQw2oXyJxBUdgsQ9G3GVNJv5KFoaLG80u3PiKx7mocClDrL+p1MkSD8GxUwJMH0 XclhbhES7tfdxt4pg57V97uXXHqsdaJQ8TWU25sJ8Uw1yUwFBmzt1dBlc4q9aNodaiQl Cgo6VIa4W00mkLW6LiDaq8r+L9d6y58rbDF+S2PHtjbqSpcL1fwMVs0pMRYI7m8L4Q1g AImw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UHS/1H01y880FAOLumjFQUSmGq2wt4Kc1CYUuYq+T+8=; b=OoixGxwqz29KqmJi8p8fYg6vagxLAr6vNQ8z93YoBE0GrZF4sEhBmi7pgy96hAoUAN n45Ntztfjf3Rd3OcTzb5618RfDKSHSGoqDgzIE3ITMfdoWtF+KWBtnoMbFhlLdMOaObK UJyVpJe2LEnBjYsyhHI+nHASKErgoP8a59/jOCH37AM6gxt8HzNinj8LUz+PLkEIbxiO w7dWLOHiODRSpEF/2iMxKpxXI2cqV+Y2F9NOZHUUktlbRQKEyS5YReh92i6lLfMzdmHn pSexpjrogQaeltpJGNrxMxP3gc4jYeQSNymihvKaCoyNUL1mFhNeYfiWxVx0SkEIrgxg ApYQ== X-Gm-Message-State: AOAM531YhQ+xpx10I6rCxTwBFaHMyV8iSDM2pIi7CGOnUors2KW6j9bd I/z9nR6Cn2+nIwXBKzJMFs8= X-Google-Smtp-Source: ABdhPJwJSPG5JEpcnsXp2Zp+js+ZyFzCKAhC3sGfIFRSuurmk9tXfgp/Ht6NJTy0UrKwfoDp3tVdRg== X-Received: by 2002:a63:2b11:0:b0:3f6:5f7f:9e67 with SMTP id r17-20020a632b11000000b003f65f7f9e67mr15842513pgr.492.1653304281479; Mon, 23 May 2022 04:11:21 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id i11-20020a1709026acb00b001617ffc6d25sm4878253plt.19.2022.05.23.04.11.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 04:11:20 -0700 (PDT) From: cgel.zte@gmail.com X-Google-Original-From: chi.minghao@zte.com.cn To: sudeep.holla@arm.com Cc: cristian.marussi@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Minghao Chi , Zeal Robot Subject: [PATCH] firmware: arm_scmi: Avoid leak OF node on error Date: Mon, 23 May 2022 11:11:16 +0000 Message-Id: <20220523111116.2898-1-chi.minghao@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220523_041123_870795_636372D8 X-CRM114-Status: GOOD ( 12.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Minghao Chi The OF node should be put before returning error in smc_chan_available(), otherwise node's refcount will be leaked. Reported-by: Zeal Robot Signed-off-by: Minghao Chi --- drivers/firmware/arm_scmi/smc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/arm_scmi/smc.c b/drivers/firmware/arm_scmi/smc.c index 745acfdd0b3d..43018be70edc 100644 --- a/drivers/firmware/arm_scmi/smc.c +++ b/drivers/firmware/arm_scmi/smc.c @@ -55,10 +55,10 @@ static irqreturn_t smc_msg_done_isr(int irq, void *data) static bool smc_chan_available(struct device *dev, int idx) { struct device_node *np = of_parse_phandle(dev->of_node, "shmem", 0); + of_node_put(np); if (!np) return false; - of_node_put(np); return true; } -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel