From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1381AC433EF for ; Tue, 24 May 2022 23:58:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iJygXCoevc/MNHS7122UYXciXcS8ZEmWYBAT7F3XG2c=; b=FO6/rwMj5Cja2PWN1ntAe045TV Ie5x+ACYXwBRV44DE0+D3SOBjKwhRkS5t1uRHWLaoANb1SBQUrcdvQ7aG9FhiB7955NhqaxE6UIxh RbMwIRViP0lnnLauKi8OVoCIVhTwhx5bfRSKoUPWENTjW9ie8S/eESn9j+2X2X/WI5GSWTM9sdOnS +DkMkOFhvmGXrHsjoTVa+YPeW5ORLLO66sGXgfoBXq/ohlTJT4wYToiWSk281BQ9b8Lcs0cLRH5W+ 6viI9N+2eMETqTjaKBxakAyLOf6TyDkvJgbyRF3lQqdd2BZbBSexEuymddaMNwgjmVfrw/jjTkawQ ZVJk+C1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nteO2-009RmT-AJ; Tue, 24 May 2022 23:56:26 +0000 Received: from hobbes.mraw.org ([195.154.31.160]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nteNw-009Rln-TW; Tue, 24 May 2022 23:56:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mraw.org; s=mail2022; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gqCLtPa2Zzz2oEdqi3oj2xUKzoRcEUhnAmWGh8qOxXY=; b=yy2Kp0nLeoG5AeQGjfDVrGhQ+y pEiZi9XROenv64p5mfS5GascFcVo2s/tCfVLYCgvnF3pRUOs7+BVEFfdAmao18gKYjCtebxa/JS3e IcoqNGCZkcYT75K9Hbf2VdouOIHG2PIgPhlMT5zHs8EjoTy7OyektrI5a7jP6WCrP3DNVbd+R7Wpv TvQR8FyqLbRYID50wuxE43ROx7cJ4Hp0qLU2hAlEeGLn7CQKk84Nj8fqp22q6nx/Xc/cisb4m/aMB CVHVYgm1DCal2/sM4xnmGO+AuAbHiJQUvALG3xktns1r4XdOVvSR1VWjW7gZnXsihKD6LqDPxv6Xg 5HuC7ieQ==; Received: from 82-64-171-251.subs.proxad.net ([82.64.171.251] helo=mraw.org) by hobbes.mraw.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nteNj-003nRz-K7; Wed, 25 May 2022 01:56:07 +0200 Date: Wed, 25 May 2022 01:56:05 +0200 From: Cyril Brulebois To: Jim Quinlan Cc: Bjorn Helgaas , linux-pci , Nicolas Saenz Julienne , Bjorn Helgaas , James Dutton , bcm-kernel-feedback-list , Jim Quinlan , Florian Fainelli , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list , "Rafael J. Wysocki" , linux-pm@vger.kernel.org Subject: Re: [PATCH v1] PCI: brcmstb: Fix regression regarding missing PCIe linkup Message-ID: <20220524235605.rz3cyw7akw3327ip@mraw.org> Organization: Debian References: <20220523221036.GA130515@bhelgaas> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220524_165620_996518_AA84BA2E X-CRM114-Status: GOOD ( 15.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5552352062425261977==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5552352062425261977== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gj63ap2kyrcnvzrr" Content-Disposition: inline --gj63ap2kyrcnvzrr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Jim, Jim Quinlan (2022-05-24): > Yes. One repo did not have this node (Cyril/debina?), one did > (https://github.com/raspberrypi/firmware/tree/master/boot). > Of course there is nothing wrong with omitting the node; it should > have pcie linkup regardless. I work/debug stuff on Debian systems, but Debian's just shipping what's in mainline. Raspberry people maintain their own vendor DTBs. > Unless you object, I plan on sending you a v2 of my regression fix > which will correct the commit message, change the "if (busno =3D=3D 1)" > conditional to only guard the pcie linkup call, and add further > comments. >=20 > I have noted and will also address your other concerns and suggestions > in a future patchset as I think it is best that I get my hands on a > CM4 board before I submit any more changes. For the record, I'm still happy to be cc'ed so that I spend time testing further patches, be it the short-term regression fix (for inclusion in master, but also checking it fixes linux-5.17.y and now linux-5.18.y, if stable maintainers would welcome the extra testing), or the future patchset. I can't guarantee you'll have an answer in a few hours like that happened during the past few days (during which I prioritized testing over anything else so as not to be a blocker in case it could be squeezed into v5.18). But I'm still willing to allocate some time to make sure the CM4 keeps working, even if you don't get your hands on such systems right away. Cheers, --=20 Cyril Brulebois (kibi@debian.org) D-I release manager -- Release team member -- Freelance Consultant --gj63ap2kyrcnvzrr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEtg6/KYRFPHDXTPR4/5FK8MKzVSAFAmKNcI8ACgkQ/5FK8MKz VSCfFw/9ExgzEXqJQAACsMXdquRjdNCULhvZUtAQFLvLgusQmQ//RL+XzP5k8z6F j8WS/0fQMMoA9uIySXgLHFKJ5LXBgt3TG/x8KQqpYwM4Kir6XiG+g1iOnuLaTzRv xRVe31HhOSHP5XdrQqRgzjZRKBxP/llg/NNzbn4ZwL2M+TTNyMsZg/B5pLyGs+yp 62ip+XyiIZtYMb63K3/rEH0gKNY+6P+XjRMfW55gPbz+hoXafuuJuElrlXaWeGj8 i4DEOQNFH9Mqiy783Fm2+FpEMNC5sWlgg5DO8zzTUILKDMpi+IB9BxCD4M494ycD CWmJWx88mu4iKu62DIViW8Vb1Oi9PyZm0JauLGqjK/jQ/vljQgSr0sBpHc/vW9Lr sOy/b6ZhikOaYto/MgNkct2DE1Vlx/SOIsZPg3v7GDDBAw/j5pkEEghJFu8grpQp hyhI98GTEghoWOOHSZsxZ8xYCsXC4b6KcF4D6FBeyWygZtE+L4PPx/lLUl5z8N/G u7vvGdlFk/Eko5QOp7rR6qo+daaFhrAhUgDbRFL8Drgpawfze6XnebsgZV6t9mEs uwFOmPUaovWWRqCa65CEBJd6oqeL5LfSMPrvn6j2gLmwouMEzBAgN3O46WvOOYNn HxH7rCEK6s+Rxq2XcfUtez2tCNurBGRQCACaNBV8rElb/4nLJZE= =zXtQ -----END PGP SIGNATURE----- --gj63ap2kyrcnvzrr-- --===============5552352062425261977== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5552352062425261977==--