* [PATCH] ARM: bcm: Fix refcount leak in bcm_kona_smc_init
@ 2022-05-26 8:13 Miaoqian Lin
2022-06-08 9:23 ` Florian Fainelli
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2022-05-26 8:13 UTC (permalink / raw)
To: Russell King, Florian Fainelli, Ray Jui, Scott Branden,
Broadcom Kernel Team, Christian Daudt, Arnd Bergmann,
linux-arm-kernel, linux-kernel
Cc: linmq006
of_find_matching_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
Fixes: b8eb35fd594a ("ARM: bcm281xx: Add L2 cache enable code")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
arch/arm/mach-bcm/bcm_kona_smc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-bcm/bcm_kona_smc.c b/arch/arm/mach-bcm/bcm_kona_smc.c
index 43829e49ad93..347bfb7f03e2 100644
--- a/arch/arm/mach-bcm/bcm_kona_smc.c
+++ b/arch/arm/mach-bcm/bcm_kona_smc.c
@@ -52,6 +52,7 @@ int __init bcm_kona_smc_init(void)
return -ENODEV;
prop_val = of_get_address(node, 0, &prop_size, NULL);
+ of_node_put(node);
if (!prop_val)
return -EINVAL;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ARM: bcm: Fix refcount leak in bcm_kona_smc_init
2022-05-26 8:13 [PATCH] ARM: bcm: Fix refcount leak in bcm_kona_smc_init Miaoqian Lin
@ 2022-06-08 9:23 ` Florian Fainelli
0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2022-06-08 9:23 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Miaoqian Lin, Russell King, Ray Jui,
Scott Branden, Christian Daudt, Arnd Bergmann, linux-arm-kernel,
linux-kernel
On Thu, 26 May 2022 12:13:25 +0400, Miaoqian Lin <linmq006@gmail.com> wrote:
> of_find_matching_node() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: b8eb35fd594a ("ARM: bcm281xx: Add L2 cache enable code")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/soc/next, thanks!
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-08 9:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-26 8:13 [PATCH] ARM: bcm: Fix refcount leak in bcm_kona_smc_init Miaoqian Lin
2022-06-08 9:23 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).