From: Leo Yan <leo.yan@linaro.org>
To: Joe Mario <jmario@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ali Saidi <alisaidi@amazon.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, german.gomez@arm.com,
benh@kernel.crashing.org, Nick.Forrington@arm.com,
alexander.shishkin@linux.intel.com, andrew.kilroy@arm.com,
james.clark@arm.com, john.garry@huawei.com,
Jiri Olsa <jolsa@kernel.org>,
kjain@linux.ibm.com, lihuafei1@huawei.com, mark.rutland@arm.com,
mathieu.poirier@linaro.org, mingo@redhat.com,
namhyung@kernel.org, peterz@infradead.org, will@kernel.org
Subject: Re: [PATCH v8 0/4] perf: arm-spe: Decode SPE source and use for perf c2c
Date: Thu, 26 May 2022 22:44:53 +0800 [thread overview]
Message-ID: <20220526144453.GC795802@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <7bf021df-2755-6937-629f-b3ed9281804d@redhat.com>
Hi Joe,
On Mon, May 23, 2022 at 01:24:32PM -0400, Joe Mario wrote:
[...]
> Hi Leo:
> I figured out why my output was different than yours.
>
> I did not have the slang-devel rpm installed on the host system.
>
> In my original perf build, I missed the this output in the build log:
> > slang not found, disables TUI support. Please install slang-devel, libslang-dev or libslang2-dev
>
> Once I installed slang-devel, rebuilt perf, and then reran my test, the pareto output looked fine.
>
> When the TUI support is disabled, it shouldn't corrupt the resulting stdio output. I don't believe this has anything to do with your commits.
Thanks for taking time to hunt this issue. I checked the code and
sent out a patch to fix the stdio interface if slang lib is not
installed. Please see the patch:
https://lore.kernel.org/lkml/20220526143917.607928-1-leo.yan@linaro.org/T/#u
> Last, it looks like you should update the help text for the display flag options to reflect your new peer option.
> Currently it says:
> -d, --display <Switch HITM output type>
> lcl,rmt
>
> But since you added the "peer" display, shouldn't the output for that help text state:
> -d, --display <Switch HITM output type>
> lcl,rmt,peer
Yeah, will fix.
Very appreciate for your detailed testing and suggestions.
Leo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-26 14:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 2:03 [PATCH v8 0/4] perf: arm-spe: Decode SPE source and use for perf c2c Ali Saidi
2022-05-17 2:03 ` [PATCH v9 1/5] perf: Add SNOOP_PEER flag to perf mem data struct Ali Saidi
2022-05-17 2:03 ` [PATCH v9 2/5] perf tools: sync addition of PERF_MEM_SNOOPX_PEER Ali Saidi
2022-05-17 2:03 ` [PATCH v9 3/5] perf mem: Print snoop peer flag Ali Saidi
2022-05-17 2:03 ` [PATCH v9 4/5] perf arm-spe: Don't set data source if it's not a memory operation Ali Saidi
2022-06-17 19:41 ` Arnaldo Carvalho de Melo
2022-05-17 2:03 ` [PATCH v9 5/5] perf arm-spe: Use SPE data source for neoverse cores Ali Saidi
2022-05-17 21:20 ` [PATCH v8 0/4] perf: arm-spe: Decode SPE source and use for perf c2c Arnaldo Carvalho de Melo
2022-05-18 1:06 ` Leo Yan
2022-05-18 4:16 ` Leo Yan
2022-05-19 15:16 ` Joe Mario
2022-05-22 6:15 ` Leo Yan
2022-05-23 17:24 ` Joe Mario
2022-05-26 14:44 ` Leo Yan [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-05-04 18:48 Ali Saidi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220526144453.GC795802@leoy-ThinkPad-X240s \
--to=leo.yan@linaro.org \
--cc=Nick.Forrington@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alisaidi@amazon.com \
--cc=andrew.kilroy@arm.com \
--cc=benh@kernel.crashing.org \
--cc=german.gomez@arm.com \
--cc=james.clark@arm.com \
--cc=jmario@redhat.com \
--cc=john.garry@huawei.com \
--cc=jolsa@kernel.org \
--cc=kjain@linux.ibm.com \
--cc=lihuafei1@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox