From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73143C433F5 for ; Fri, 27 May 2022 05:04:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jl8H5h5a2tko6++0PZUkuXMmxEGls5Rk0CX33ODNW/0=; b=uoljJSZEaBAMJS FoPsXtG0mayZPxp9eFp8NiJAbcOgEmtzOI+Z/3Tsi6mYQPtMM4WQghcVfkLtiU/3W0hiMC3pwWLZ/ s6QKk//7wio4ZKUUyKdd445As1AvMczQqVhyDiCHx+aAnClwIN2KdIPdxBXDbV6nF/wDhstyjCcBg tzqHXjx/sQWf09KnqzdoSCzwTA3U6mh5gIGPIX2W64CoCXM46O4A0vjW+RffWGQyw2oacU9YNAGXB 3u4K1s8eD6YzBZMiQvXhdCIM74cyFF7cSGP0P48PlWh9UapDxtQDJVx6kwE/7JVPpqrKGQ6+3islY mQeENGPPbhMZ4yeuJ9LQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuS7k-00GdyX-LC; Fri, 27 May 2022 05:02:56 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuS7h-00Gdwy-Pd for linux-arm-kernel@lists.infradead.org; Fri, 27 May 2022 05:02:55 +0000 Received: from pyrite.rasen.tech (softbank036240126034.bbtec.net [36.240.126.34]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D468AD80; Fri, 27 May 2022 07:02:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1653627762; bh=+reeRoguSkR43n2ptmDAW7UzvIJY6ZaGYu6pDQATOpc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i2PT6LG5/vRASxHBVxKWgJ/eBtInoLn/tOY6c5w6OGocf4iHpi8hr87MrUjFSPvPW M/ATLOos5+l95L2vINj4R/KuSvrzRqdc1Z8aPP/TP9NDHb96YEatUmBqOxRq7oc1dA VxBQnUeAiXou/Bve73Cy+vzqzRiQ/BwwTbk3ywnU= Date: Fri, 27 May 2022 14:02:34 +0900 From: paul.elder@ideasonboard.com To: Alexander Stein Cc: Shawn Guo , Sascha Hauer , Fabio Estevam , Lucas Stach , Adam Ford , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/1] soc: imx: imx8m-blk-ctrl: fix display clock for LCDIF2 power domain Message-ID: <20220527050234.GE4117012@pyrite.rasen.tech> References: <20220524073934.319134-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220524073934.319134-1-alexander.stein@ew.tq-group.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220526_220254_020931_D8CD592A X-CRM114-Status: GOOD ( 17.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alexander, On Tue, May 24, 2022 at 09:39:34AM +0200, Alexander Stein wrote: > LCDIF2 has its own display clock, use this one. Whoops, looks like I missed that :/ > > Fixes: 07614fed00e9 ("soc: imx: imx8m-blk-ctrl: Add i.MX8MP media blk-ctrl") > Signed-off-by: Alexander Stein Reviewed-by: Paul Elder > --- > I noticed this while trying to get LVDS (on LCDIF2) working. Apparently > it is not strictly required, but better to have this right. > > drivers/soc/imx/imx8m-blk-ctrl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c > index 7f49385ed2f8..7ebc28709e94 100644 > --- a/drivers/soc/imx/imx8m-blk-ctrl.c > +++ b/drivers/soc/imx/imx8m-blk-ctrl.c > @@ -667,7 +667,7 @@ static const struct imx8m_blk_ctrl_domain_data imx8mp_media_blk_ctl_domain_data[ > }, > [IMX8MP_MEDIABLK_PD_LCDIF_2] = { > .name = "mediablk-lcdif-2", > - .clk_names = (const char *[]){ "disp1", "apb", "axi", }, > + .clk_names = (const char *[]){ "disp2", "apb", "axi", }, > .num_clks = 3, > .gpc_name = "lcdif2", > .rst_mask = BIT(11) | BIT(12) | BIT(24), > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel