From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A693C433FE for ; Fri, 27 May 2022 16:34:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+HCjXYQPjLcb2Bnk2e9uFDw+FpT7M8FVZhZ+/+FHLLI=; b=Psx+TvjJVQU7/i McXZxG9oGqcGzcEkTzd9lhrDuW4whDaZFfBSrsRLnHsuDeE22JX7PCuAxXRJDm/vB2Nf284ygj7n9 88hnOQIocpeRez4U+gxi29EJwmnJXz4y0xMceTruOsNWwG12c07m1KEg24IbN5jfF4SlzbKipAhGq T6ShxQsrhD8K7NHIx+OpMcNZCd9MMmN2fhyXy7NIQr1ABXs4HyKZWCcNWwba6Fq3rHBNuA8mfhy5C f/5t/dUaoN5lZg/on3egNBp2bbVtuRn3gHDREgjkJiYdAJiusfP6CsQgLqxWJ8dSkl0hmMUSXroxO ZqlD2ib3StOcAcWgjpuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuctJ-000Xiv-Vl; Fri, 27 May 2022 16:32:46 +0000 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuctG-000Xhf-EG for linux-arm-kernel@lists.infradead.org; Fri, 27 May 2022 16:32:43 +0000 Received: by mail-pj1-x1032.google.com with SMTP id cs3-20020a17090af50300b001e0808b5838so4809275pjb.1 for ; Fri, 27 May 2022 09:32:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1FyaAmpRircQEP5FQceOqYcsjPI4fnrK8att4I373Fs=; b=SyfBkPFaN/fjvlbJgY8ff3C/0EweqZBeYzyFFDdk8T4e6PCGWL+dEY/abUDKSIX7pb Drg/FJBMCkr50Di90bUChbodmwahTabLebwNP2H3mxPuLI8phJRuwmHuqGhUZ0Sa8/K1 hwolzCf6kP6wfykag7oZhRMrv7bp+4v/VidkKo1UpVGJgj1obZWe8BGcwcRz5ksKeAG5 lQTiy+h3Cutvlo1l2J8TggKQLbnyiUrBCMVMeK+FwxSdFEzn2gO/aHpkKP1YNuRbXK4B B4zbO63Ko/RA/t6w0ctZFtjUEtHssBSFeDo0MKltTxwAx0I7I6l4wbaINhrb2J2Y+Ztx HIkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1FyaAmpRircQEP5FQceOqYcsjPI4fnrK8att4I373Fs=; b=Z0jZygucsV1I+2eao04A2fN9Br4ZI6E1sL+o+bDUMuJgDk1fL+Cjk2/MmiBZF6HvwP xPoAw7MsR3mrCASVWUVTa7O7468ckULNJmIee/PE9n7K4NsJpe6+Ndpo5Slv/smtgiQU iP2lgZDcc/Fcw2fNnzYtbvHezRQ6wadGfO4sIs6cnhOFIVaHKrmD5bE83qamXkHHO4fO 835ei3EjzH/+gkldTK6bytw2/fiKFBTGEve25fVJuni4UrvFSVbjg4eZZPTZWadbf2Y9 J1na4NFKJTKwLIJL8FDjB/XYYkCbp3qxkDH7rFa625kwyK9TlCupKmZxUU9m/cZkmRbd 42lQ== X-Gm-Message-State: AOAM5332sMXxGyiBgVU27j2Jas02GPV2hQNTH00liWV60+Ssx9UEtYIj /Ee8FH65RHO+VfylZGG9zfVF3w== X-Google-Smtp-Source: ABdhPJzTXXkzjKztY7+4U9ZPoccyNkK5JbRoPG71HnAXiemQROm4JRmEsYXdcb4tlWRqfqJs6h9y/g== X-Received: by 2002:a17:90b:4d8b:b0:1dc:a9c0:3d53 with SMTP id oj11-20020a17090b4d8b00b001dca9c03d53mr9081609pjb.29.1653669158403; Fri, 27 May 2022 09:32:38 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id q3-20020a056a00150300b00518e1251197sm3863073pfu.148.2022.05.27.09.32.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 May 2022 09:32:37 -0700 (PDT) Date: Fri, 27 May 2022 10:32:35 -0600 From: Mathieu Poirier To: Mike Leach Cc: linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, suzuki.poulose@arm.com, leo.yan@linaro.org Subject: Re: [PATCH v3 0/5] coresight: syscfg: Extend configfs for config load Message-ID: <20220527163235.GC360589@p14s> References: <20220414064457.12052-1-mike.leach@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220414064457.12052-1-mike.leach@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220527_093242_528643_5A7A8877 X-CRM114-Status: GOOD ( 21.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 14, 2022 at 07:44:52AM +0100, Mike Leach wrote: > This set extends the configfs support to allow loading and unloading of > configurations as binary files via configfs. > > Additional attributes - load and unload are provided to in the > configurations group to implement the load functionality. > > Routines to generate binary configuration files are supplied in > ./tools/coresight. > > Example generator and reader applications are provided. > > Tools may be cross compiled or built for use on host system. > > Documentation is updated to describe feature usage. I think this patchset is looking quite good now. The main issue for now is to know if we want to keep the capability to read and print configurations. To me it doesn't provide much for the quirks it adds, i.e patch 3. James and/or Leo will also have to do a review. As such they should be added, along with Arnaldo, to the next revision. I am done reviewing this set. Thanks, Mathieu > > Changes since v2: > 1) Rebased & tested oo coresight/next - 5.18-rc2 > 2) Moved coresight config generator and reader programs from samples to > tools/coresight. Docs updated to match. (suggested by Mathieu) > 3) userspace builds now use userspace headers from tools/... > 4) Other minor fixes from Mathieu's review. > > Changes since v1: > 1) Rebased to coresight/next - 5.16-rc1 with previous coresight config > set applied. > 2) Makefile.host fixed to default to all target. > > Mike Leach (5): > coresight: configfs: Add in functionality for load via configfs > coresight: configfs: Add in binary attributes to load files > coresight: configfs: Modify config files to allow userspace use > coresight: tools: Add config file write and reader tools > Documentation: coresight: docs for config load via configfs > > .../trace/coresight/coresight-config.rst | 166 +++++- > MAINTAINERS | 2 + > drivers/hwtracing/coresight/Makefile | 2 +- > .../coresight/coresight-config-file.c | 475 ++++++++++++++++++ > .../coresight/coresight-config-file.h | 126 +++++ > .../hwtracing/coresight/coresight-config.h | 27 + > .../coresight/coresight-syscfg-configfs.c | 91 ++++ > .../hwtracing/coresight/coresight-syscfg.c | 37 ++ > .../hwtracing/coresight/coresight-syscfg.h | 2 + > tools/coresight/Makefile | 51 ++ > tools/coresight/coresight-cfg-bufw.c | 303 +++++++++++ > tools/coresight/coresight-cfg-bufw.h | 26 + > tools/coresight/coresight-cfg-example1.c | 65 +++ > tools/coresight/coresight-cfg-examples.h | 27 + > tools/coresight/coresight-cfg-file-read.c | 197 ++++++++ > tools/coresight/coresight-cfg-filegen.c | 58 +++ > tools/include/uapi/coresight-config-uapi.h | 76 +++ > 17 files changed, 1724 insertions(+), 7 deletions(-) > create mode 100644 drivers/hwtracing/coresight/coresight-config-file.c > create mode 100644 drivers/hwtracing/coresight/coresight-config-file.h > create mode 100644 tools/coresight/Makefile > create mode 100644 tools/coresight/coresight-cfg-bufw.c > create mode 100644 tools/coresight/coresight-cfg-bufw.h > create mode 100644 tools/coresight/coresight-cfg-example1.c > create mode 100644 tools/coresight/coresight-cfg-examples.h > create mode 100644 tools/coresight/coresight-cfg-file-read.c > create mode 100644 tools/coresight/coresight-cfg-filegen.c > create mode 100644 tools/include/uapi/coresight-config-uapi.h > > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel