From: Maxime Ripard <maxime@cerno.tech>
To: Roman Stratiienko <r.stratiienko@gmail.com>
Cc: wens@csie.org, jernej.skrabec@gmail.com, airlied@linux.ie,
daniel@ffwll.ch, samuel@sholland.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
megi@xff.cz,
Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Subject: Re: [PATCH] drm/sun4i: Fix blend route/enable register corruption for DE2.0/DE3.0
Date: Mon, 30 May 2022 15:22:32 +0200 [thread overview]
Message-ID: <20220530132232.himfp7ubiacbmkpx@penduick> (raw)
In-Reply-To: <20220525115445.93500-1-roman.o.stratiienko@globallogic.com>
Hi Roman,
On Wed, May 25, 2022 at 11:54:45AM +0000, Roman Stratiienko wrote:
> By this commit 2 related issues are solved:
>
> Issue #1. Corruption in blend route/enable register:
>
> Register corruption happens after using old_state->zpos to disable layer
> state. Blend route/enable registers are shared with other layers
> and other layers may have already assigned this PIPE to valid value.
>
> Solution: Do not use old_state->zpos to disable the plane pipe in
> blend registers.
>
> Issue #2. Remove disabled layer from blend route/enable registers:
>
> Since sun4i/drm are using normalized_zpos, .atomic_update() will setup
> blend route/enable pipes starting from PIPE0 to PIPEX, where X+1 is a
> number of layers used by the CRTC in this frame.
>
> Remaining pipes (PIPE[X+1] - PIPE[MAX]) can have old data that MUST be
> updated.
>
> new_state->normalized_zpos can't be used, since drm helpers won't update
> it for disabled planes.
>
> Solution:
>
> 1. Track the number of total used planes for crtc.
> 2. Use this number instead of zpos to disable unused blend pipes.
>
> Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
If there's two issues, and two solutions, it should be two patches.
Maxime
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-30 13:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 11:54 [PATCH] drm/sun4i: Fix blend route/enable register corruption for DE2.0/DE3.0 Roman Stratiienko
2022-05-30 13:22 ` Maxime Ripard [this message]
2022-05-30 13:45 ` Roman Stratiienko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220530132232.himfp7ubiacbmkpx@penduick \
--to=maxime@cerno.tech \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=megi@xff.cz \
--cc=r.stratiienko@gmail.com \
--cc=roman.o.stratiienko@globallogic.com \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox