From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0539EC433FE for ; Tue, 31 May 2022 14:12:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Mm6w6YVDpXwakZ+YSjsE8tkzrOPeu2wEe4aHfKmWdWI=; b=mK9f0oRL32vBWx YV+wu/Ra3FRcGs/GpD+ydFTJ76xxDkHdwQ7gv0MpYINpOMlBTbPYPwOm5DTFo+AAy5GeVFOCwiAYk roEGJeQ2BJZbk8ZyFpV6PYZt4dBs80uoF6wnd1NWYaXss9V5FzU6LtXY4YdNZ6v8QTKP98UCA868K fisvCV4jPDQfgoPzcBY/zXg2LuTrc0f78YWG1jmVrB7vw4sNP47SOJDLuLXuOyDpEYab7HcMqo19I wpB85x4wLacB7EIEjiCOFensR1tkr++8/rQQYPL4AF5YwharbynRXO3URrpJcSpciYdqHggvfqIJH WRoCHCtIqm7FnFoR9FJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nw2av-00BEDd-GW; Tue, 31 May 2022 14:11:37 +0000 Received: from mga11.intel.com ([192.55.52.93]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nw2ak-00BE9k-DB for linux-arm-kernel@lists.infradead.org; Tue, 31 May 2022 14:11:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654006286; x=1685542286; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=K2Sm7KR4WlYANKzzxvSs11cMHFq39jJccsP/ycyK3bY=; b=iur11Y9mLdJfTiBSZzK/r8fGN1zBdu+/H3UK8+PoxeuGt8H8kqH0yhLn fEznqsMFuXDtx091/RrYH6Jvakx5/wLWlZwKj29XKnNXFLDQnBzz78SwT OYNtp9CKwFa9foDHBGlIMVZBH1GODl7VtA7wisRd0N+ZTFIQj7VP+aao5 dPgUeHG+ng6wVXJMy95iFFVrN418YLpu5P0wEH1F49GkHd+dQeK40M2Ug SPxHDU5IOLcuhYlqhlJ/rvQgvvFNtBM2LccPmURVRjgZod/QKLymBJAww NS7ZViyPB1zv6BUZ9Ow0PGad/fHUzyJxY3EwmIDnQb67UOQ06QxmTW1dQ Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10364"; a="272831555" X-IronPort-AV: E=Sophos;i="5.91,265,1647327600"; d="scan'208";a="272831555" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2022 07:11:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,265,1647327600"; d="scan'208";a="562335391" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga002.jf.intel.com with ESMTP; 31 May 2022 07:11:20 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 5C9E2165; Tue, 31 May 2022 17:11:22 +0300 (EEST) From: Andy Shevchenko To: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Jonathan Cameron , Lars-Peter Clausen , Michal Simek , Andy Shevchenko Subject: [PATCH v1 2/2] iio: adc: xilinx-xadc: Drop duplicate NULL check in xadc_parse_dt() Date: Tue, 31 May 2022 17:11:18 +0300 Message-Id: <20220531141118.64540-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220531141118.64540-1-andriy.shevchenko@linux.intel.com> References: <20220531141118.64540-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220531_071126_500884_040EA0E8 X-CRM114-Status: GOOD ( 14.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The fwnode_for_each_child_node() is NULL-aware, no need to check its parameters outside. Drop duplicate NULL check in xadc_parse_dt(). Signed-off-by: Andy Shevchenko --- drivers/iio/adc/xilinx-xadc-core.c | 38 ++++++++++++++---------------- 1 file changed, 18 insertions(+), 20 deletions(-) diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c index e883f95f0cda..1b247722ba25 100644 --- a/drivers/iio/adc/xilinx-xadc-core.c +++ b/drivers/iio/adc/xilinx-xadc-core.c @@ -1247,30 +1247,28 @@ static int xadc_parse_dt(struct iio_dev *indio_dev, unsigned int *conf, int irq) chan = &channels[9]; chan_node = device_get_named_child_node(dev, "xlnx,channels"); - if (chan_node) { - fwnode_for_each_child_node(chan_node, child) { - if (num_channels >= max_channels) { - fwnode_handle_put(child); - break; - } + fwnode_for_each_child_node(chan_node, child) { + if (num_channels >= max_channels) { + fwnode_handle_put(child); + break; + } - ret = fwnode_property_read_u32(child, "reg", ®); - if (ret || reg > 16) - continue; + ret = fwnode_property_read_u32(child, "reg", ®); + if (ret || reg > 16) + continue; - if (fwnode_property_read_bool(child, "xlnx,bipolar")) - chan->scan_type.sign = 's'; + if (fwnode_property_read_bool(child, "xlnx,bipolar")) + chan->scan_type.sign = 's'; - if (reg == 0) { - chan->scan_index = 11; - chan->address = XADC_REG_VPVN; - } else { - chan->scan_index = 15 + reg; - chan->address = XADC_REG_VAUX(reg - 1); - } - num_channels++; - chan++; + if (reg == 0) { + chan->scan_index = 11; + chan->address = XADC_REG_VPVN; + } else { + chan->scan_index = 15 + reg; + chan->address = XADC_REG_VAUX(reg - 1); } + num_channels++; + chan++; } fwnode_handle_put(chan_node); -- 2.35.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel