* [PATCH] ARM: mxs: Fix refcount leak in mxs_machine_init
@ 2022-06-03 12:03 Miaoqian Lin
0 siblings, 0 replies; 2+ messages in thread
From: Miaoqian Lin @ 2022-06-03 12:03 UTC (permalink / raw)
To: Russell King, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Miaoqian Lin, linux-arm-kernel,
linux-kernel
of_find_node_by_path() returns remote device nodepointer with
refcount incremented, we should use of_node_put() on it when done.
Add missing of_node_put() to avoid refcount leak.
Fixes: format:2046338dcbc6 ("ARM: mxs: Use soc bus infrastructure")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
arch/arm/mach-mxs/mach-mxs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-mxs/mach-mxs.c b/arch/arm/mach-mxs/mach-mxs.c
index 25c9d184fa4c..7d957cadd3e9 100644
--- a/arch/arm/mach-mxs/mach-mxs.c
+++ b/arch/arm/mach-mxs/mach-mxs.c
@@ -393,6 +393,7 @@ static void __init mxs_machine_init(void)
root = of_find_node_by_path("/");
ret = of_property_read_string(root, "model", &soc_dev_attr->machine);
+ of_node_put(root);
if (ret)
return;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] ARM: mxs: Fix refcount leak in mxs_machine_init
@ 2022-06-03 12:19 Miaoqian Lin
0 siblings, 0 replies; 2+ messages in thread
From: Miaoqian Lin @ 2022-06-03 12:19 UTC (permalink / raw)
To: Russell King, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Miaoqian Lin, linux-arm-kernel,
linux-kernel
of_find_node_by_path() returns remote device nodepointer with
refcount incremented, we should use of_node_put() on it when done.
Add missing of_node_put() to avoid refcount leak.
Fixes: 2046338dcbc6 ("ARM: mxs: Use soc bus infrastructure")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
changes in v2:
- update Fixes tag.
v1 Link: https://lore.kernel.org/r/20220603120314.15488-1-linmq006@gmail.com
---
arch/arm/mach-mxs/mach-mxs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-mxs/mach-mxs.c b/arch/arm/mach-mxs/mach-mxs.c
index 25c9d184fa4c..7d957cadd3e9 100644
--- a/arch/arm/mach-mxs/mach-mxs.c
+++ b/arch/arm/mach-mxs/mach-mxs.c
@@ -393,6 +393,7 @@ static void __init mxs_machine_init(void)
root = of_find_node_by_path("/");
ret = of_property_read_string(root, "model", &soc_dev_attr->machine);
+ of_node_put(root);
if (ret)
return;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-03 12:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-03 12:03 [PATCH] ARM: mxs: Fix refcount leak in mxs_machine_init Miaoqian Lin
-- strict thread matches above, loose matches on Subject: below --
2022-06-03 12:19 Miaoqian Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).