* [PATCH] usb: ohci-nxp: Fix refcount leak in ohci_hcd_nxp_probe
@ 2022-06-03 14:12 Miaoqian Lin
2022-06-03 14:44 ` Alan Stern
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2022-06-03 14:12 UTC (permalink / raw)
To: Vladimir Zapolskiy, Alan Stern, Greg Kroah-Hartman, Roland Stigge,
Arnd Bergmann, linux-arm-kernel, linux-usb, linux-kernel
Cc: linmq006
of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
Fixes: 73108aa90cbf ("USB: ohci-nxp: Use isp1301 driver")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/usb/host/ohci-nxp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c
index 85878e8ad331..106a6bcefb08 100644
--- a/drivers/usb/host/ohci-nxp.c
+++ b/drivers/usb/host/ohci-nxp.c
@@ -164,6 +164,7 @@ static int ohci_hcd_nxp_probe(struct platform_device *pdev)
}
isp1301_i2c_client = isp1301_get_client(isp1301_node);
+ of_node_put(isp1301_node);
if (!isp1301_i2c_client)
return -EPROBE_DEFER;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] usb: ohci-nxp: Fix refcount leak in ohci_hcd_nxp_probe
2022-06-03 14:12 [PATCH] usb: ohci-nxp: Fix refcount leak in ohci_hcd_nxp_probe Miaoqian Lin
@ 2022-06-03 14:44 ` Alan Stern
0 siblings, 0 replies; 2+ messages in thread
From: Alan Stern @ 2022-06-03 14:44 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Vladimir Zapolskiy, Greg Kroah-Hartman, Roland Stigge,
Arnd Bergmann, linux-arm-kernel, linux-usb, linux-kernel
On Fri, Jun 03, 2022 at 06:12:30PM +0400, Miaoqian Lin wrote:
> of_parse_phandle() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 73108aa90cbf ("USB: ohci-nxp: Use isp1301 driver")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
Acked-by: Alan Stern <stern@rowland.harvard.edu>
> drivers/usb/host/ohci-nxp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c
> index 85878e8ad331..106a6bcefb08 100644
> --- a/drivers/usb/host/ohci-nxp.c
> +++ b/drivers/usb/host/ohci-nxp.c
> @@ -164,6 +164,7 @@ static int ohci_hcd_nxp_probe(struct platform_device *pdev)
> }
>
> isp1301_i2c_client = isp1301_get_client(isp1301_node);
> + of_node_put(isp1301_node);
> if (!isp1301_i2c_client)
> return -EPROBE_DEFER;
>
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-03 14:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-03 14:12 [PATCH] usb: ohci-nxp: Fix refcount leak in ohci_hcd_nxp_probe Miaoqian Lin
2022-06-03 14:44 ` Alan Stern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).