From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"André Gustavo Nakagomi Lopez" <andregnl@usp.br>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Vladimir Zapolskiy" <vz@mleia.com>
Subject: Re: [PATCH v1 1/1] iio: adc: lpc18xx_adc: Switch from of headers to mod_devicetable.h
Date: Fri, 3 Jun 2022 18:26:28 +0100 [thread overview]
Message-ID: <20220603182628.36f3a170@jic23-huawei> (raw)
In-Reply-To: <20220531212218.72189-1-andriy.shevchenko@linux.intel.com>
On Wed, 1 Jun 2022 00:22:18 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> There is nothing directly using of specific interfaces in this driver,
> so lets not include the headers.
>
> While at it, drop dependency to OF, which currently makes no sense.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied
> ---
> drivers/iio/adc/Kconfig | 2 +-
> drivers/iio/adc/lpc18xx_adc.c | 3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 448ae243cd31..b9e913e25a5d 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -562,7 +562,7 @@ config LP8788_ADC
> config LPC18XX_ADC
> tristate "NXP LPC18xx ADC driver"
> depends on ARCH_LPC18XX || COMPILE_TEST
> - depends on OF && HAS_IOMEM
> + depends on HAS_IOMEM
> help
> Say yes here to build support for NXP LPC18XX ADC.
>
> diff --git a/drivers/iio/adc/lpc18xx_adc.c b/drivers/iio/adc/lpc18xx_adc.c
> index ae9c9384f23e..42e6cd6fa6f7 100644
> --- a/drivers/iio/adc/lpc18xx_adc.c
> +++ b/drivers/iio/adc/lpc18xx_adc.c
> @@ -17,10 +17,9 @@
> #include <linux/iio/driver.h>
> #include <linux/io.h>
> #include <linux/iopoll.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/module.h>
> #include <linux/mutex.h>
> -#include <linux/of.h>
> -#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/regulator/consumer.h>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-06-03 17:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 21:22 [PATCH v1 1/1] iio: adc: lpc18xx_adc: Switch from of headers to mod_devicetable.h Andy Shevchenko
2022-06-03 17:26 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220603182628.36f3a170@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=andregnl@usp.br \
--cc=andriy.shevchenko@linux.intel.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox