From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B28C1C43334 for ; Mon, 6 Jun 2022 06:32:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XDuw2zUBrwQUAYTWCULD+iAkFYpVgl0MtzwgsYryQwA=; b=CGbwv8sSjL9xcI zvGMY9G2pPTncjaHVY7lNImDdXDoBxuiqr5cbtPYoUmXi+Svz+ckQ/9alGCcH/9aDaRW2EQa0mCEf 19W87VGJkH5HthTSs2YIR4pj1mkMn1iG8KeXGA8Rb6Ky0kn9j2J27nKbNur77PslBX7DVmeENPXI0 yaTQOIVsJBNOvIdnqq9ShVukQplMVIDsiYYUu1cq3uzz0JuJQWiHt5aDpboz1zYVpKCHl0kg+vDp9 j314BQmK7GznDtLgLyAXpxva6wb2DHAyV5VVhJEwZwcYkx/DbCrkSluiF6imOs5N9EUD95ltpJt6I HLIkFksHq10II95dc+Jw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ny6GW-00HIxU-B6; Mon, 06 Jun 2022 06:31:04 +0000 Received: from mga06b.intel.com ([134.134.136.31] helo=mga06.intel.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ny6GT-00H8CN-9S for linux-arm-kernel@lists.infradead.org; Mon, 06 Jun 2022 06:31:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654497061; x=1686033061; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=wdDYJ5XqGQgotDlH0rFCdHOAVHtDqbqcv/4oCjtcY4I=; b=Iz67/PEcjp9vDjPeT5Lyf9/QqsEUaVCuClPS7xYM+cLlDqy4zBFp8Mar qRWiPONKQsPGsEOINnVeiiCjG4opVAXqtq2jgwbw+89N2uNGOQZ25nAfn vDbKhOKa3b5M5nZ+EnDj8A0if4wloFW4jeRJIRyCZMYPIsfGBZFnbenz4 fK3P8hgeqNTYEYUMPM3z1G2Jw/kQnEE1JStIAee1148GTjrEpSHGfHJ/u A+ueMgw48vSylfGDG8UTjT3NBiM01FP43M1IhjsT1MYTvjIvabJP8TVhg jQdhn91CeQ2IiOD71FUaXsueyU0CWkT+p8N7SnzSHD3/7fwBztIfAqXpf A==; X-IronPort-AV: E=McAfee;i="6400,9594,10369"; a="337430131" X-IronPort-AV: E=Sophos;i="5.91,280,1647327600"; d="scan'208";a="337430131" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2022 23:26:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,280,1647327600"; d="scan'208";a="532005010" Received: from linux.intel.com ([10.54.29.200]) by orsmga003.jf.intel.com with ESMTP; 05 Jun 2022 23:26:56 -0700 Received: from linux.intel.com (vwong3-iLBPG3.png.intel.com [10.88.229.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 953F658068A; Sun, 5 Jun 2022 23:26:53 -0700 (PDT) Date: Mon, 6 Jun 2022 14:26:50 +0800 From: Wong Vee Khee To: Christophe JAILLET Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] stmmac: intel: Fix an error handling path in intel_eth_pci_probe() Message-ID: <20220606062650.GA31937@linux.intel.com> References: <1ac9b6787b0db83b0095711882c55c77c8ea8da0.1654462241.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1ac9b6787b0db83b0095711882c55c77c8ea8da0.1654462241.git.christophe.jaillet@wanadoo.fr> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220605_233101_421958_9D10B35C X-CRM114-Status: GOOD ( 16.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jun 05, 2022 at 10:50:48PM +0200, Christophe JAILLET wrote: > When the managed API is used, there is no need to explicitly call > pci_free_irq_vectors(). > > This looks to be a left-over from the commit in the Fixes tag. Only the > .remove() function had been updated. > > So remove this unused function call and update goto label accordingly. > > Fixes: 8accc467758e ("stmmac: intel: use managed PCI function on probe and resume") > Signed-off-by: Christophe JAILLET > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > LGTM Reviewed-by: Wong Vee Khee _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel