From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 985D6C433EF for ; Mon, 6 Jun 2022 09:21:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rmMsFqAAeO8knnzeXe55ckPtX5Fhu33dzGxiBWSw8Nc=; b=lbQWmHpL0T4iw0HLZYn3ITGS9T IREcgRG7cqHg6ZTnD6712cDyr7pLZWMXLWgXCDrsWU0P9JT77ByPweSzwfg5SV5J4NherLjHa9a5Q gVBhrlXkOAsGxZ4DfI6jcaNV2GPT9n+1ISIgcfkiM8zHJdd2W4RdFI7vOBhAcZWLdbmVKWtq6YIWB VFh2yywW0UX8CZwdp2bZq8JN6l78b2HGtedKV1oV8yu/z9FpprpvIRUqCtDJ3VLYDU1lBhI61aZJO rQTZAiYG30EF+J79iUkisFvsFetTj8e94gPHPj3JGaSC7NmLBMSY0aMi9JMmRcXvqt3S9gfKX7x63 OPk925uQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ny8uJ-000LyW-18; Mon, 06 Jun 2022 09:20:19 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ny8uE-000Lwn-CZ for linux-arm-kernel@lists.infradead.org; Mon, 06 Jun 2022 09:20:17 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 84DB23200937; Mon, 6 Jun 2022 05:20:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 06 Jun 2022 05:20:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1654507210; x=1654593610; bh=z7m5NyH/mE vLKqvSJdYSlrspdh+MTs/yya0ru7N26FY=; b=af+rpan26X8+Yun8w57p1riCh5 XUOlCx56kJEYEI2JWRfItLpwywDedqvdz376qX3rnPE1zUW0cE8bJ5jYBaGTwAzR jH8hbYgtKFPqkUPdalQYDIdo902sdGosO2tQo7E5Cx1KfdHPCcvfuDVGupXG0okf g4Peqt5vSUym4/fTccalRwVUwdIa8sGqZK5GyhnBoLvAdo04EaMETZS8FBT+Xlu5 Z/hrluyL8cUUp5wCwiV8ZNceWuPxv01NjCjn/BYwFxre1eJgGq/zDQTj7PG9WbFH 5lbhpOQQ7SMWE0HmnCo7aA+C3uiigXARV4DpYas6jexJQL8w2O6/zhPlJIIA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1654507210; x=1654593610; bh=z7m5NyH/mEvLKqvSJdYSlrspdh+M Ts/yya0ru7N26FY=; b=sbrGXNTxR5TdfVd9XeOtKLJTIcRoRlVQ8qFspvubS26F HAalrbos69dp2KTHPA35dFYv4VGyqyMvTsuRWF79eIxQ1K8G7LrdTJRkaaovl+IJ k6R+jmn/1dmeEzK0kHwHxHNqaSir+bco42FTjRWL0XkkLh23VKp7RXFnZi1SIlXP iskVPwcKfPz2e3JzqYMiNhQ5laCSbRBjnY53YfSIrvCGlTU/zf9vCKrA4BgD8Ak+ giBzZ58DfkKib9PrnTOma3OAs3s/FZA4ts2Da9AoZvgpG1G97a6BVKeCZvVUgfmr iRoU1QyZr1G8zFbL/1e3AdkkjIBFbvDoA4aCkNU5aQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedruddtvddgudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeejgeeiveevvdfgffeftdevuefhheduveejieefgeejveeuhfetkeelgfev teefffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Jun 2022 05:20:08 -0400 (EDT) Date: Mon, 6 Jun 2022 11:20:06 +0200 From: Maxime Ripard To: Roman Stratiienko Cc: Jernej =?utf-8?Q?=C5=A0krabec?= , wens@csie.org, airlied@linux.ie, Daniel Vetter , Samuel Holland , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, megi@xff.cz, Roman Stratiienko Subject: Re: [PATCH] drm/sun4i: sun8i: Add support for pixel blend mode property Message-ID: <20220606092006.4bgxibmayv44juox@houat> References: <20220605154731.17362-1-roman.o.stratiienko@globallogic.com> <4714286.GXAFRqVoOG@jernej-laptop> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220606_022014_518984_A5DD6614 X-CRM114-Status: GOOD ( 18.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3477921183106069062==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3477921183106069062== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xv3a7fv5iml6x7mx" Content-Disposition: inline --xv3a7fv5iml6x7mx Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 06, 2022 at 11:17:20AM +0300, Roman Stratiienko wrote: > Hello Jernej, >=20 > Thank you for having a look. >=20 > =D0=B2=D1=81, 5 =D0=B8=D1=8E=D0=BD. 2022 =D0=B3. =D0=B2 23:37, Jernej =C5= =A0krabec : > > > > Dne nedelja, 05. junij 2022 ob 17:47:31 CEST je Roman Stratiienko napis= al(a): > > > Allwinner DE2 and DE3 hardware support 3 pixel blend modes: > > > "None", "Pre-multiplied", "Coverage" > > > > > > Add the blend mode property and route it to the appropriate registers. > > > > > > Note: > > > "force_premulti" parameter was added to handle multi-overlay channel > > > cases in future changes. It must be set to true for cases when more > > > than 1 overlay layer is used within a channel and at least one of the > > > overlay layers within a group uses premultiplied blending mode. > > > > Please remove this parameter. It's nothing special, so it can be easily= added > > once it's actually needed. For now, it only complicates code. >=20 > I would prefer keeping it if you do not have any strong opinion against i= t. >=20 > I am working now on exposing all overlays, so it will be needed soon anyw= ay. KMS assumes pre-multiplied alpha anyway, so we shouldn't need a parameter to force it: we're always going to force it. > Also it helps to better understand the COV2PREMULT mode which has not > the best description in the datasheet. Only after testing this > register using devmem I became confident on its purpose. Sounds like a good job for a comment in the source code. Maxime --xv3a7fv5iml6x7mx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYp3GxgAKCRDj7w1vZxhR xeljAP9mEJgJMfjtVvkdDxEKuUW2ug6RTtPkaaitLKaDGcVC6QD/dXp7EEhjGu1b XDV2tbEGEJAHonQrLQMqo8eOo3pFZA0= =8iFG -----END PGP SIGNATURE----- --xv3a7fv5iml6x7mx-- --===============3477921183106069062== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3477921183106069062==--