From: Sudeep Holla <sudeep.holla@arm.com>
To: Claudiu.Beznea@microchip.com
Cc: linmq006@gmail.com, alexandre.belloni@bootlin.com,
linux-kernel@vger.kernel.org, Mihai.Sain@microchip.com,
Sudeep Holla <sudeep.holla@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drivers: soc: atmel: Fix refcount leak in atmel_soc_device_init
Date: Mon, 6 Jun 2022 10:22:16 +0100 [thread overview]
Message-ID: <20220606092216.5s54nzplpsiyj3bv@bogus> (raw)
In-Reply-To: <48c19453-984b-c3ae-b62b-2f0455330084@microchip.com>
On Mon, Jun 06, 2022 at 09:00:52AM +0000, Claudiu.Beznea@microchip.com wrote:
> On 05.06.2022 11:40, Miaoqian Lin wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > of_find_node_by_path() returns a node pointer with refcount incremented,
> > we should use of_node_put() on it when not need anymore.
> > Add missing of_node_put() to avoid refcount leak.
> >
> > Fixes: 960ddf70cc11 ("drivers: soc: atmel: Avoid calling at91_soc_init on non AT91 SoCs")
> > Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> > ---
> > drivers/soc/atmel/soc.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c
> > index b2d365ae0282..46dfa24c52fb 100644
> > --- a/drivers/soc/atmel/soc.c
> > +++ b/drivers/soc/atmel/soc.c
> > @@ -369,10 +369,13 @@ static int __init atmel_soc_device_init(void)
> > {
> > struct device_node *np = of_find_node_by_path("/");
> >
>
> What about having it like this:
> const struct of_device_id *of_id;
>
> of_id = of_match_node(at91_soc_allowed_list, np);
> of_node_put(np);
+1, I was about to make similar suggestion in couple of other patches making
similar changes.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-06-06 9:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-05 8:40 [PATCH] drivers: soc: atmel: Fix refcount leak in atmel_soc_device_init Miaoqian Lin
2022-06-06 9:00 ` Claudiu.Beznea
2022-06-06 9:22 ` Sudeep Holla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220606092216.5s54nzplpsiyj3bv@bogus \
--to=sudeep.holla@arm.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Mihai.Sain@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linmq006@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox