From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FD00C43334 for ; Mon, 6 Jun 2022 09:23:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hN6VxL2TDgX7Gz0m1r2sfSeR5WcAcOANo6siuMV0QDQ=; b=aJ8PV1OL/rGFRdye+Kac0q1LjP HEI3enDVmv3MWG753lgPjYVh2b2wlZGT7tnG+wMXRn00Jxth76MzBAeNrbhOEiUTJ9Um59gBokUJB RIw1d3SB9z4vR4/Ivx3oOzEb7cT330H3UUVNcidPhsGsl12QQKit6gkgI2H6ZPJhkeqyQaLmXSoM4 ZCpZ3T1KjBMfVlBPqLSlWiWGKsAru7r1EYkBenLCQIYCq5oKg5ZcWnDF+/W72R3/2ekx0try83jnM U7lDvv3EBTF/IcDUy1xD++PkGb+oEdyZ5jmFJwlO/eDb8LVfUjgjX5aRfQvx7u0jCtN++FEhJZKlI hDdAACRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ny8wT-000MwK-Tk; Mon, 06 Jun 2022 09:22:34 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ny8wQ-000Muv-B9 for linux-arm-kernel@lists.infradead.org; Mon, 06 Jun 2022 09:22:31 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 93D2132002FB; Mon, 6 Jun 2022 05:22:28 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 06 Jun 2022 05:22:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1654507348; x=1654593748; bh=Xw4lnTY/et JsJAGDFGc3jcxrakgTZHGFztPy9C0RzDM=; b=qxiiLfWULeAPQo8wYKlgqESjFG 6TGaZfecQYvAdffjoLWu9YG0TrJovLyO7ylqUihe6F61QahAqc0BAVqRy4Ucxxy4 DrxmKAJLMzMOgbfXVoP+AHuvh6QztQtYmBw4ibyH0LST0wlJmazaMMxuzMvSoMta s3YBZb5JA644H4gnTon7TvG0pEfMZV9xrjpkm9Fh5FlMYGpn3gpkemo5Yyq+KG2a LlhxrUovfCmLEph0pA7McLE9e/u+JYiDvoyXB723FRFYjBvXw6hEHQpzrDaGkgeo kittXLPBx1KAA5i5K9YN2Y0eVrcEGROCfDa21n8f+jMnK1plVMDohSYuZlDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1654507348; x=1654593748; bh=Xw4lnTY/etJsJAGDFGc3jcxrakgT ZHGFztPy9C0RzDM=; b=PEwqST23OMlAUNHFqMxHnAJfKU40BvEfscyGrQViseSX px/VVlVaH+85i1wn8bN9DA7pxQX5/Rxm5Zmo/ntfQmPFTukTpi+NRnAX23o72TF7 V5KBmBp5lnVpSAoYMAIQP4CCa0XL9IhN2Sg5yPHxMzUheZ50BpYNaZwKXLw3TRaY TatwtKg9n/tMw8K4WTrtjSx4mQPhRPBSpekrPd+o9PdJ31SSjUsTWQQAn34Wq4Fg 3ph9Q0957ns9Xr+D4pChkbEj8qG/pzqR8cC4c4tuZpOy9lGyxyjLnLIQKjlfA86L xz32lzWRe/283rcsK4w7GAZCkCsNYQ1UvgN0yUkovA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedruddtvddgudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeejgeeiveevvdfgffeftdevuefhheduveejieefgeejveeuhfetkeelgfev teefffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Jun 2022 05:22:26 -0400 (EDT) Date: Mon, 6 Jun 2022 11:22:25 +0200 From: Maxime Ripard To: Roman Stratiienko Cc: Jernej =?utf-8?Q?=C5=A0krabec?= , wens@csie.org, airlied@linux.ie, Daniel Vetter , Samuel Holland , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, megi@xff.cz, Roman Stratiienko Subject: Re: [PATCH] drm/sun4i: sun8i: Add support for pixel blend mode property Message-ID: <20220606092225.yxyw77mtuqpbmd35@houat> References: <20220605154731.17362-1-roman.o.stratiienko@globallogic.com> <4714286.GXAFRqVoOG@jernej-laptop> <20220606092006.4bgxibmayv44juox@houat> MIME-Version: 1.0 In-Reply-To: <20220606092006.4bgxibmayv44juox@houat> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220606_022230_440078_AD80E9C8 X-CRM114-Status: GOOD ( 20.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8606718693048410452==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8606718693048410452== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ycmmdvpgrnhgi2cu" Content-Disposition: inline --ycmmdvpgrnhgi2cu Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 06, 2022 at 11:20:06AM +0200, Maxime Ripard wrote: > On Mon, Jun 06, 2022 at 11:17:20AM +0300, Roman Stratiienko wrote: > > Hello Jernej, > >=20 > > Thank you for having a look. > >=20 > > =D0=B2=D1=81, 5 =D0=B8=D1=8E=D0=BD. 2022 =D0=B3. =D0=B2 23:37, Jernej = =C5=A0krabec : > > > > > > Dne nedelja, 05. junij 2022 ob 17:47:31 CEST je Roman Stratiienko nap= isal(a): > > > > Allwinner DE2 and DE3 hardware support 3 pixel blend modes: > > > > "None", "Pre-multiplied", "Coverage" > > > > > > > > Add the blend mode property and route it to the appropriate registe= rs. > > > > > > > > Note: > > > > "force_premulti" parameter was added to handle multi-overlay channel > > > > cases in future changes. It must be set to true for cases when more > > > > than 1 overlay layer is used within a channel and at least one of t= he > > > > overlay layers within a group uses premultiplied blending mode. > > > > > > Please remove this parameter. It's nothing special, so it can be easi= ly added > > > once it's actually needed. For now, it only complicates code. > >=20 > > I would prefer keeping it if you do not have any strong opinion against= it. > >=20 > > I am working now on exposing all overlays, so it will be needed soon an= yway. >=20 > KMS assumes pre-multiplied alpha anyway, so we shouldn't need a > parameter to force it: we're always going to force it. My bad, I got confused with your other patch. Still, I agree with Jernej, if it's not needed it only complicates the code for no particular reason. If you need it at some point in the future, add it then. Otherwise, it's hard to reason about, since we don't know what are the expectations that those future patches will bring. Maxime --ycmmdvpgrnhgi2cu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYp3HUQAKCRDj7w1vZxhR xQ7JAPwOH2WywNctfCg4rbYtCxC02Owlfgb33BXYypx4Py8rtQEAp7OVVf9HelNl uO4X3n7onqZVEW/knsWlXLnynOLuLgo= =oSp3 -----END PGP SIGNATURE----- --ycmmdvpgrnhgi2cu-- --===============8606718693048410452== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8606718693048410452==--