From: Jakub Kicinski <kuba@kernel.org>
To: Chen Lin <chen45464546@163.com>
Cc: nbd@nbd.name, alexander.duyck@gmail.com, john@phrozen.org,
sean.wang@mediatek.com, Mark-MC.Lee@mediatek.com,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
matthias.bgg@gmail.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] net: ethernet: mtk_eth_soc: fix misuse of mem alloc interface netdev[napi]_alloc_frag
Date: Mon, 6 Jun 2022 14:34:37 -0700 [thread overview]
Message-ID: <20220606143437.25397f08@kernel.org> (raw)
In-Reply-To: <1654398757-2937-1-git-send-email-chen45464546@163.com>
On Sun, 5 Jun 2022 11:12:37 +0800 Chen Lin wrote:
> + new_data = (void *)__get_free_pages(GFP_ATOMIC |
> + __GFP_COMP | __GFP_NOWARN,
> + get_order(mtk_max_frag_size(MTK_MAX_LRO_RX_LENGTH)));
Please make this a helper which takes the gfp flags.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-06 21:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 4:10 [PATCH] net: ethernet: mtk_eth_soc: fix misuse of mem alloc interface netdev_alloc_frag Chen Lin
2022-06-03 4:24 ` Jakub Kicinski
2022-06-03 4:30 ` Felix Fietkau
2022-06-03 8:46 ` [PATCH v2] net: ethernet: mtk_eth_soc: fix misuse of mem alloc interface netdev[napi]_alloc_frag Chen Lin
2022-06-03 15:25 ` Alexander Duyck
2022-06-03 15:33 ` Alexander Duyck
2022-06-05 2:22 ` Chen Lin
2022-06-05 3:12 ` [PATCH v3] " Chen Lin
2022-06-06 21:34 ` Jakub Kicinski [this message]
2022-06-06 23:39 ` [PATCH v4] " Chen Lin
2022-06-07 23:14 ` Jakub Kicinski
2022-06-08 12:43 ` Chen Lin
2022-06-08 12:46 ` [PATCH v5] " Chen Lin
2022-06-09 3:50 ` patchwork-bot+netdevbpf
2022-06-03 17:25 ` [PATCH v2] " Eric Dumazet
2022-06-03 18:59 ` Jakub Kicinski
2022-06-03 19:11 ` Eric Dumazet
2022-06-03 19:55 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220606143437.25397f08@kernel.org \
--to=kuba@kernel.org \
--cc=Mark-MC.Lee@mediatek.com \
--cc=alexander.duyck@gmail.com \
--cc=chen45464546@163.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=john@phrozen.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).