From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7FE8C433EF for ; Mon, 6 Jun 2022 14:45:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ncpZbe/wQna+HZby6qPbuonu8Y4xvhLwIbSN8lMb3ms=; b=iQTqKJw4K6y7xN LLJQF0NmVd8t5vk+RcyhVaMQWmep2O/UPHiU+1Xw/RaEzD+joKQfaWanAE4EO9vbWD4XChCYPq+Cm 65f/OUHm16sFJLySi99UtQwYq8mn54Kc+oCg7z8Wjb4DMVY9emSUGd+fkRlSuwIHEUKxHy1O82Zxa Gz3E3LN/zegkh+Kjpf+HA0X3IXfQhXC+OJQ8xdDdqXsOWKtMfHeHaw63G52qwuJxZUJN1QX6x6dFb bXw1GhY5ULhVZbDPVC0d3IlxNzef6mfilhjxUC0DIaVzwHJwII33sWB9entNyU5gktTxbO+IlP6bk H9W8RF+Dn8F0UwCmXyDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyDxX-001a3h-P5; Mon, 06 Jun 2022 14:43:59 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyDxU-001a32-DT; Mon, 06 Jun 2022 14:43:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 198711595; Mon, 6 Jun 2022 07:43:54 -0700 (PDT) Received: from bogus (unknown [10.57.9.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 38C0F3F73B; Mon, 6 Jun 2022 07:43:52 -0700 (PDT) Date: Mon, 6 Jun 2022 15:43:05 +0100 From: Sudeep Holla To: Cristian Marussi Cc: Michael Riesch , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Heiko Stuebner , Liang Chen , Kever Yang , Sudeep Holla , Jeffy Chen , Peter Geis , Nicolas Frattaroli , Etienne Carriere Subject: Re: [PATCH] firmware: arm_scmi: Relax BASE protocol sanity checks on protocol list Message-ID: <20220606144305.agzzyf7c4kp2nwlw@bogus> References: <20220523171559.472112-1-cristian.marussi@arm.com> <45bf11a8-47eb-e088-ba99-30c8788c7143@wolfvision.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220606_074356_544134_48943E7B X-CRM114-Status: GOOD ( 20.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 06, 2022 at 02:31:48PM +0100, Cristian Marussi wrote: > On Mon, Jun 06, 2022 at 02:59:10PM +0200, Michael Riesch wrote: > > Hi Cristian, > > > Hi Michael, > > > On 5/23/22 19:15, Cristian Marussi wrote: > > > Even though malformed replies from firmware must be treated carefully to > > > avoid memory corruption Kernel side, some out-of-spec SCMI replies can > > > be tolerated to avoid breaking existing deployed system, as long as they > > > won't cause memory issues. > > > > > > Reported-by: Nicolas Frattaroli > > > Cc: Etienne Carriere > > > Cc: Sudeep Holla > > > Signed-off-by: Cristian Marussi > > > > Thanks a lot, without this fix the Mali G52 GPU won't probe on my RK3568 > > EVB1 in vanilla v5.19-rc1. > > > > Yes, the break was reported on -next and today it appeared in 5.19-rc1. > A proper FW fix is also up for review by Etienne but in the meantime > this tries to limit damages relaxing a bit the checks. > > > I guess this patch should have a Fixes: tag, right? > > > > It has not a Fixes tag because the issue was introduced in 5.19-rc1 and the > fix will go in with the next round of v5.19 fixes by Sudeep (AFAIU) so it > will be solved within the v5.19 cycle and I thought the Fixes tag was > not needed in this case (I could be wrong...) Correct, if for some reason, we can't push this before v5.19, then fixes tag needs to added. I will add that then, but for now let us target getting it in before v5.19 -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel