From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 291A1CCA473 for ; Mon, 6 Jun 2022 15:12:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UnuC54rF4Zq4ZTerPNzQQiXPqkrhb9o3NKurmd+fVcM=; b=pZ+k029MhQr6q1 733+FxMTZyemyGNPSG9ozojS95BhlEO17LU9bJ8oILEfk1iCWryxTH132XcGDQrhBe+lI+XsPXD8g BGkWhyzxLovK/kNA9SEX/Mjtyx7bZIF3KvMVxQUN35AEa0VjG1/HgPKnziXGVDHpJ8upGQGwE7aEl KFG/QiKG+lMYfSDhPxyzmXsCTHA3ndQ6o72JcI+nsnJaasWgFI6V4pzcU35muXv+eZZCAAWw7sBPn kqxdiciGJHN1J70Q0XGdNXw3W4e0yA3CbXYyZ1eDi6moen+5fe5aIOERFHL/kuUwifhx1J5dZCxhx kWdsLGsEP3VpAuI4x7lg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyENi-001iRW-PS; Mon, 06 Jun 2022 15:11:03 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyENd-001iPc-41; Mon, 06 Jun 2022 15:10:59 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DBAABD6E; Mon, 6 Jun 2022 08:10:54 -0700 (PDT) Received: from bogus (unknown [10.57.9.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 407A13F73B; Mon, 6 Jun 2022 08:10:52 -0700 (PDT) Date: Mon, 6 Jun 2022 16:10:04 +0100 From: Sudeep Holla To: Heiko =?utf-8?Q?St=C3=BCbner?= Cc: Cristian Marussi , Michael Riesch , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Liang Chen , Sudeep Holla , Kever Yang , Jeffy Chen , Peter Geis , Nicolas Frattaroli , Etienne Carriere Subject: Re: [PATCH] firmware: arm_scmi: Relax BASE protocol sanity checks on protocol list Message-ID: <20220606151004.hevt4zh6boypdd4x@bogus> References: <20220523171559.472112-1-cristian.marussi@arm.com> <20220606144305.agzzyf7c4kp2nwlw@bogus> <4402272.LvFx2qVVIh@diego> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4402272.LvFx2qVVIh@diego> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220606_081057_269877_B2DA9BE4 X-CRM114-Status: GOOD ( 30.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 06, 2022 at 04:55:10PM +0200, Heiko St=FCbner wrote: > Am Montag, 6. Juni 2022, 16:43:05 CEST schrieb Sudeep Holla: > > On Mon, Jun 06, 2022 at 02:31:48PM +0100, Cristian Marussi wrote: > > > On Mon, Jun 06, 2022 at 02:59:10PM +0200, Michael Riesch wrote: > > > > Hi Cristian, > > > > > > > Hi Michael, > > > > > > > On 5/23/22 19:15, Cristian Marussi wrote: > > > > > Even though malformed replies from firmware must be treated caref= ully to > > > > > avoid memory corruption Kernel side, some out-of-spec SCMI replie= s can > > > > > be tolerated to avoid breaking existing deployed system, as long = as they > > > > > won't cause memory issues. > > > > > > > > > > Reported-by: Nicolas Frattaroli > > > > > Cc: Etienne Carriere > > > > > Cc: Sudeep Holla > > > > > Signed-off-by: Cristian Marussi > > > > > > > > Thanks a lot, without this fix the Mali G52 GPU won't probe on my R= K3568 > > > > EVB1 in vanilla v5.19-rc1. > > > > > > > > > > Yes, the break was reported on -next and today it appeared in 5.19-rc= 1. > > > A proper FW fix is also up for review by Etienne but in the meantime > > > this tries to limit damages relaxing a bit the checks. > > > > > > > I guess this patch should have a Fixes: tag, right? > > > > > > > > > > It has not a Fixes tag because the issue was introduced in 5.19-rc1 a= nd the > > > fix will go in with the next round of v5.19 fixes by Sudeep (AFAIU) s= o it > > > will be solved within the v5.19 cycle and I thought the Fixes tag was > > > not needed in this case (I could be wrong...) > > = > > Correct, if for some reason, we can't push this before v5.19, then fixes > > tag needs to added. I will add that then, but for now let us target get= ting > > it in before v5.19 > = > hmm, I'd disagree for the generalization. > = > While true that is not 100% necessary to be present in all cases, so > definitly no reason for a new version when applied to the same -rc series, > having the Fixes tag not only clearly marks the patch as such, but also > allows people reading either mailing lists or the later the git history > to actually see where the issue started. So I really think it is a > nice-to-have in most cases. Absolutely agreed in general. But I asked Cristian to not add as we are work around the firmware bug by relaxing the checks in the kernel. This is not fixing anything in the original commit IMO, it is just that the original commit highlighted the firmware issue on that system. -- = Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel