From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D061AC43334 for ; Mon, 6 Jun 2022 16:16:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z+i1t33SN0qxxRNXZ+DvsiFi3GcaylbOX41O5z/u3YE=; b=CkCbAFPaBQUiLy gBt1274/j1lUO9isMfoydn6wFGctODcHTMsZw4HwEkDyzX6jP9Za8HOoGJm4EFMwF3Hi+nZ6GeE17 vdlzjYDnbroMiuYCDVitR0XdEyd7gSjLfIKV000jsFMq4Kxlvc+q1912Zd5yeYiyvK2bp8ARw1PjI C3OyLi/s08QKbUXi6xypSDPieR3PRe7+cow4co7pm5wsgst5ua+NNOZYvuQ5+4/ZoDbc51OYTa6DQ WGcoiT6VVPuRoS6AldMqY5QeK5GALgiMbtYhwQ/FcarUCdbvTgQlp4kjZMoSpWIr0i/hSAwdoF/yB 7uIM47UXST3OQ9aNW/gQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyFO1-001zTo-I0; Mon, 06 Jun 2022 16:15:25 +0000 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyFNy-001zTD-RF for linux-arm-kernel@lists.infradead.org; Mon, 06 Jun 2022 16:15:24 +0000 Received: by mail-pg1-x52c.google.com with SMTP id y187so13294438pgd.3 for ; Mon, 06 Jun 2022 09:15:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Yc3d6f09An5Iup7HnFnq+YmtnLxXizu7JY/ZtB+fmYU=; b=bgidypdYCXahlWg67Jnr4ubl4uJixk0PWYtjDwcs3u5xJE0nvwIFqj7aCjjwNOiMvz 9L9/vq/xwoEPAh3c1EVJpaJc3qB5EvVqnHlAqc+E1Pb4BoPVwJFeuuLsB8kL0Y5NYxY5 +u50F+KOlu6kucbAAaG1q3yMKz27idq5V/1qICzsTjPfWVZ7EgTcgipFTw+mjl3KFKq8 2b9wF1Fbx/jsinj/hE1XcHEW/SqkDw70ZLHnxeAdO5eDdR0DGd3QG5Fbou9J33AI8mrX sDURBwJYta4klrPdDpA4c/LylywEHj9RIBnVv6TKLt4/rgbZq5Qbgx0ciWFgtDIW81D3 Ykrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Yc3d6f09An5Iup7HnFnq+YmtnLxXizu7JY/ZtB+fmYU=; b=EyBS5q5HRV5//Pja3Fjg8Bq0aUXEsyvc5C4Csy2W3PisJGAS0uazSXa5B689/ML6p8 XADrPwPXIJ3so00w5sAA8vcPN60gnJvbeCTflxx7YHyRAKxAJnaz0Xo9qV0ZixXkR6Te DZXNpuWo+PYxXHWvmcrs7VhfTauD+rBvsCWIs2tQnsvLmqebiL2+LKh3HxQQaoM9IRlv WYqz67rGXIJYPrWVe1hI7LUppjTVRHIAhIw7yYkZZYk7YhBpZMt2PHUKg1YJorZdbb6G lbS5lkGn1Du1DBhC2syPdJWi0Ntbp1eu8qyiOO+LKjXiH1ZMd9PgcgF1S5h1uMifTf6u Gnmw== X-Gm-Message-State: AOAM530Y3ti8h/u4ZTIEEmDzsq4q7Xj1TqYfK5oy1Gci+FLTUN5d3o9X dQvuy/3E4PQxYKXNtahbjKpgtQ== X-Google-Smtp-Source: ABdhPJymBlKeJCj3tvmSxgMQ8W96PwRXnOWJMPIgOzJN40d5L4tl9aO20Ei3Hqzfn1EToQYphbdpOg== X-Received: by 2002:a63:e905:0:b0:3fa:ec8c:9013 with SMTP id i5-20020a63e905000000b003faec8c9013mr21525731pgh.599.1654532121881; Mon, 06 Jun 2022 09:15:21 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id s4-20020aa78d44000000b0051c179895a0sm2547571pfe.212.2022.06.06.09.15.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 09:15:20 -0700 (PDT) Date: Mon, 6 Jun 2022 10:15:18 -0600 From: Mathieu Poirier To: Puranjay Mohan Subject: Re: [PATCH v4 0/6] Introduce PRU remoteproc consumer API Message-ID: <20220606161518.GB809345@p14s> References: <20220603121520.13730-1-p-mohan@ti.com> <20220606155612.GA809345@p14s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220606155612.GA809345@p14s> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220606_091522_932374_3A726F9D X-CRM114-Status: GOOD ( 30.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, devicetree@vger.kernel.org, grygorii.strashko@ti.com, vigneshr@ti.com, kishon@ti.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, rogerq@kernel.org, krzysztof.kozlowski+dt@linaro.org, ssantosh@kernel.org, robh@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 06, 2022 at 09:56:12AM -0600, Mathieu Poirier wrote: > I have started to review this set, comments will come over the next few days. I > will clearly inform you when I am done reviewing. This patch is giving me several checkpatch warnings that should have been caught before sending the patches out to the mailing list. As such I will not review this work and seriously considering adding your next revision at the very bottom of my queue. > > Thanks, > Mathieu > > On Fri, Jun 03, 2022 at 05:45:14PM +0530, Puranjay Mohan wrote: > > This is the v4 of the patch series [1]. The v3 had some comments > > on the DT patch that have been addressed here. The 6th patch in this > > series was missed in the previous versions, so, it has been added now. > > > > I have posted two more patch series that depend on this series, one to > > the soc tree and another to the networking tree. I had sent all the 3 > > series, including this one as RFC [2] to get comments and to explain the > > dependencies. > > > > The Programmable Real-Time Unit and Industrial Communication Subsystem > > (PRU-ICSS or simply PRUSS) on various TI SoCs consists of dual 32-bit > > RISC cores (Programmable Real-Time Units, or PRUs) for program execution. > > > > There are 3 foundation components for PRUSS subsystem: the PRUSS platform > > driver, the PRUSS INTC driver and the PRUSS remoteproc driver. All were > > already merged and can be found under: > > 1) drivers/soc/ti/pruss.c > > Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml > > 2) drivers/irqchip/irq-pruss-intc.c > > Documentation/devicetree/bindings/interrupt-controller/ti,pruss-intc.yaml > > 3) drivers/remoteproc/pru_rproc.c > > Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml > > > > The programmable nature of the PRUs provide flexibility to implement custom > > peripheral interfaces, fast real-time responses, or specialized data handling. > > Example of a PRU consumer drivers will be: > > - Software UART over PRUSS > > - PRU-ICSS Ethernet EMAC > > > > In order to make usage of common PRU resources and allow the consumer drivers to > > configure the PRU hardware for specific usage the PRU API is introduced. > > > > [1] https://patchwork.kernel.org/project/linux-remoteproc/cover/20220418104118.12878-1-p-mohan@ti.com/ > > [2] https://patchwork.kernel.org/project/linux-remoteproc/cover/20220406094358.7895-1-p-mohan@ti.com/ > > > > Thanks and Regards, > > Puranjay Mohan > > > > Roger Quadros (1): > > remoteproc: pru: Add pru_rproc_set_ctable() function > > > > Suman Anna (2): > > dt-bindings: remoteproc: Add PRU consumer bindings > > remoteproc: pru: Make sysfs entries read-only for PRU client driven > > boots > > > > Tero Kristo (3): > > remoteproc: pru: Add APIs to get and put the PRU cores > > remoteproc: pru: Configure firmware based on client setup > > remoteproc: pru: add support for configuring GPMUX based on client > > setup > > > > .../bindings/remoteproc/ti,pru-consumer.yaml | 69 +++++ > > drivers/remoteproc/pru_rproc.c | 254 +++++++++++++++++- > > include/linux/pruss.h | 78 ++++++ > > 3 files changed, 396 insertions(+), 5 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml > > create mode 100644 include/linux/pruss.h > > > > -- > > 2.17.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel