Re: [PATCH v2] ARM: initialize jump labels before setup_machine_fdt()

Phil Elwell
2022-06-07T11:05:40Z

Hi Greg,

On 07/06/2022 10:10, Greg KH wrote:
> On Tue, Jun 07, 2022 at 09:47:30AM +0100, Phil Elwell wrote:
>> Hi Jason,
>>
>> On 07/06/2022 09:30, Jason A. Donenfeld wrote:
>>> Hi Phil,
>>>
>>> Thanks for testing this. Can you let me know if v1 of this works?
>>>
>>> https://lore.kernel.org/lkml/20220602212234.344394-1-Jason@zx2c4.com/
>>>
>>> (I'll also fashion a revert for this part of stable.)
>>>
>>> Jason
>>
>> Thanks for the quick response, but that doesn't work for me either. Let me
>> say again that I'm on a downstream kernel (rpi-5.15.y) so this may not be a
>> universal problem, but merging either of these fixing patches would be fatal
>> for us.
>
> I have reports of a "clean" 5.15.45 working just fine on a rpi.
> Anything special in your tree that isn't upstream yet that might be
> conflicting with this? Any chance you can try a kernel.org release
> instead?

A clean 5.15.45 boots cleanly, whereas a downstream kernel shows the static key
warning (but it does go on to boot). The significant difference is that our
defconfigs set CONFIG_RANDOM_TRUST_BOOTLOADER=y - defining that on top of
multi_v7_defconfig demonstrates the issue on a clean 5.15.45. Conversely, not
setting that option in a downstream kernel build avoids the warning, presumably
because it takes much longer to accumulate the required entropy.

Phil