From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23638C433EF for ; Wed, 8 Jun 2022 18:54:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=RwjpaY4X9/lJNW9locTU97N3Sv1jTAunnAimCJJjuAc=; b=BaLagTWfkLk6gu ZbeppzMGmBxW6pC3Ww/KxKM7mVNrZk1bse4yOL2KesQCtUPBTpazMv4k4efS4BmnVIArb4qWl0477 gA28UO4iL1R5kxui+OkmpoHJ/kYT+5cHLdltj7Vyd3+hdDa1FZo1meQSL4l85BHDCIuHqkvGpNEen riWLd+uc+8dplKSUZ+HNDLqF8ITH03mfgiDk+EApxTZHBSz3lwC5sQVjcLL7tpkOr8aO/aTUFZfr+ 3UlYtN3oKtddnAZ+Xk2yaShJDxb8Kz4koO4CUCw5yuP2ynlbuokQZC98c029hu59YUwBUsFmXQDC7 VCFg56N6Q1bmClta1f0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nz0nz-00EifM-Cm; Wed, 08 Jun 2022 18:53:23 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nz0nv-00Eidh-Nd for linux-arm-kernel@lists.infradead.org; Wed, 08 Jun 2022 18:53:21 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A81A861C31; Wed, 8 Jun 2022 18:53:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4613C34116; Wed, 8 Jun 2022 18:53:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654714396; bh=zEZS8wnr96oLeHkF7a5j7Jb1tu3P7t9B5UyyKqQuo5c=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=QyLIK/zSQg/im0iyAEdHqWYH7sSC8snRcCjj5DYxwNgb9bfaSBucn6ZW35l5am89A kyAjv+MjWdOt2dYcwWTPQ1DFaEdzAHL64FQgo4QQqFHJc5mrl5FjtRWD85UiCq1Lc3 RQzO9FOjnPF6OQEzsMDCk7N4XPrqhGE2f+3WV4ud7iqBu2v68VWrQeBgmB1pviGylL /7Q7wEDNa2HmFf5bRk347PQeSndxninI6Uets0th4h68K+S3R2uW5MfVI1aRBYEy3D vy/UnijJgBDp5DbPgSxDMUvTHo6+arkP+0PkfqqLxz1yibN9wbPN0aIFwamLsyrpXm vtRlAMN1j/5Fg== Date: Wed, 8 Jun 2022 13:53:13 -0500 From: Bjorn Helgaas To: Richard Zhu Cc: l.stach@pengutronix.de, bhelgaas@google.com, robh+dt@kernel.org, broonie@kernel.org, lorenzo.pieralisi@arm.com, jingoohan1@gmail.com, festevam@gmail.com, francesco.dolcini@toradex.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Subject: Re: [PATCH v9 2/8] PCI: imx6: Add the error propagation from host_init Message-ID: <20220608185313.GA410761@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1651801629-30223-3-git-send-email-hongxing.zhu@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220608_115319_850465_F0379801 X-CRM114-Status: GOOD ( 13.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 06, 2022 at 09:47:03AM +0800, Richard Zhu wrote: > Since there is error return check of the host_init callback, add error > check to imx6_pcie_deassert_core_reset() function, and change the > function type accordingly. > @@ -878,11 +879,18 @@ static int imx6_pcie_start_link(struct dw_pcie *pci) > static int imx6_pcie_host_init(struct pcie_port *pp) > { > struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > + struct device *dev = pci->dev; > struct imx6_pcie *imx6_pcie = to_imx6_pcie(pci); > + int ret; > > imx6_pcie_assert_core_reset(imx6_pcie); > imx6_pcie_init_phy(imx6_pcie); > - imx6_pcie_deassert_core_reset(imx6_pcie); > + ret = imx6_pcie_deassert_core_reset(imx6_pcie); > + if (ret < 0) { > + dev_err(dev, "pcie host init failed: %d.\n", ret); Other messages from this driver do not include a trailing period. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel