From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BEEA9C43334 for ; Wed, 8 Jun 2022 18:59:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=TbyHoNDHYm5J1ARpfJLrpecZ6KTcKeynzEt79LyXMic=; b=oFbLv5Wd25TPCd OmegnXzng0mhr493B00L/6FQm9kciXuk51mT0E8x5cGk9mEB3jKCtYPbQ2X8DaAntwSue7d9q4WQc FxuEXDlJhMbZIJZKB1bAuCW7JMQxtcvhFOH3D8CJGfM+Ii5i6prGwpVR6wYwdzssOADf92peYZ1wV 3RHZ1cEiFlcHYv9IkU5TMhp94M0AuD1qAVNTruzoHV8rs+Zx2rC5m2ANWrsN95bg9ebcqoJsQR3PE 6MSHG0hH1RUgakvJ62CBrSc0Ke0VBHBtJ8m59nXU7IXGiyJISXlOcIzy+O4uJ9WDeU80JnAZpe6Bj E8IeDu9s3ab7aGv3c7Fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nz0sT-00Ejr1-GW; Wed, 08 Jun 2022 18:58:01 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nz0sQ-00Ejpo-02 for linux-arm-kernel@lists.infradead.org; Wed, 08 Jun 2022 18:57:59 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7BE9A61C31; Wed, 8 Jun 2022 18:57:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A935C34116; Wed, 8 Jun 2022 18:57:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654714676; bh=vLpG0kVD4GILkpMDJR4jVsJpyI+u2DE2pD2XOqo8TIs=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=pgtQx0Gq9fRSLpeqru15gy6mdYtyqiJjS0RcmrCugcOvmbyw7KpQH5P5X2rguLpn+ tGHObQqHJMtF2QXQNp2FNx/9dq1s9EuFkVkNeArqrqOMrDrKnTxYM4Ri97KAZVaCoR Km93EXcM2PFeqSy64/Ust3a9uikhJhimAcM5LQgkxMBT7bD6cL+f3OlaUef7cXp+X6 +NTp+TpXgARM3sFYKjjHU3N83MptG2fa8d9Qd5MXJp7eustrWx40FPCG/VNtxtoQ3k uvgVG3QcxwUNATHD6tjNpxXNhgyS0nryeJ0/7+x9kWd4Cc4wrVZDXX5fKsg6hrAyIa cH0OOSRc0SPMw== Date: Wed, 8 Jun 2022 13:57:54 -0500 From: Bjorn Helgaas To: Richard Zhu Cc: l.stach@pengutronix.de, bhelgaas@google.com, robh+dt@kernel.org, broonie@kernel.org, lorenzo.pieralisi@arm.com, jingoohan1@gmail.com, festevam@gmail.com, francesco.dolcini@toradex.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Subject: Re: [PATCH v9 7/8] PCI: imx6: Move the phy driver callbacks to the proper places Message-ID: <20220608185754.GA411026@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1651801629-30223-8-git-send-email-hongxing.zhu@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220608_115758_138095_B915770C X-CRM114-Status: GOOD ( 10.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 06, 2022 at 09:47:08AM +0800, Richard Zhu wrote: > To make it more reasonable, move the phy_power_on/phy_init callbacks to > the proper places. > - move the phy_power_on() out of imx6_pcie_clk_enable(). > - move the phy_init() out of imx6_pcie_deassert_core_reset(). I'm not sure what "make it more reasonable" is telling me. In subject line and commit log, please say something more specific than "the proper places." It's probably more important to say where they are moving *to* than where they're moving *out of*. > In order to save power consumption, turn off the clocks and regulators when > the imx6_pcie_host_init() return error. Is the power savings the *reason* for this change? I can't tell from the commit log. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel